From nobody Sun Sep 13 12:32:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hjSMn5gbfz6rcKg for ; Sun, 13 Sep 2026 12:32:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hjSMn503Fz4phd for ; Sun, 13 Sep 2026 12:32:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789302725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3BkuhwApQtfDnZ9dKfv3BolgOhnkUKVEW4dntBWGxcY=; b=io2EMbhyqokGeovnzv9KjXi8SBCmW6l4PLEFKNUrXvc980rohvG05/ORIsMIP0VX0L79Jh zZxrgUhn9Wztgqod1XYXyT435Hw5oc8vEXbY5TJw3xkPtfXIQ0RMCqkAthRM0AXDA/MgLD sNjnmADbH+6q4RoJgLF7/wq4beJHfEcS0bi5SMVWFPm9JK/l6TfFufe8ufcBmps+Cp1Hiv 5Iee8sr/noBIWBbdewQKFIak0ayb5B34mrF+PxIpHdIyGvoPZcZ8R7WEJdhZTPaTa/uy1r dkmZYbVSWlbYJ40mZIe4zYUPXMZiZr4+5z5rroPg97sBHs1ju9SJrOaeUd/LLw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789302725; b=jaYFm1DyT/oxDCo58DQQuzY/kBuJZY86zvruu1lFZ8jiJi7IG6XQm+3/XXwEpiuWJj9+QT QY5imVdkLy7HqJYMTe1Mb4i7nhKp55DWde8pBQxSjw5ufo8/Y/5Lf/6kRbxLQlIoQv6ZBp rOulXrR/tgcPyCgxqixUTWUOz+vAThpclGavMigOECiDUqbBfhlDzE1+b1UXK5wh2Cheaz lcUiDunV3uZu400UDVqgnmzMQbpUHuQsmi9bZmoKpKBE/lSTrpcBhXOG+zcdnJNn6SJVjG VNG9z6opUJ70vJvZq6WaFqNIK/SuS86csKKgJZyPb+bSgD3Bu5GHIbSegqfWJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789302725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3BkuhwApQtfDnZ9dKfv3BolgOhnkUKVEW4dntBWGxcY=; b=kTFSLHive6sjC0hiHFqjS3xfX8Zr/WLEuZz5tqJPpo0c8fP/I+TWSmc7KIb6Si3dABe7bm RQPr+tDqAxKMo2i2Snq1vYXPeNa5T5O+f6lxTs5iNlwMbGOZJWiGw5xFkrvqaGqCXZz62X lRqEzi9CbdoQxsFn4kOoTPPe2reKORXJ6ATRnQmkEzZsmMbeoq68C6heUugLF6vQswAyWJ D+yO6FalTbdKJES1S20x8SqQdPX4kPI+uvRkzxAply4JL157ZW/wITLH/5H1FTVMfiTwZk 5ersMhjGYMRO/pSffOt1tooPp2FdRmtUVzToRI1aKYmHbcXpgMQAoS0jjCiLWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hjSMn42kKzjjZ for ; Sun, 13 Sep 2026 12:32:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1aaf3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 13 Sep 2026 12:32:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 9094f86b57a7 - main - graid3: Restore lock acquisition List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9094f86b57a7e4b356cae83f35c8d41c842b42a2 Auto-Submitted: auto-generated Date: Sun, 13 Sep 2026 12:32:05 +0000 Message-Id: <6aa697c5.1aaf3.22a11e8d@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=9094f86b57a7e4b356cae83f35c8d41c842b42a2 commit 9094f86b57a7e4b356cae83f35c8d41c842b42a2 Author: Dag-Erling Smørgrav AuthorDate: 2026-09-13 12:27:18 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-09-13 12:27:18 +0000 graid3: Restore lock acquisition The lock acquisition in g_raid3_ctl_insert() was improperly dropped a while ago, making it impossible to add or replace a device in an existing graid3. This went unnoticed because the tests are broken. MFC after: 1 week Fixes: fcf69f3dbce6 ("Consistently use gctl_get_provider instead of home-grown variants.") Event: EuroBSDcon 2026 DevSummit Reviewed by: delphij Differential Revision: https://reviews.freebsd.org/D59563 --- sys/geom/raid3/g_raid3_ctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/geom/raid3/g_raid3_ctl.c b/sys/geom/raid3/g_raid3_ctl.c index 5eafcce917cf..11d612b93376 100644 --- a/sys/geom/raid3/g_raid3_ctl.c +++ b/sys/geom/raid3/g_raid3_ctl.c @@ -425,6 +425,7 @@ g_raid3_ctl_insert(struct gctl_req *req, struct g_class *mp) no = gctl_get_paraml(req, "number", sizeof(*no)); else no = NULL; + g_topology_lock(); gp = g_new_geom(mp, "raid3:insert"); gp->orphan = g_raid3_ctl_insert_orphan; cp = g_new_consumer(gp);