From nobody Sun Sep 13 02:57:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hjCcs1Cysz6rV97 for ; Sun, 13 Sep 2026 02:57:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hjCcs0l70z3RL8 for ; Sun, 13 Sep 2026 02:57:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789268253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zB1N2BlLsvM4rT1FhL6kQeGlZY8lt4pl0gHl0qp7rVc=; b=jQ9RLRdcfi7TVE89a4kyRtGjMDEo5mLuPudTRHcX6tbZrsgBKX9jHj5fhCxmZ5AR0Kz1Vb fZrwIk5/jfLssnbIdN0Ss4IJx9LmUbcjGf+3TDjM5ZYRJUqD2AL9pavMBcbWBeDkZcQwKX VKPq5cp5ZV0GQw7M8tMYlTlswXqscwZ3149GPg6w/u4LFcs3Xg3YGPrXJJrV4/r1kBpJ28 R14LXRhoZAfeIZeUr+6xaiEGiO9ehdVY0yGTKSXGWtK3xmQc4Ip6GB6ScqcfWvuqaGw1vB M2H1bMt37hmP0usA5vJTWTLVZDmSKx+wIZ6q00NY5ETLox3f3FxtdiAd6oCsXA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789268253; b=oeABb0wW/ZWlUxU0uXn+6hUdtpz7/JnZNuPR/872+7RdiQvDgchIGhy4OQTC6DI6vDNKov Lys5zOSNOJFfnIT7P6FYXws5xX1zQ7UWDZ8bAXagbsI6bHVOzYt0pLayYbvLVOyM7Gn+Fx pNzBae/6h2dsw3nO5PhlTax9QLa6X0loMRXsrcQzVhKzpGrJCjKyui+tGTd5qUWJ1AJJlQ rPsL2T1Y6gc73mO/HGqT8N3K2aSXojecwCkwpLfY7ETwjHTsEwAlujMvGU901JcNZsLfSA ilxUW9RvdKtstrdJONBMljCuBc9OMXv4gmfomCcN39sMZbTBqMgP6VYfaYJynQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789268253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zB1N2BlLsvM4rT1FhL6kQeGlZY8lt4pl0gHl0qp7rVc=; b=H+RldjRISWHlJk9wSB7W9IpL1J/ra5r5VGe2KQUjEImXSVTm2Fo+/yQ/UU3b9mnhxuFkEZ uaplqZ3f3uwXessZokBbk2e0h0prIVWRIkLBZnZmpigDcrM6i5amyOwWqB8XJNdri88P4N 7WqhYyHCR3m/O7kv6RaIjDW1o7SoLYZ7IJD8Q/oCh55I9Li4NzqR2pJyFfwQxckTqFj+bM UMood5F8X/Tj/nDVUiZqR3GNcQrT82tnsC+V8NjDCGOhwDaCfbtzb4wri5+iizAPj5IwYi fdSKXT9I4Wn0oWbeo0Wkz0Md65gKnh6IQe2o4ATW4Ttb9i34yN3twJ9nl9JlEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hjCcr6czSzPDs for ; Sun, 13 Sep 2026 02:57:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31766 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 13 Sep 2026 02:57:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Andriy Voskoboinyk From: Adrian Chadd Subject: git: f616f8a83ba1 - main - iwx: fix kernel panic on module unload with assertions enabled List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f616f8a83ba1bf8aa41003837c11a0f0955efed8 Auto-Submitted: auto-generated Date: Sun, 13 Sep 2026 02:57:27 +0000 Message-Id: <6aa61117.31766.447ffe70@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=f616f8a83ba1bf8aa41003837c11a0f0955efed8 commit f616f8a83ba1bf8aa41003837c11a0f0955efed8 Author: Andriy Voskoboinyk AuthorDate: 2026-09-13 02:26:53 +0000 Commit: Adrian Chadd CommitDate: 2026-09-13 02:26:53 +0000 iwx: fix kernel panic on module unload with assertions enabled When interface is up and running 'kldunload if_iwx' stops the device and executes RUN -> INIT state transition. Since the device is already stopped iwx_run_stop fails to stop the device again and returns non-zero exit code from iv_newstate callback which triggers 'INIT state change failed' assertion. I reused IWX_FLAG_SHUTDOWN flag to: a) set it in iwx_detach b) check it in iwx_newstate_sub - when it is set all custom state transition logic is skipped Accidentally found while experimenting with iwlwifi / iwx drivers Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D59624 --- sys/dev/iwx/if_iwx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/dev/iwx/if_iwx.c b/sys/dev/iwx/if_iwx.c index 372fa440466c..ee12e330de92 100644 --- a/sys/dev/iwx/if_iwx.c +++ b/sys/dev/iwx/if_iwx.c @@ -8085,6 +8085,9 @@ iwx_newstate_sub(struct ieee80211vap *vap, enum ieee80211_state nstate) int err = 0; IWX_LOCK(sc); + if (sc->sc_flags & IWX_FLAG_SHUTDOWN) { + goto out; + } if (nstate <= ostate || nstate > IEEE80211_S_RUN) { switch (ostate) { @@ -10679,6 +10682,7 @@ iwx_detach(device_t dev) int txq_i; iwx_stop_device(sc); + sc->sc_flags |= IWX_FLAG_SHUTDOWN; taskqueue_drain_all(sc->sc_tq); taskqueue_free(sc->sc_tq);