From nobody Sat Sep 12 18:19:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hj06m1LY4z6sXF0 for ; Sat, 12 Sep 2026 18:19:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hj06l5b4mz4qk6 for ; Sat, 12 Sep 2026 18:19:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789237151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q6OeHLRPNH20lhmpbDb8tzBN1WTm1LZzKOPdiZuOHU8=; b=eSa6YOCNRNtAXGLN3/2d6BwfDY4M+GK4V/zA5JzVwxSh5/mdYWxHsnVKRZgANbdRcFwIOe B7HCR/74jUuCOjOJxXy1OI3V9YtQUi/UycPXjEfSxeX1XpNyQjbHFNI5XNfWAtC40BfKmZ 5dHClV32+VrVAxollahaq7/w8WPQaagOgk6M1r6r6vKruuOwHImb6M/7lVI8EIRO2INNi4 AjQN0Dv8nKYxuYQfAAYh84Rxc4EiFG3UbJQWAUF+GEjBppLOCZ0dYQP9PeblZZPx3d3pwa NLXsavM+Zj4mEt57JbXSdbL3X3QA2Wtn7TBmNoHw7Z/AgksXKRAX6HybZ0Q/0w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789237151; b=yK2SdCP01G8bidtUet5ubXZ/sPUkhfoNCfQ35ul6EL9JuQLdIfwE0n3/6MxHGziDxg5Ci0 iAIQ01JNPB4Br07/DbUbTGFgs777tm5AaJ/OQ4O38EkFwyVbbEp0tQTQdKCnH6Ge2SiyNQ +61RCWK/yjnh6CfRgBC70CLwzbO2+88trIj2gaj9HlJeAulQjk0rn395/OHoxL7FF/gHX2 SsjVRIPz03e8H92NpTANROoUHNrAEPivtpjFJEVWRrtoPz6h4CUMAw0TTjj1Zng3RJUQCa ZrJ/Y5kAnv4II50gwVGXdYc9+bDvWK3reVVkXOpDniXnZNE8ugqBmHQ/XTC/Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789237151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q6OeHLRPNH20lhmpbDb8tzBN1WTm1LZzKOPdiZuOHU8=; b=wjT76+D15RNnpyuxwCl5as17Et5z5Lfs8mb+1dXSCvcWxNDST8T1a+m4+BSZRLZ4sLTtrg QRygxaaVmHQoNXQe3UIXip+TIBI+CiZdgVoZu1cHY0iTV6Fq+gl240Kc7+cwhoRDp4ED/3 0jOB0yigBKXD/mMopY9xmLk9SU6rxpg1OCj+DxDbf0a/EbCo1na1skysqv9QxtBKSBd5V/ VyS459fZsmVXnvXtwkaJyoSeidImVAdfsMjX3OLxdliXDOXhd+zlf/QYYKrtp1PV5HpKbt oT0fzCsz0EXK8MgsQiKt7aFMESreSsN0fT4qwV+KlvmJ4McSCjUbVjJCtbpXIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hj06l4fZXz17vL for ; Sat, 12 Sep 2026 18:19:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4590a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 12 Sep 2026 18:19:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: bbee544312e7 - main - loader.efi: Fix memory leak in efihttp_dev_close List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bbee544312e730e438c57e4d5777bd0687ea6b77 Auto-Submitted: auto-generated Date: Sat, 12 Sep 2026 18:19:11 +0000 Message-Id: <6aa5979f.4590a.24686fd9@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=bbee544312e730e438c57e4d5777bd0687ea6b77 commit bbee544312e730e438c57e4d5777bd0687ea6b77 Author: Warner Losh AuthorDate: 2026-09-11 15:23:42 +0000 Commit: Warner Losh CommitDate: 2026-09-12 16:59:16 +0000 loader.efi: Fix memory leak in efihttp_dev_close Save enough context to free the host we allocated in open on close. Fixes: 6788e42d53c6 Noticed by: claude + Sonet 5 Sponsored by: Netflix --- stand/efi/libefi/efihttp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/stand/efi/libefi/efihttp.c b/stand/efi/libefi/efihttp.c index f725ba0709d8..6b098ff30df8 100644 --- a/stand/efi/libefi/efihttp.c +++ b/stand/efi/libefi/efihttp.c @@ -649,12 +649,12 @@ static int efihttp_dev_close(struct open_file *f) { EFI_SERVICE_BINDING_PROTOCOL *sb; - struct devdesc *dev; + struct http_devdesc *hd; struct open_efihttp *oh; EFI_STATUS status; - dev = (struct devdesc *)f->f_devdata; - oh = (struct open_efihttp *)dev->d_opendata; + hd = (struct http_devdesc *)f->f_devdata; + oh = (struct open_efihttp *)hd->dd.d_opendata; status = BS->OpenProtocol(oh->dev_handle, &httpsb_guid, (void **)&sb, IH, NULL, EFI_OPEN_PROTOCOL_GET_PROTOCOL); if (EFI_ERROR(status)) @@ -662,7 +662,9 @@ efihttp_dev_close(struct open_file *f) sb->DestroyChild(sb, oh->http_handle); free(oh->uri_base); free(oh); - dev->d_opendata = NULL; + hd->dd.d_opendata = NULL; + free(hd->host); + hd->host = NULL; return (0); }