From nobody Fri Sep 11 21:19:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhS9Z39Q4z6rKh3 for ; Fri, 11 Sep 2026 21:19:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhS9Z2k9qz4SGf for ; Fri, 11 Sep 2026 21:19:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789161586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nI4CcjBFsm0cheTlV3M4445jbrvgh0/xy67EFhr/ysg=; b=erYJQxg1lX4ZcNRnAyJL/XTgXQwb26I+x8h74azA8K8aAnWK8l1GeJYdCHDx4KRx+r9PgF kjsfRUgsjwAJnwoGY+LD5wkyOMAsqz5JoRdL6XA9wmlNmRxLizQO3rl6PeKb74MBn6QdVs tVZ3WQZZTDImwZtjz7hd91FcOuAPbfdvMoalGWbBShonpV+DFiXCrOk3KSPPOI4765WW/N IIEgZup8C06FWvkBCKhvbmeHFZ2gV0vWYkpShl80LiKNu+QXGK7H3svBiNp2NdC5ATqG/T w5cHjfWFZW8BAKIIGrkzNrY1RjEOjpDAmL/CkumY8pd05jNne+nAB2ZrEXoaUg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789161586; b=Fwm2nyzq5qlBwuLizBoE3G4AIW1mRembsgzMW0CMsjXXZitl5wB26h0Lo6e0xDozL+PQlJ xEtpxCFdM3yc5qWtmMHXuvZospl73+nzq9uV89K9PRZdAwJUtAFBFnk+5xawJK5VdEHgfY lfDWwTghO/G30Rh+M2iKr6lm35PaJb81OkmgXtYENZvtN3BA6F5YkddnAfKpi6XP9R9tx0 MZIKcgfZrutgsdGyEq/HTWIRMoXmovmpmJWF7+pM1+Vni3S96OoxmUbGe3WP6ipPzlyIgT 6b7j6md36yEBZN6vhQ6McPfc0srKqzm4y7ALAc5u5CFE/j+yCQIkY1/+9F1Wng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789161586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nI4CcjBFsm0cheTlV3M4445jbrvgh0/xy67EFhr/ysg=; b=UsoYboj8zInexOcdvPv4O7au1WyVKqy5A5tJp07X93oM9US0TqBFOxHoBB8bvtZA86Y7XK H1uMxDYFYt/kjKia7vve+xhO6KbiVXyKi2w5Km5rclaT85XUheRqmeVR6q/iwKvmwlaY0Y dl3DttyIYe17XAB3YuTxF92fyq1hNU0/rm3ZLwgpSJJGNtddTpetKOuhbytsc5smlAQnmO 11x7qv+K0mfsPnZ0Yv4qF33GGLEMHBHb7XZsMDku9w+4zCTzfbcGVE9dMsRYvB9+tCgh/I mnL1Z1TyN1+ZCqoK9gr5/uDbgxApfBFmtxt+eKopQPF4tlbnQwdcOB92vr88mQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhS9Z1Y1GzVsY for ; Fri, 11 Sep 2026 21:19:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34046 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 11 Sep 2026 21:19:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 3a4e037989f9 - main - ixgbe: Leave run-state publication to iflib during FDIR recovery List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3a4e037989f91672974eeedf1fa81ce0b684beb7 Auto-Submitted: auto-generated Date: Fri, 11 Sep 2026 21:19:41 +0000 Message-Id: <6aa4706d.34046.1b26debf@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=3a4e037989f91672974eeedf1fa81ce0b684beb7 commit 3a4e037989f91672974eeedf1fa81ce0b684beb7 Author: Kevin Bowling AuthorDate: 2026-09-11 18:56:17 +0000 Commit: Kevin Bowling CommitDate: 2026-09-11 21:19:12 +0000 ixgbe: Leave run-state publication to iflib during FDIR recovery Rebuilding the Flow Director tables does not initialize the interface or restore its queues. Do not set IFF_DRV_RUNNING from that operation: iflib owns the flag, and may have cleared it while a watchdog reset is pending. Restoring it here could admit traffic before the deferred stop and initialization have run. Keep the table rebuild and Flow Director interrupt re-enable unchanged. This path is conditional on IXGBE_FDIR. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixgbe/if_fdir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/ixgbe/if_fdir.c b/sys/dev/ixgbe/if_fdir.c index 37f45cb3808f..dcd930518d01 100644 --- a/sys/dev/ixgbe/if_fdir.c +++ b/sys/dev/ixgbe/if_fdir.c @@ -53,7 +53,6 @@ ixgbe_reinit_fdir(void *context) { if_ctx_t ctx = context; struct ixgbe_softc *sc = iflib_get_softc(ctx); - if_t ifp = iflib_get_ifp(ctx); if (!(sc->feat_en & IXGBE_FEATURE_FDIR)) return; @@ -63,8 +62,6 @@ ixgbe_reinit_fdir(void *context) sc->fdir_reinit = 0; /* re-enable flow director interrupts */ IXGBE_WRITE_REG(&sc->hw, IXGBE_EIMS, IXGBE_EIMS_FLOW_DIR); - /* Restart the interface */ - if_setdrvflagbits(ifp, IFF_DRV_RUNNING, 0); } /* ixgbe_reinit_fdir */ /************************************************************************