From nobody Fri Sep 11 20:57:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhRhK3vl6z6rHyr for ; Fri, 11 Sep 2026 20:57:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhRhK0nhRz4P8t for ; Fri, 11 Sep 2026 20:57:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789160273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eG8bPtBNwtrXOqgb0pcEbH8Lp+DEwhEOUIB1pQJARk4=; b=eHzq3bQVjGX5WY/Q7IOx6VqBLmiWgFurvTWgAw3BmoL9KsbxJ+mJbWwRgYezg7qXaYf0kE OB+kcU3lEjjzaVdizoz6czTndP/gILA+qrKkvR0GLabtomcRw+wjPn0BKJ59h/x7ZuPRRu XZ+Nz5Z599eshz2UFuc3jZYNyYsaAkiOGf+kRiIyfeO17FACFVhLVdGAdBtwxAo4v3mSwr uOAXZS4IdtvDHnq7wEL0jejiAoso0AIKRph7g6y2OC2xVL0s5u9zyV5ozDjrvgHBPxKSg4 dnWoSaK8i9L6yItbyMqjC7GjYGU2tafM3Y9H4ExhUZqQrdP6+CWK3oBBrkzRNw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789160273; b=dBECOmfJLGeZ+US+rHd5icbbJPBHbNTtRonuUMtIQQHupnotLoU5Ie3lBuJN2TwhL+H6RU 2ysPRsiXk5qtA5wa8VkGH1ZK65PYgXqvzyCgok+8u28iIO5H1iO/uFiRbBHdyWMBdeDeJE 5DPhHLjXs8CI8r2uCk2F37dk43ASuGZ3RO+hAt4eNlOYZ0u9jY9e2uGM4Z1ZWdo6olgGk0 5IKcLh98kWk+bq5RyFu6/2uxc38Rbhq6ZgPCsUGpMq+0gH4pV6u4n0Vc0DtCBJ/ObowE+O 0tMb5Y5sNuj8mxGAQn0L9NE26bhmlbZ/X0lug2XGiyL5AUqIDV4DBsL7FmivAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789160273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eG8bPtBNwtrXOqgb0pcEbH8Lp+DEwhEOUIB1pQJARk4=; b=GwPaQKUfnPGIY2hA6rk8VvkShnvnO8qa4EBLoE9ZF0CgmdCF9nh47uU7e9ituKUvQkfqXS CIesW3XU1ei10l3vnyjskPQO2ZKum3E9vgn8td6fV90B2Z45VSwlRVPzvpxSGyMdd2yXLZ 6C7vLXk4ILg5YckPbEOorR0MHTjN8HBrslckwt9cTpmW7UBRqkfOqfd4N4537svOakhp10 Ve7OO0+knM1mGjo0Jrh2FUaRDIhDZhKLxjOtOEy7b8lXk28VOf9FqBpU+xy5wLLmarfbFx 8CK/Wf/InQ7K1Zdj1jX/oFR/v1z/3SBbahSR436zIcjVDxjpjE+yT+OVCNvNwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhRhJ5mnQzTRQ for ; Fri, 11 Sep 2026 20:57:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31d8c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 11 Sep 2026 20:57:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 372803d65d24 - main - ixl: Set critical-error state bits independently List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 372803d65d242b308abd6b312a40ff6987fc3452 Auto-Submitted: auto-generated Date: Fri, 11 Sep 2026 20:57:47 +0000 Message-Id: <6aa46b4b.31d8c.43e62bcb@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=372803d65d242b308abd6b312a40ff6987fc3452 commit 372803d65d242b308abd6b312a40ff6987fc3452 Author: Kevin Bowling AuthorDate: 2026-09-07 13:36:06 +0000 Commit: Kevin Bowling CommitDate: 2026-09-11 20:46:33 +0000 ixl: Set critical-error state bits independently ixl_set_state() takes a bit index, not a bit mask. ORing the reset request and critical error indices produced the global reset index, so a critical interrupt could mask its cause without scheduling the intended PF reset. Set both state bits explicitly. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixl/ixl_pf_iflib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iflib.c b/sys/dev/ixl/ixl_pf_iflib.c index 90fc85198523..723b5b635220 100644 --- a/sys/dev/ixl/ixl_pf_iflib.c +++ b/sys/dev/ixl/ixl_pf_iflib.c @@ -201,8 +201,8 @@ ixl_msix_adminq(void *arg) /* Checks against the conditions above */ if (reg & IXL_ICR0_CRIT_ERR_MASK) { mask &= ~IXL_ICR0_CRIT_ERR_MASK; - ixl_set_state(&pf->state, - IXL_STATE_PF_RESET_REQ | IXL_STATE_PF_CRIT_ERR); + ixl_set_state(&pf->state, IXL_STATE_PF_RESET_REQ); + ixl_set_state(&pf->state, IXL_STATE_PF_CRIT_ERR); do_task = TRUE; }