git: e2bcab51fb50 - main - da: Fix logic error
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 11 Sep 2026 05:32:37 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=e2bcab51fb5053907a7db34978bfa7f112d0c9c6
commit e2bcab51fb5053907a7db34978bfa7f112d0c9c6
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2026-09-11 05:12:55 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2026-09-11 05:12:55 +0000
da: Fix logic error
Apply de-morgan's law correctly to force only 4/2 to go to the
invalidate stage for that ASC/ASCQ.
Fixes: d78d04b17cb24
Sponsored by: Netflix
MFC After: 1 week
Reviewed by: ali_mashtizadeh.com, mav
Differential Revision: https://reviews.freebsd.org/D58525
---
sys/cam/scsi/scsi_da.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
index ab88467f0834..b7b07e922914 100644
--- a/sys/cam/scsi/scsi_da.c
+++ b/sys/cam/scsi/scsi_da.c
@@ -5106,7 +5106,7 @@ dadone_proberc(struct cam_periph *periph, union ccb *done_ccb)
*/
if ((have_sense)
&& (asc != 0x25) && (asc != 0x44)
- && (asc != 0x04 && ascq != 0x02)
+ && (asc != 0x04 || ascq != 0x02)
&& (error_code == SSD_CURRENT_ERROR
|| error_code == SSD_DESC_CURRENT_ERROR)) {
const char *sense_key_desc;