From nobody Tue Sep 08 12:13:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hfNC93mTYz6rNHd for ; Tue, 08 Sep 2026 12:13:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hfNC93G3Vz47Yw for ; Tue, 08 Sep 2026 12:13:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788869637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TbnTgZdtHXstlcPHCgiI3eQJLUA+7C916aCMX75oLcs=; b=L9T/2slxbr7LZvw/EZP2Y+/9X14VdSgBmtObuaSxVe70jEKZG5elqwYuOQ8Aeu0MZDwsDp 8IlFbNCl1OqbCet3honPEHcF15m3+V7DqW0Olov58kgrwtb12y7I97N1LIx8tX1Z9HsiKG iZzgNKAd5OVwRP2/OCUWN6hcQFlHu3JDru0a+VOFzIXKW5C8EvpedhLe3TpPGOvf0YSkzW XmcTv0tOBfKi5bkC3h+4YaRT2JVqJTsZeISFiHFiuAx0nNy3fjBEvp6IRTKa8NPZV//pHC FhzLGlYtfAyW3pj2+zHQKXatme3Mru4Z4r01QipfivO/Bg8Vz8IY7o9K7kBFuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788869637; a=rsa-sha256; cv=none; b=LmUOjhprd4hclTvfRMJuDoWSI6M2y/ZBHoexxi3XdI2rWco9fZW1atiT/t5LkrHlOACa9I fxcEc2eaJSbJMjDzlr4lomNrC3NgpCXb4WMwhkUizT8lxXmR/2aGBy8dkLJ0dBz5tAkkXf 0bOKlWjN/VONWN3PhOiDae0y+yc1N/EM86AgPoSjPwoUk/XC4sx+ZNuTksTFiaMM9T5xDD j2bHUjciT2PklNSM6brrQ9hezRzNpKUqcVmCdVmvmMkcWUWikmkAxzIfYiADfNqpQ3MLto xq21Sfv7bgWuYkmNj9ntCeFVT2CI7iSv9r8jjj6GT80jfFBMcYywEAAxwIql8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788869637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TbnTgZdtHXstlcPHCgiI3eQJLUA+7C916aCMX75oLcs=; b=AaK9oCM+XtpUyC5WuOv7liqtNObwFxo4jr+Qw8ofDTS1THBJ/shys6nWU6C2GsmbhJflbR cDCOQRHgt4RlX9w/HhdVm9NM9asdrV7I/glLQGDxJcEwEyrulMNr278QqGeLFDeJRsljtW dN/SlpVQsqGnBLfO8dukonNalayg8TwGUf1WMEfA4T5Z9UqxUPXWs2+hDoO5QNYBciday7 67Y/ZXKMAE03N4ZdJAp5N5OG8msnEsO9Ccigky+lubzdWZMl0Y2W0zRvXu5mJoUZcG8uTV AgLy1t4VDtv+KMP0O3Fd4ybgvEoBBmIz5sQazC3mC0IQwmvSpGOB0KAcWtGRCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hfNC921Bgz141l for ; Tue, 08 Sep 2026 12:13:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 380d1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 08 Sep 2026 12:13:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 18a5549bcb81 - main - lib/msun amd64: use AVX FMA instructions for fma(3) and fmaf(3) when available List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 18a5549bcb81ec084f284a98046631db277ad47c Auto-Submitted: auto-generated Date: Tue, 08 Sep 2026 12:13:57 +0000 Message-Id: <6a9ffc05.380d1.69a45147@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=18a5549bcb81ec084f284a98046631db277ad47c commit 18a5549bcb81ec084f284a98046631db277ad47c Author: Konstantin Belousov AuthorDate: 2026-09-06 05:01:35 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-08 12:13:29 +0000 lib/msun amd64: use AVX FMA instructions for fma(3) and fmaf(3) when available Utilize the ARCHLEVEL framework from libc/amd64/string to provide the way for runtime selection of the implementation, if wanted. Reviewed by: fuz, kfv Discussed with: kargl Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D59462 --- lib/msun/amd64/Makefile.inc | 9 ++++++++- lib/msun/amd64/s_fma_avx.S | 24 ++++++++++++++++++++++++ lib/msun/amd64/s_fmaf_avx.S | 24 ++++++++++++++++++++++++ lib/msun/src/s_fma.c | 11 ++++++++++- lib/msun/src/s_fmaf.c | 11 ++++++++++- 5 files changed, 76 insertions(+), 3 deletions(-) diff --git a/lib/msun/amd64/Makefile.inc b/lib/msun/amd64/Makefile.inc index f1e6aef552ca..0efb16314af3 100644 --- a/lib/msun/amd64/Makefile.inc +++ b/lib/msun/amd64/Makefile.inc @@ -1,8 +1,15 @@ -ARCH_SRCS = e_fmod.S e_fmodf.S e_fmodl.S \ +.PATH: ${LIBC_SRCTOP}/amd64/string + +ARCH_SRCS = amd64_archlevel.c \ + e_fmod.S e_fmodf.S e_fmodl.S \ e_remainder.S e_remainderf.S e_remainderl.S \ e_sqrt.S e_sqrtf.S e_sqrtl.S \ + s_fma_avx.S s_fmaf_avx.S \ s_llrint.S s_llrintf.S s_llrintl.S \ s_logbl.S s_lrint.S s_lrintf.S s_lrintl.S \ s_remquo.S s_remquof.S s_remquol.S \ s_rintl.S s_scalbn.S s_scalbnf.S s_scalbnl.S LDBL_PREC = 64 + +CFLAGS+=-D_RENAME_FMA +CFLAGS+=-D_RENAME_FMAF diff --git a/lib/msun/amd64/s_fma_avx.S b/lib/msun/amd64/s_fma_avx.S new file mode 100644 index 000000000000..6585d0ffb074 --- /dev/null +++ b/lib/msun/amd64/s_fma_avx.S @@ -0,0 +1,24 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright 2026 The FreeBSD Foundation + * + * This software were developed by + * Konstantin Belousov under sponsorship from + * the FreeBSD Foundation. + */ + +#include "amd64_archlevel.h" + + .text +ARCHENTRY(fma, avx) + vfmadd132sd %xmm1, %xmm2, %xmm0 + ret +ARCHEND(fma, avx) + +ARCHFUNCS(fma) + ARCHFUNC(fma, sw) + NOARCHFUNC + NOARCHFUNC + ARCHFUNC(fma, avx) +ENDARCHFUNCS(fma) diff --git a/lib/msun/amd64/s_fmaf_avx.S b/lib/msun/amd64/s_fmaf_avx.S new file mode 100644 index 000000000000..61645693b20d --- /dev/null +++ b/lib/msun/amd64/s_fmaf_avx.S @@ -0,0 +1,24 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright 2026 The FreeBSD Foundation + * + * This software were developed by + * Konstantin Belousov under sponsorship from + * the FreeBSD Foundation. + */ + +#include "amd64_archlevel.h" + + .text +ARCHENTRY(fmaf, avx): + vfmadd132ss %xmm1, %xmm2, %xmm0 + ret +ARCHEND(fmaf, avx): + +ARCHFUNCS(fmaf) + ARCHFUNC(fmaf, sw) + NOARCHFUNC + NOARCHFUNC + ARCHFUNC(fmaf, avx) +ENDARCHFUNCS(fmaf) diff --git a/lib/msun/src/s_fma.c b/lib/msun/src/s_fma.c index 23a84491dd2a..107d78543887 100644 --- a/lib/msun/src/s_fma.c +++ b/lib/msun/src/s_fma.c @@ -163,6 +163,10 @@ dd_mul(double a, double b) return (ret); } +#ifdef _RENAME_FMA +double fma_sw(double, double, double); +#endif + /* * Fused multiply-add: Compute x * y + z with a single rounding error. * @@ -181,7 +185,12 @@ dd_mul(double a, double b) * since this implementation will likely be several times slower. */ double -fma(double x, double y, double z) +#ifdef _RENAME_FMA +fma_sw +#else +fma +#endif +(double x, double y, double z) { double xs, ys, zs, adj; struct dd xy, r; diff --git a/lib/msun/src/s_fmaf.c b/lib/msun/src/s_fmaf.c index 5f3d5d1b1b99..666d2bb26d91 100644 --- a/lib/msun/src/s_fmaf.c +++ b/lib/msun/src/s_fmaf.c @@ -38,6 +38,10 @@ fmaf(float x, float y, float z) return (__builtin_fmaf(x, y, z)); } #else +#ifdef _RENAME_FMAF +float fmaf_sw(float, float, float); +#endif + /* * Fused multiply-add: Compute x * y + z with a single rounding error. * @@ -46,7 +50,12 @@ fmaf(float x, float y, float z) * rounding occurs. */ float -fmaf(float x, float y, float z) +#ifdef _RENAME_FMAF +fmaf_sw +#else +fmaf +#endif +(float x, float y, float z) { double xy, result; uint32_t hr, lr;