From nobody Sun Sep 06 16:49:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hdGQK4szjz6rNXj for ; Sun, 06 Sep 2026 16:49:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hdGQK2p8rz3CWW for ; Sun, 06 Sep 2026 16:49:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2db3305f94fso14624945ad.0 for ; Sun, 06 Sep 2026 09:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788713379; x=1789318179; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=mgEDdL9Loie0YcBKp+HhVegpZqjvPN/0+1ONtnSy37M=; b=rlI/IW2f/tkztsG1yse0JYdseBRcMmdq84pgQzWv+sqBcD5ea9H6kyuS/r6izOYJxe H2odZKYPpDpgvit0pK3WxA4pxX85qP2ujGJhcVHSHH1rHE5WGn3Nrn0o0qjhcwtnrlm/ grWam7D3X2/pjRc33/MjdlLgcz4AJsMfmKDvTrm1hOSi8HtjdczR/qMFfQFa1p0BdXej rRrstVhMhWJZdKyhxcNigTBseEt1qxd1IUkwG2TFrHup7D0H56wQQUkdgEwRx3Dq7YsE ESocMVI3frJjgAXjpwqSWfUcbhOsWMdflcdaM2BxkP+kX5iVZB1fSNU3B/zmxJzk7zY5 82zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788713379; x=1789318179; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=mgEDdL9Loie0YcBKp+HhVegpZqjvPN/0+1ONtnSy37M=; b=Ccz2TdWw85MAgxJl90F9KiKVGt9NKiDi0UELcocU4gR/ypk2wAVWqs4MofWx3Ih2Dy JQ8hTo3duyA7N0WekBzz2TjXS6Ig+9X55Y6LJKo5c8uqBU0+Wt5+2O0zf7arRRgaXq6h Nh89DDRVdjlACVF9i8JQ+fqiePWpa/I4wH50xWfBbtfT0sskZAe333RXC6wmFYY5ffzr wclt1mKAhC49tJaJwU38rgnoKvTulXxJEjgbRsaP5JKT5JOHBaBSNb52YRSVpVc2M6Pq iE5mzJKTexhpHjFaM/Jrd/O4T/ker+50H7qt5tpaDY4ShcIeLSX8oSeQxmqhxu5OwFAe ZRDQ== X-Forwarded-Encrypted: i=1; AKwUvBzommtqgbopnAn4B0C/JGKLmlGTIaj4clS48wvB+uezUM0GKh3peq3VqHO7j+JsXgQMVTtk3G5KkFDOsWDC8mSyDjUm@freebsd.org X-Gm-Message-State: AFuF++mUb91wPIp8rGpf4pOw73VwGtm0+CRCCmoChbLfbW1EY+WDldV7 liHFZwKCQqolu4ZnmupSkHPk8A7dDcnJMAorWueOefdsCEVPTEAmIVYL X-Gm-Gg: AYBFou2kBfPTDHGodiCnSYMc1zCciyRJ9MAMxYB19HbKql1fs78S9E4NIFhKqWWZzi2 z660KwsuLOpBvS0yeLW1VLMLZfFo913Mfq4UJnNo30etCEcHQ1x+1Knv2nKFqwviOL63YJJKyJV EOxjaOqYANy69OirODdokWliqmZz9H1nbM/LmwXnjuZnCjScb5mfYajEJ3kEWEOFBr0FSZHhyef TfsaI8rL6owcU1yorPo68ZRR9RFcg71SlcHc3QrGDhQPlSYp1ftdg19+AEG08rCZDnh2YtX6DHx uGrJ9Osj+5vqm0PGqIf4kBwvKDu9yvdP9vCWSgSSRL6AntVkk78zIA/da/0/xNya+n4mzA0C/0R xXM1hS97UbKcJGpmHU037R/mZKWLt0mlwIpsLoJ43SoR882l6kOkeKGWSPG7rzMMbPiYYq0x/xu YMIgj029Kg3/QgDQXncGLO4bxi62gpg032Rnk3ICFzql28ZGRENx6svwRp3qljgFwysRO4EkgLI 2cidecfIi8SlvN18KnXb6M= X-Received: by 2002:a17:903:198e:b0:2d9:383a:30f1 with SMTP id d9443c01a7336-2db125ce07cmr308642265ad.4.1788713378967; Sun, 06 Sep 2026 09:49:38 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db146b9691sm34170815ad.0.2026.09.06.09.49.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Sep 2026 09:49:37 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: git: fc002631af3e - main - whereis(1): Respect PORTSDIR variable From: "Enji Cooper (yaneurabeya)" In-Reply-To: <6a9d86a4.3ebe2.654627bc@gitrepo.freebsd.org> Date: Sun, 6 Sep 2026 09:49:24 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <1179D554-F68B-4F01-AB16-FC7D741996BF@gmail.com> References: <6a9d86a4.3ebe2.654627bc@gitrepo.freebsd.org> To: =?utf-8?Q?Fernando_Apestegu=C3=ADa?= X-Mailer: Apple Mail (2.3864.700.51.1.1) X-Rspamd-Queue-Id: 4hdGQK2p8rz3CWW X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Fernando! Apologies for not being more explicit when I provided a ship-it = earlier in the differential. There was a style(9) bug introduced with = the change that should have been fixed pre-commit. I=E2=80=99ve highlighted the line below. Thanks, -Enji > On Sep 6, 2026, at 8:28=E2=80=AFAM, Fernando Apestegu=C3=ADa = wrote: >=20 > The branch main has been updated by fernape: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfc002631af3e25c65d74ca6869c13b59= f1af8689 >=20 > commit fc002631af3e25c65d74ca6869c13b59f1af8689 > Author: Fernando Apestegu=C3=ADa > AuthorDate: 2026-09-04 18:27:34 +0000 > Commit: Fernando Apestegu=C3=ADa > CommitDate: 2026-09-06 15:25:59 +0000 >=20 > whereis(1): Respect PORTSDIR variable >=20 > Respect PORTSDIR variable for those who have the ports collection = in a different > place than /usr/ports. PORTSDIR is a very common variable used in = the ports > framework and in /etc/make.conf among other places. >=20 > While here, remove and old reference to CVS. >=20 > Reviewed by: delphij@, ngie@ > Approved by: ngie@ > Differential Revision: https://reviews.freebsd.org/D42156 > --- > usr.bin/whereis/whereis.1 | 4 +++- > usr.bin/whereis/whereis.c | 38 +++++++++++++++++++++----------------- > 2 files changed, 24 insertions(+), 18 deletions(-) =E2=80=A6 > - if (stat(PATH_PORTS, &sb) =3D=3D -1) { > + path_ports =3D getenv("PORTSDIR"); > + if (!path_ports) style(9): C code should test for `=3D=3D NULL`, not boolean false.= --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmqdmZQACgkQGpE5DjPs NJiqnw//R0KJKY0xeBh1ORyZy8zBJbwAv4mLvCZIMSA8opx3FbPSHsVRveyAxHOI jAt69vZALEVG3d+cjDPFWMKfl8UL6o55arjpIluktud0Ne98S3uko4c5pzeznDJW 8tsUBAVzxSSvtI2hUpogwt8CyAoY4uaObyBMKyRfQlFRNyKIpRhU9yq98O7fI7JB 5PlidQNETxNJO0ZFSsH3CXIUGuQV+lHXxcrGHnLL2uM1bCvsVyTDBCKrdIsSQYmm UrcKDA/yPovX8z8ddo5ZUZtX6qs6P7rB6OHdnR4ltgVeMaGmVcOIqVAnvbtvpN6h +PP9MXD0BA7sdoLDtQmT5qUPbwECpd2+BOW/rcPJWV2jQcc/LNiTKy2vfypgFHEI NtH54EwOlCAmkzsAYk5gYtFzGRk3HcK09M9xxh52W2yD5RZRFswe/MMDQtCskb/Y 4Fg6UEu2f/RuQnYfL2B+KvMGGSWV2JTsBQz0tV/kf5dJJtu0nL/n0gFOUGjnRmvK Q2PRa/xipaC/IZOwHd5W8VPfSRD2j+VmYVIQfooLxKIdiLbmLsNn1pkI5GgNEwX1 tkLckQqBcdXvgVusrw6RZ7DKUh+NE5mLFH8Y4XbiIiAntngdhEeevUqzQQX0/AHM AbBIwPNDaHbxpgpEWfqWA6srQFzoShdwUFs8o5A+mUAVAy7yDnw= =lmBo -----END PGP SIGNATURE----- --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A--