From nobody Sat Sep 05 22:00:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hcnMV54NQz6rCXL for ; Sat, 05 Sep 2026 22:00:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hcnMV2lqyz3xd1 for ; Sat, 05 Sep 2026 22:00:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788645638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LH+f7AP/4gP8wvVecdXmvYJvdXnzEaW9EoRBJDj0Mu8=; b=cOvRgClLq6XBbyAhpMkl+r2L2xQ0n8mWtTLrRM/C8Xsa7SS7YNA8QcUqRvRrEnfYSgRVZa 6H8Lb71X9tY3JVL4A7qBuoInxUH1ibD+5VywWM2pc7KBb+BOZuUwqitxEo2a64jD0t7tPH OcLDObWQ1qqAPMj3nVTNpoEHV02NiJh9xBWHlp9HIT5qHgKW8VPpHQFcNt8swCtPEQC7UE 7OZN6Mq8YW0XNERq8OaO/EYOX8IiIGtECHY0MLcnr3gvdR0V9XtpsO2fS5lu56Thwkko0g aSqarqOCXBqKDgM2rkL50wR0RMtN4lccR3e/0fFrS3Foj5f30wzcj879L02yGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788645638; a=rsa-sha256; cv=none; b=HHYJTxCbRjU73iM0Dm4eheVny/AX1uGYnZjXCaLXtHD7B1U9iI0zgtHbZsXvm/ygwXsk2D BVQHvvthzfKhO40MkWwYITGoBYjW3flXsjUYkJ4abD+BPMCKkEhwfo0PVbvJYPaAle4gvg YRoBM7e9C51B6l4/CBoGxmqGrY445vYbGcI1MRVkColUcJRN+qjDFsQ6fV59/GDR9m0ER0 syYQopdYSVsDibn/QW5/XLsVEmyvDPrQ9YD6krugpv0VwAk8jbc+dIoPga18MQiiRAR4kh lrJEs3dOxKkRYt7Fr8WPdfg+qzwQFMehlYcg0rpQmKsLSvFTOJ/FXO0eC0ad/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788645638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LH+f7AP/4gP8wvVecdXmvYJvdXnzEaW9EoRBJDj0Mu8=; b=VF5b83hS22BlGE/T8HLiSLrzBIeKg7N6n5nbFp9veqeutQ8tPZUhn6JuTxxsLPe85qEImT qXFZHTxnHB+adhQDbRArEocKV5wfOHoSp/o3KRxpOyMZF6iFthmBMCDK2sjEEgel+elTF5 pPmh7mOCTYfkh5c+DzTjwWaIyqKhbSPyN/vYLOEPVrb7zFBqW0HMeQbSOdYrvwuQwWJ7Tv P5Q/N7CxvlRRWIesCd31oDI9kYKjh9YhRQYGZfcRnThdYhgB7k1LSlLKDcI05v2j3Wqjte XJC4RuuHB350TjfDsSPV7nPc92UCcG01PBAOIV8Kp0ZrP8u5xOWVmV/A1T7/1g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hcnMV0qSqz12m0 for ; Sat, 05 Sep 2026 22:00:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18d1d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 05 Sep 2026 22:00:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5d9e5f49647e - main - rtld: explain the use of rtld_bind_lock in rtld_get_addr_slow() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5d9e5f49647e129bf814e7887b8201bfce8b53e3 Auto-Submitted: auto-generated Date: Sat, 05 Sep 2026 22:00:38 +0000 Message-Id: <6a9c9106.18d1d.70a12cc0@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5d9e5f49647e129bf814e7887b8201bfce8b53e3 commit 5d9e5f49647e129bf814e7887b8201bfce8b53e3 Author: Konstantin Belousov AuthorDate: 2026-08-30 05:20:46 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-05 22:00:09 +0000 rtld: explain the use of rtld_bind_lock in rtld_get_addr_slow() Discussed with: jrtc27 Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D59269 --- libexec/rtld-elf/rtld.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c index f5ef29aaec85..5b40a0b7ab97 100644 --- a/libexec/rtld-elf/rtld.c +++ b/libexec/rtld-elf/rtld.c @@ -5462,6 +5462,11 @@ unref_dag(Obj_Entry *root) /* * Common code for MD __tls_get_addr(). + * + * The tcb->tcb_dtv data structure is thread-local. The reason that + * the function needs to take the rtld_bind_lock exclusive (as opposed + * to only shared, to safely access obj_list in allocate_module_tls()) + * is to protect the rtld_malloc data. */ static void * tls_get_addr_slow(struct tcb *tcb, int index, size_t offset, bool locked)