git: d13ee10b7714 - main - random: don't collect entropy when scheduling software interrupt handlers

From: Gleb Smirnoff <glebius_at_FreeBSD.org>
Date: Sat, 05 Sep 2026 18:06:07 UTC
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=d13ee10b771493ba8fb6d12350240ba7deb26d8e

commit d13ee10b771493ba8fb6d12350240ba7deb26d8e
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2026-09-05 18:03:40 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2026-09-05 18:03:40 +0000

    random: don't collect entropy when scheduling software interrupt handlers
    
    The entropy will be collected in intr_event_schedule_thread() for event
    handlers that are marked as entropy sources.  The quality of entropy
    provided by SWI wasn't great anyway.
    
    Reviewed by:            cem, ngie
    Differential Revision:  https://reviews.freebsd.org/D58829
---
 sys/kern/kern_intr.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c
index 1280c2d85277..cbcee88a2926 100644
--- a/sys/kern/kern_intr.c
+++ b/sys/kern/kern_intr.c
@@ -1076,18 +1076,11 @@ swi_sched(void *cookie, int flags)
 {
 	struct intr_handler *ih = (struct intr_handler *)cookie;
 	struct intr_event *ie = ih->ih_event;
-	struct intr_entropy entropy;
 	int error __unused;
 
 	CTR3(KTR_INTR, "swi_sched: %s %s need=%d", ie->ie_name, ih->ih_name,
 	    ih->ih_need);
 
-	if ((flags & SWI_FROMNMI) == 0) {
-		entropy.event = (uintptr_t)ih;
-		entropy.td = curthread;
-		random_harvest_queue(&entropy, sizeof(entropy), RANDOM_SWI);
-	}
-
 	/*
 	 * Set ih_need for this handler so that if the ithread is already
 	 * running it will execute this handler on the next pass.  Otherwise,