From nobody Sat Sep 05 14:13:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hcb0L3zl6z6qZWN for ; Sat, 05 Sep 2026 14:13:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hcb0L1MBlz3ptb for ; Sat, 05 Sep 2026 14:13:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788617602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=01QZ4aZc8k1TYLa0BE0BlJ0P0kkKn4HI0XQRSzVyyKA=; b=PBBvaXdJxSfAkeGy6ZbyBZcy67O4tfcpnRewzpu9bnNtvG6GCRsSCEiDcHAQSxmEVvtqOI RE8g7X85zipj4/0sh9LV/x287xOhzTo+feJd4okXNER2NP0+UDUT3uKEh8Jr6bfII8SxiK jGm1lwIxJZFk5rzwCGS2XfywT5DzuJIzAH3GUvMfruQWAtNHqbtU0TFnLMvdkuIqSZNXqM tMOZHfSNVzZhhbsPdbyQwL9rowB3lbb7WkY7n9LVaMHQSbkj0SoWTHak/NFw2tLZOWbiou O/3Ep9gjcK+/7mw0OdFXf9seB/KlNs6/awB7fqBXwL5iIxqOEeMQj0UTfBnVDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788617602; a=rsa-sha256; cv=none; b=IfpOprKdScK2vqQD4mc1csDMPI/RSi0PVbuX5wJcZM8eyvVr7enrTNDC+fkcJ6dnHauxCI 3eHcIk03UiH+DbvM5DnYDo5AXlryLhwcRlcvKR6uRobgfO9f9m1fx04l8oVF8Hb3Eb4zNT 9nz1nYW682CphP0qeT7dvr9SLaYwoQUWbv2YIx7ccO3VMXm4I3a2jo+/zP/lsdJbV3jqhq 8Ne9cOOT+AvA5hjn2f4/7JJsAkHSPpt+U81xwXqefniYkz0UQZTNXmxOVGEopnNCywJsey eFqlwS4/eak/FABk6ki6MUVfyjFqHQxeaIeOaAp1iY5jWF/HfHbBLiI/BdrRuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788617602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=01QZ4aZc8k1TYLa0BE0BlJ0P0kkKn4HI0XQRSzVyyKA=; b=PA9NdySOEbuQuu2Qo9qytkkPuZKualnvMBVE9HS7hLTWm3WtEKDkaXiA4qbLN9AtKIVz+j kqnZxb3w2XotO7cHcdQVczpseSJXsAZjiYbsioRHAVGp/5FjGl3OPm4NIsWGwAuRKqr0Wa sRU6N5qYtwNVpElS2gOCgvHS01oPAsOMNevd7ztbh93WW42cFFAyzm78HWCZVjGVJHvaGv cAxvrsyjdHBvKHJD/kZCWcQUZ2D6YcgbOTz5y/oAgOdA6GTfYP9UgYL4c/ur2rcNmqoxhM qQ3oBVgZZo9Kxx2UarOPwMegDCzueLPLFwFs185T6GQh+OoULef/By7RjLNk5Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hcb0L05h4zpdy for ; Sat, 05 Sep 2026 14:13:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37f41 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 05 Sep 2026 14:13:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: a73bb621ca36 - main - contrib/kyua: fix -Wshadow error List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a73bb621ca361edc678bbf49f3ca1acca8aa0344 Auto-Submitted: auto-generated Date: Sat, 05 Sep 2026 14:13:22 +0000 Message-Id: <6a9c2382.37f41.73487822@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=a73bb621ca361edc678bbf49f3ca1acca8aa0344 commit a73bb621ca361edc678bbf49f3ca1acca8aa0344 Author: Siva Mahadevan AuthorDate: 2026-09-05 14:12:11 +0000 Commit: Siva Mahadevan CommitDate: 2026-09-05 14:12:11 +0000 contrib/kyua: fix -Wshadow error This fixes the build with gcc 14: /usr/src/contrib/kyua/engine/prepare/prepare_all.cpp:56:16: error: declaration of 'handler' shadows a member of 'engine::prepare::prepare_all' [-Werror=shadow] 56 | for (auto& handler : prepare::handlers()) { | ^~~~~~~ In file included from /usr/src/contrib/kyua/engine/prepare/prepare_all.hpp:35, from /usr/src/contrib/kyua/engine/prepare/prepare_all.cpp:29: /usr/src/contrib/kyua/engine/prepare/prepare.hpp:51:15: note: shadowed declaration is here 51 | class handler { | ^ Fixes: edb230c4af499203d7a6894b3711fe6574b26040 Reviewed by: igoro, rlibby, ngie MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59346 --- contrib/kyua/engine/prepare/prepare_all.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/kyua/engine/prepare/prepare_all.cpp b/contrib/kyua/engine/prepare/prepare_all.cpp index db8ea330a51e..73591ef5822a 100644 --- a/contrib/kyua/engine/prepare/prepare_all.cpp +++ b/contrib/kyua/engine/prepare/prepare_all.cpp @@ -53,11 +53,11 @@ prepare::prepare_all::exec(cmdline::ui* ui, const cmdline::parsed_cmdline& cmdline, const config::tree& user_config) const { - for (auto& handler : prepare::handlers()) { - if (handler->name() == this->name()) + for (auto& h : prepare::handlers()) { + if (h->name() == this->name()) continue; - int error = handler->exec(ui, cmdline, user_config); + int error = h->exec(ui, cmdline, user_config); if (error != EXIT_SUCCESS) return error; }