From nobody Fri Sep 04 07:21:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hbnvz0G1Mz6rCbZ for ; Fri, 04 Sep 2026 07:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hbnvy3nRtz3hrB for ; Fri, 04 Sep 2026 07:21:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788506510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mG9L3lYz6KHC53D/pcRnRvdYteFuvEvGv1QaxmoCQDg=; b=GFf6MvfMv+WSGMJD9Mf+fjOyS70DMSDgu4Qyx/eCj58T72JnC2+FfN/U9PJJ+97lrvEhQu PvU+kHMbfmzlyGJcmpaGGxl9Aan9qE4s4hPSs0mYB/nKBUuGMmaaDZNHT52tgpT9w8sm3P 3qWjqVYowsAFF9dm8G1DsS2xWleeIBiZJLby4HaRtn2KvEfekoXQSfQW8MF74cYeMjG3DY VRRmVlCE+e890iiUHXPDxZethF29s2eJ2RNdDrV69nT2OMIUQw818C7C+4LenLelAhxY6G lLH0Eo7mTupWE2TO4KRK7HVWa1RkgHAwq5SYwZAqKgrRtnLjv42LLVQFcoKo0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788506510; a=rsa-sha256; cv=none; b=I3UcT8riUlLsCIl19M11qR/rEzvKekQVAImFAh83MkZI8BbIAmZYDkpOMaMCggDyYrUMMr mvU4jnJybdxNojxJiEQzEF9/iGnJyaWDc5CxmCFpKSa8gg/DT4aHhXOeTZi8uEn0Q6nbgv xrv3o3SpUiklHPFejeIPG/fJWAqEzTQ3cTRTcuqoEwOnQ2vGw5epytM/yL/QxoejUkcymD XXTxhllil9ikgFRvzkum//KzH3QNwE4u8Ifd534Ohz9MhfpM1QgsTP9nOOA+rikmUrMxYw 9j4UVyUyyaXgOWQNvXTH5nagwz3qhmnnvFjtjiUz6qaPs0G3WzpkYX9HxHGWeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788506510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mG9L3lYz6KHC53D/pcRnRvdYteFuvEvGv1QaxmoCQDg=; b=hcQWJd+Cvh9Kyd6nEnvbk4Q29DLQ7uywriFWTOUGlZWeNGq/ab+FT3uN5DaKcJeqAGjdcC fsOehWbM6rTyER2mtc9/yu7CitVmgkrD7OGKnE+qncud66j1uDjGuZu8CVEBgYjS7Y+xLX OTXfSefQCTT7sh53WtxESjd3YjVThQE9cc6rJLvEqUndeVUTD7Q2LuYu/cYbUdXWVRMYW5 dWclyY8YF1xlrt/AV1pdiikRuaa9QocGr2RefYHpMwm30l6eF/6/MMdDaQNX3Dv/y8sYo6 IkbG5akQR42ScsSbbwaJboKIWVe2uR07cjIdVLkL7mPjwQCgTVmQjP7c7s9Feg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hbnvx6SXZzpsC for ; Fri, 04 Sep 2026 07:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31c09 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 04 Sep 2026 07:21:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 5d3e31df7c4f - main - tcp md5: fix accounting for SYN segments with unexpected signature List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5d3e31df7c4fc0e53168bac717bed5f94dab7068 Auto-Submitted: auto-generated Date: Fri, 04 Sep 2026 07:21:44 +0000 Message-Id: <6a9a7188.31c09.6b990cd5@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=5d3e31df7c4fc0e53168bac717bed5f94dab7068 commit 5d3e31df7c4fc0e53168bac717bed5f94dab7068 Author: Michael Tuexen AuthorDate: 2026-09-04 07:18:10 +0000 Commit: Michael Tuexen CommitDate: 2026-09-04 07:18:10 +0000 tcp md5: fix accounting for SYN segments with unexpected signature When receiving a SYN segment with an MD5 option on a listening socket, which has not enabled TCP MD5 support, increment the counter for unexpected signatures (tcps_sig_err_sigopt). Reviewed by: rscheff MFC after: 1 week MFC to: stable/14 MFC to: stable/15 Differential Revision: https://reviews.freebsd.org/D59303 --- sys/netinet/tcp_syncache.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 0d8f725455b7..1b7e03e4ff79 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -1528,8 +1528,10 @@ syncache_add(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, TCPMD5_INPUT(m, NULL, NULL) != ENOENT) goto done; } - } else if (to->to_flags & TOF_SIGNATURE) + } else if (to->to_flags & TOF_SIGNATURE) { + TCPSTAT_INC(tcps_sig_err_sigopt); goto done; + } #endif /* TCP_SIGNATURE */ /* * See if we already have an entry for this connection.