From nobody Thu Sep 03 03:28:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hb4n172vRz6qSxd for ; Thu, 03 Sep 2026 03:28:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hb4n16XyJz3gLx for ; Thu, 03 Sep 2026 03:28:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788406101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rfneDUYz8ANbpEdl53e/hAVNFcw97nlVamZYVNsE0i4=; b=VdZcxie9IyQg63KqQCvq1VrXD7Nk7sYVR4DpaOek0yGk/DLzNv1WBsZD+yEmrOz8ms/53i QSZ5pRmRRQE5w3MXBO8eCILmJ01uoesNZuSCiXNDtqmHdALbHtu9E6uHqaUCNVbaOk2M7w sLhXWMt+RbLiDkmK4VB4t8y9qApUdsBnt6bW6VTQqs6P3ZzDcorV7DqLYiUtk+FBojUxM0 OqPyqxsvUiwy3cTqYU89/ucYYeWTRT32vWtqrUTa4XEG8G572v/QSx2uGSTnGfp+d40Jwo t7vfC1CNsNgH7sEqfgD8WAuMwVJVdJCxWUf6wTqR+HrorZBqrqc+ZA+doUcHsQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788406101; a=rsa-sha256; cv=none; b=UlCEaAqSfPen5qGz9aiEX9y6YsACbdJgFKS1qdr7yd+fX5Ud+bRB8fnAHO2y0gZX/Nb/S0 /FMGAX4AOoQgQ/QMb6n88M3fMy7QBbmop3g5I3phhclMPCkNm9OWX25auuCcs/ucyYBE9Q FHC2zc99qJ/lvTla8DyE7tDsGR7MZHc8GqZnJkrNEwUjMElc93Gm6S0HKZvsPFfEF2jpie 04iQlqPMPV5m9zGQMmlwMIrkjIzG+cAns0hAxiorISgI2kydfc5oimcZ/fkgPGyJ4zGbZH o6VOH65nUn3JLiEcN7tN1QMGccgIZnBt2aLM+b1SbZv3KW1y73FtgLYocsIcsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788406101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rfneDUYz8ANbpEdl53e/hAVNFcw97nlVamZYVNsE0i4=; b=BXvwLTpq7WdIkkpJmvDcveUMMHAdz38+kna2QzEXyYng3HGQy4azgDNXvp7UPXTlHaXo41 DEQtxFoNFOll+R857kkKbG1fhlTj6N3ZymvNXD84aBkmr3mKzbhVq1GJmpMP5ESz51tdjd KTKKPnr3N82I40WRjRkmqM2gvuA/dIZi2HGDdWkvaUYvP12E7zrWxAiTbARVbkLmc3SfJL KB8ODq7Qu4M5laS4rMlsvVzi7B7EOfK7ihD3XbTZjt7Po6kfQazVr243cu5SsdPPcmZHdS OfZZLzBOxNO8gH/6a6+Bk8aBF20vXiEeC93pLCWfautlry+Tg8iLH+tc6BANMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hb4n15FJzz1B9x for ; Thu, 03 Sep 2026 03:28:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 366cc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 03 Sep 2026 03:28:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 58f985559ee6 - main - enic: Route resets through iflib lifecycle List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 58f985559ee689e50233b9113df4f37375b48c2d Auto-Submitted: auto-generated Date: Thu, 03 Sep 2026 03:28:16 +0000 Message-Id: <6a98e950.366cc.806f235@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=58f985559ee689e50233b9113df4f37375b48c2d commit 58f985559ee689e50233b9113df4f37375b48c2d Author: Kevin Bowling AuthorDate: 2026-08-26 09:21:55 +0000 Commit: Kevin Bowling CommitDate: 2026-09-03 03:28:09 +0000 enic: Route resets through iflib lifecycle Mark the driver stopped after attach so its first IFDI_STOP() call does not repeat hardware shutdown. Defer error interrupt recovery through iflib instead of calling driver stop and init methods from interrupt context. Let iflib own the stop and restart around MTU changes as well, avoiding duplicate lifecycle operations. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/enic/if_enic.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/enic/if_enic.c b/sys/dev/enic/if_enic.c index 74e3ff6f8721..8d8f75d4611d 100644 --- a/sys/dev/enic/if_enic.c +++ b/sys/dev/enic/if_enic.c @@ -449,6 +449,8 @@ enic_attach_pre(if_ctx_t ctx) dev_err(enic, "Device initialization failed, aborting\n"); goto err_out_dev_close; } + /* Queue DMA has not been enabled; the first iflib stop may be skipped. */ + softc->stopped = 1; ENIC_UNLOCK(softc); enic->port_mtu = vnic_dev_mtu(enic->vdev); @@ -912,8 +914,8 @@ enic_err_intr(void *vsc) softc = vsc; - enic_stop(softc->ctx); - enic_init(softc->ctx); + iflib_request_reset_if_up(softc->ctx); + iflib_admin_intr_deferred(softc->ctx); return (FILTER_HANDLED); } @@ -1091,14 +1093,12 @@ enic_mtu_set(if_ctx_t ctx, uint32_t mtu) softc = iflib_get_softc(ctx); enic = &softc->enic; - enic_stop(softc->ctx); if (mtu > enic->port_mtu){ return (EINVAL); } enic->config.mtu = mtu; scctx->isc_max_frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN; - enic_init(softc->ctx); return (0); }