From nobody Wed Sep 02 17:40:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZqkX6fwnz6qQ7J for ; Wed, 02 Sep 2026 17:40:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZqkX5nf3z478b for ; Wed, 02 Sep 2026 17:40:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788370820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bnmvLqTrm0vqCR+lRprFdzCz1TWoGl8R5R4jP6EywMc=; b=YQio4/hHrtaCnmj+I0uQONlEc+RRkAffcUTVkwtyotX58+QyvYAUpYhefjqfzH9sY4es9J iW2tOJU9q5Fs3rGUOga4buflwjM4adR+ct5+8+YlHha1VnZzbCselnouFhc66SMroskkJn QS5X3NWaCIvpq+cUorxEkS+8H4J7uADpJVaGn7XpbmGeTMyEfyL8ytYyYlAYP5Rv/XTzId erOM6OQnozjDRGNO9lPa1VlcmHGAWArN/sVUHYZfbZEvKiz97riS1eedKT/e0nJg5KblgO ynvE4ZLj61FnNlbDzDw/lVWxqJIGm+z4iefcemafhNUSo+KXiVigKpaxUZ65sw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788370820; a=rsa-sha256; cv=none; b=uvD4vULJTGF+qJizDtsLrrZcx36gGdN0hqXL2Y7QYOyTIOYxm0okRG22l3CuXz0YflxqMq PhgEXTgT5f0qaCko7Q3Vq9l+Rx/6sWWHvFLcEp0yLxZhC2R8fIvCud9CHJt/Ks7mnFBeLh VUJz0VepY+XSF1TU5qDhyHWeEj7FGO5Hoqwf4xXQooKNpHWowtP17EcbWBSEnWdavZgqLV 8wAe+fHGvCIfACTUonZg+4pSIveFassFKe6NfZoF0biqO2g6fOu7yrngtNvrC9Y+v2xNbS +3RHsIlxY8SCBvtCfpKT1U3tIgdt46vUZcgd5LKSDolAYajGYuOHYuHvz5bIvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788370820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bnmvLqTrm0vqCR+lRprFdzCz1TWoGl8R5R4jP6EywMc=; b=EeKX4INNjXfVhe22dVO6Gtz/v143azRBKzd66zsNwjq9kFh2yDNxMC4SOiD26B0HdmjuNo pg4HalIKmlZpo0M/6Ib7PP+3MRwAGD1BQB1iKJ59JBrz/IK80NVHp+LfGYvLD3Wqj+w6hd sOH8RUvc+kj5SkGWUNfoSPPD4flqWyaWAeEPRvRP1/SkFXylGkQG7Ut5OBHF5mqZodI1YN cD0AoUfnazbicSXfTIRPJ3FS2X+Z/Cs2ARAbSwtrp8YiENemxi3dgpcVLj+hEYHwD1IZr/ FLIdGrRBs3y6GbtEWqYy8d2e6IuG9+RHxB5G+6DjRNMJIaDstjnPtz2oEOK4Fw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZqkX4df6ztJr for ; Wed, 02 Sep 2026 17:40:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f006 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 02 Sep 2026 17:40:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 6e94e0734b9d - stable/14 - devstat: Fix a kernel stack disclosure List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6e94e0734b9d3036df8c7d94d827f8eb1119905b Auto-Submitted: auto-generated Date: Wed, 02 Sep 2026 17:40:20 +0000 Message-Id: <6a985f84.3f006.4e263deb@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=6e94e0734b9d3036df8c7d94d827f8eb1119905b commit 6e94e0734b9d3036df8c7d94d827f8eb1119905b Author: Mark Johnston AuthorDate: 2026-09-01 16:07:09 +0000 Commit: Mark Johnston CommitDate: 2026-09-02 17:40:15 +0000 devstat: Fix a kernel stack disclosure The 16-byte "device_name" field was not zero-filled, so could contain uninitialized stack data. Zero the whole struct, as that's the prevailing pattern for this kind of conversion code, and it's more robust in the face of future revisions to struct devstat. Reviewed by: olce, kib Reported by: Reo Shiseki Fixes: a11d132f6c62 ("devstat: Provide 32-bit compatibility") MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59309 (cherry picked from commit 7cb1a76f88158fb690418336b736e66c238cd4f7) --- sys/kern/subr_devstat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index 1bc37b970cbf..a421a1de2b0f 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -431,6 +431,7 @@ sysctl_devstat(SYSCTL_HANDLER_ARGS) struct devstat32 ds32; unsigned int i; + memset(&ds32, 0, sizeof(ds32)); CP(*nds, ds32, sequence0); CP(*nds, ds32, allocated); CP(*nds, ds32, start_count);