From nobody Wed Sep 02 07:39:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZZPc1qKyz6qrGM for ; Wed, 02 Sep 2026 07:39:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZZPc0H9Cz4NjV for ; Wed, 02 Sep 2026 07:39:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788334788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mgGksHaloK6oZyQzMztHOqWZ2FclIJ/KhJgZ0iGU/oE=; b=a1utZaAf8t4yEnyXr3c7kMV9vS1JYRSZ4pdrpSIT5WWrg+YuD1dYfxr/7JbZQvmV/hcxTq 9yKMKzjxkI9d/moQdxrPLpV3UvGtHrMUwlCEm0NyuTUKSGyXQSbftHvdshMpx7PcGt/Rts TGGYuOe13x4ax3W4iiI6fNE/PA56tehN+rI7fPP22pI1MU5+IDIhIx3Tc5yy/c2u5KMbJ7 wqYA3OGaWv+AUXIOcDDqP+LO2pq3cc5lk4Z/zfLPc6JVWuLwlE5rxseJwtlPK6obN0y4HV x9GgHX65CPfyt0QwBwuhc+r1l00PP1MdM1fftT7N5/i9huoNzvT5DyX1XgmhbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788334788; a=rsa-sha256; cv=none; b=RPJhORG2NUqsKWOe7r4T7fdd4fZ0NXX0+i9+1eGfakfG7mLakZzcmTvCkQXGna0rRbsamg B+P3chs+dqsRxK4sKXGg7YXhXriw/GODyRb4UMWvmWH6mK9w0R45PSC/TclXNxWg26OtPr yotAmpujOHHEh0WPW+Pe6sbiKJgAg/bYhClShhho7mOYx4QwJ17q/n+kvuAwj7xwDOeHr8 X7pCXMOAQIC7A4AkPNcKyN7ylLpllyqUZwEAD08NLnP9AjQ735Aoxg2KecKXLNmMYMzITB OIllYrpQnvlQfWCMzvAaUoRqEew0MujX/zm5yWqeHHstkpj/iHs09kBoPod8mw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788334788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mgGksHaloK6oZyQzMztHOqWZ2FclIJ/KhJgZ0iGU/oE=; b=HsWOZfgFzk/kF2w31ahFdNSX4FqjzS/3ekttvjhrE/rv/e/+He8+D+hM283e2gyP6hxBIB T/uIx2eOdM1hKRdcnjbTqIzLm6KaG23ohmPuJQZhqkjsCzb6j7quo6JWTiYb4cAt3dIvn0 inWQdTX0ShQkmWS4VbHNtN+Eb80ODrqSnJXkhjL+h4x0rCrGNgQu96pAGsaJj5PQ2NuIID stKyTJLUuqD5I87gps672oBwP9vyD0W/WiisUljhGLNfIaeoCjuEV2U7vDCs0Tmq1tA0s+ h7yjmVv7jMqmNzBfeRG6yW46cHjhAouapFrFXqW+7ypQKH+34Z07uk001RG/hg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZZPb5JhSzbBs for ; Wed, 02 Sep 2026 07:39:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e5b2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 02 Sep 2026 07:39:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: 4aea6ea2eb40 - main - tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4aea6ea2eb400737837ff8d22c25688f88c7966c Auto-Submitted: auto-generated Date: Wed, 02 Sep 2026 07:39:47 +0000 Message-Id: <6a97d2c3.1e5b2.34d9e00e@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=4aea6ea2eb400737837ff8d22c25688f88c7966c commit 4aea6ea2eb400737837ff8d22c25688f88c7966c Author: Enji Cooper AuthorDate: 2026-09-02 07:38:17 +0000 Commit: Enji Cooper CommitDate: 2026-09-02 07:39:24 +0000 tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ Confirm that creating clients/sockets was successful by testing the result separate from the assignment and test that the return value is not -1 instead of testing that the value returned is non-zero. This fixes the build with [ATF 0.22+][1]. MFC after: 2 weeks Reported by: clang (-Wparenthesis) Reviewed by: tuexen, cc Differential Revision: https://reviews.freebsd.org/D59284 [1]: https://github.com/freebsd/atf/pull/72 --- tests/sys/netinet/tcp_socket.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/sys/netinet/tcp_socket.c b/tests/sys/netinet/tcp_socket.c index 668a3915adb7..b330f1361799 100644 --- a/tests/sys/netinet/tcp_socket.c +++ b/tests/sys/netinet/tcp_socket.c @@ -45,8 +45,10 @@ ATF_TC_BODY(implied_connect, tc) socklen_t len; int s, c, a; - ATF_REQUIRE(s = socket(PF_INET, SOCK_STREAM, 0)); - ATF_REQUIRE(c = socket(PF_INET, SOCK_STREAM, 0)); + s = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(s != -1); + c = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(c != -1); ATF_REQUIRE(bind(s, (struct sockaddr *)&sin, sizeof(sin)) == 0); len = sizeof(sin); @@ -86,8 +88,10 @@ ATF_TC_BODY(getsockname_disconnected, tc) socklen_t len; int s, c, a; - ATF_REQUIRE(s = socket(PF_INET, SOCK_STREAM, 0)); - ATF_REQUIRE(c = socket(PF_INET, SOCK_STREAM, 0)); + s = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(s != -1); + c = socket(PF_INET, SOCK_STREAM, 0); + ATF_REQUIRE(c != -1); ATF_REQUIRE(bind(s, (struct sockaddr *)&sin, sizeof(sin)) == 0); len = sizeof(sin);