From nobody Sat Oct 31 20:24:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jH8Zl620cz6xFGx for ; Sat, 31 Oct 2026 20:24:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jH8Zl4WxXz4Nq0 for ; Sat, 31 Oct 2026 20:24:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793478271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=03omg3+0SEBD01rHmBZQK59UzwCYPByriWUHc8g9jDg=; b=kTWTKNI46UzaW4vzpAOpEzNFTpbAuKQUgUSxYeSoJ5Lo84OJ8V8Y2+RPPNOVMAT0W0jiql eyHdMjqnQTErM978YHJcjfhMQU+dy5zv86macRIrfcW+OeV4VCmlgy2YJHA949EVdcv0Mh 0zBBoeqepvV8C7waT5jqg6gL72yH6zmNSciDisfp2cqibP5rNYuE+SPQc/0ttYwgg5WXMf 5mGjGx1vJqB4Rnu9/7j4NS2E+aUr5MBQwB2zRCD69QWDeN2nSJSo/7S/GVY2M9dhQDyrdp DF2qHfI+xkqQjyVPwFa6KngbiNsPKLD5J4k29c+88Ee558aPMAEwv7VRYfE+fQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793478271; b=De/wjgUz3EATxBkiG2nLuHp8jP5rwloDHFOOwK9Vi1yygQhozNwxYypp3gBqsY2/r3ajaM bn3vzTrb1KfXIVTiVXLrpT6Tud03+Y77TpAX9DmeE/ijt5h16IH6x2tLgG/8qOTHbaFYDl mGxot51Xb8E7y3bU1LOrUrbmvzc8a2SrrDeFZk5dm1l1DDfnXGwFHApijrN+YmsH8YfPcV uQ2ihLqNnoKuhOc+vX7RYo/ch64hbpa/StRQwcq3ODa+2dBfcBNaq9P6QhmmrD9f+khbao 7dLgqqgXd4eSyZVA7iJnukXa/6QRF+Ah/g/FyCmn11m0qyNy1yXKyTDiNRr5Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793478271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=03omg3+0SEBD01rHmBZQK59UzwCYPByriWUHc8g9jDg=; b=a16jl98izAc+Y6Proek421uD5zXno+eVYq4ys9XkP8grMsGh8Y+HnRwp7gamYJtzMi2+LG aPkPQIqDmncjUG4xRKXM42M1u/bCKUQpNdZBjhVKsEJBkms0oJJI0hAtUAGk7kca74zC2b M0gh/jo8sb1wo3z5GC4hOvBTo6hdUy8Rwi5i2OxwFKD8RMluBq5G27d9v3YfUo3ZUKYdze kKg3nBNepl59s0zRkiEvlp1/eaOFYkJt/EWnsThPTzpF3HnJw19gKMvlpLN7yZ5HoKd6yF xE+Lgiwm87ivHXIapdOD52nmgOjCaVWiItEIJK9kfXJeqIUWD7FjfhNhJOptUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jH8Zl3tpbzQxS for ; Sat, 31 Oct 2026 20:24:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33dcb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 31 Oct 2026 20:24:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Christos Longros From: Adrian Chadd Subject: git: f2ba05974900 - stable/15 - rge: use C style comments instead of C++ List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f2ba05974900c69e628bd5da8ad6b4ae73bc166b Auto-Submitted: auto-generated Date: Sat, 31 Oct 2026 20:24:31 +0000 Message-Id: <6ae64e7f.33dcb.19bcfb6e@gitrepo.freebsd.org> The branch stable/15 has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=f2ba05974900c69e628bd5da8ad6b4ae73bc166b commit f2ba05974900c69e628bd5da8ad6b4ae73bc166b Author: Christos Longros AuthorDate: 2026-03-15 20:09:56 +0000 Commit: Adrian Chadd CommitDate: 2026-10-31 20:15:05 +0000 rge: use C style comments instead of C++ FreeBSD style(9) mandates C style comments. The initial import from OpenBSD left several C++ style // comments in if_rge.c and if_rgevar.h. Replace them with proper /* */ comments. Also fix a malformed comment that mixed // with a closing */. Signed-off-by: Christos Longros Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D55743 (cherry picked from commit 9976cff55e8897f74d970567e61512103216cf58) --- sys/dev/rge/if_rge.c | 4 ++-- sys/dev/rge/if_rgevar.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index b2f1311b4c87..e5297edfefbe 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -1125,7 +1125,7 @@ rge_init_locked(struct rge_softc *sc) * causing this to be initialised both from the ioctl * API and if_init() API. */ -// RGE_PRINT_ERROR(sc, "%s: called whilst running?\n", __func__); +/* RGE_PRINT_ERROR(sc, "%s: called whilst running?\n", __func__); */ return; } @@ -2409,7 +2409,7 @@ rge_hash_maddr(void *arg, struct sockaddr_dl *sdl, u_int cnt) { uint32_t crc, *hashes = arg; - // XXX TODO: validate this does addrlo? */ + /* XXX TODO: validate this does addrlo? */ crc = ether_crc32_be(LLADDR(sdl), ETHER_ADDR_LEN) >> 26; crc &= 0x3f; diff --git a/sys/dev/rge/if_rgevar.h b/sys/dev/rge/if_rgevar.h index 924133da45e3..6228f9ff229e 100644 --- a/sys/dev/rge/if_rgevar.h +++ b/sys/dev/rge/if_rgevar.h @@ -123,7 +123,6 @@ struct rge_rx { int rge_rxq_prodidx; int rge_rxq_considx; -// struct if_rxring rge_rx_ring; bus_addr_t rge_rx_list_paddr; bus_dmamap_t rge_rx_list_map; struct rge_rx_desc *rge_rx_list; @@ -137,7 +136,6 @@ struct rge_queues { void *q_ihc; int q_index; char q_name[16]; -// pci_intr_handle_t q_ih; struct rge_tx q_tx; struct rge_rx q_rx; }; @@ -171,8 +169,6 @@ struct rge_softc { bus_dma_tag_t sc_dmat_rx_buf; bus_dma_tag_t sc_dmat_stats_buf; -// pci_chipset_tag_t sc_pc; -// pcitag_t sc_tag; struct ifmedia sc_media; /* media info */ enum rge_mac_type rge_type;