From nobody Sat Oct 31 17:24:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jH4bf1l4Hz6wy6m for ; Sat, 31 Oct 2026 17:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jH4bf0f1fz4mdt for ; Sat, 31 Oct 2026 17:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793467502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iRVnnnyHbW8UjREddpx1dLBahcEzxRTPeyHPRYhA72s=; b=Kim0WxJWu/cCToL1mD96ehik7PH19s+hRpnR6ZnSmCAwjAPr9LN3DRejUjtL5TOOKhvw64 fZNqakpb2ABud/x1/zJxTRzE2Lud86rRYC2q1dH9aQXq90eBKkp8deem/MEbsvNJ+PsxDK 6eFRypqjjgANtRLErqGjcnCHEIycOEGLdpFv9xyfdgYHbe0mR+zYCfzkO/VqlCge9CYX6N Y5RyWoViFm3z+xOtUFyTxAP3oqQ1wUp5MXdDVwvGkQ+7E7kyG3u24QPYvHB7UY35FgtQRs B6F1oL0eF0x+orjc4RASO0qvtNbH5kwn1NPCHRyzDNA5Tn3sv/grm6oSifyO3g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793467502; b=IFTHbioKVC6c3z6RZLTImgccaN6IGK2ziXuW5etLPVV7DP+d/wBs9UtQfGpIldnAbvUa9z 75/SgIBLBL8eVnwVGJwe9KBinxfttxO37H/rxAYzbW4ywesBcIGXdmBFlYjbATrNdiLTVD LvoJkYq1IuoCRItLrDRd60BP2uVwMaFGjoypG5BSejCKAKtZRvt4yVUMJkK4n4bStDg6uU 0kPhsKLFmAZemBQ7xLDrEtfrgO4RxNizy5q8Cavv0dLszbWfLKr22l2ozGvtQiaw/DsxkT G/gId0tdZlw5lqSQixVrnklDV9MTIJyi39zK7gNlnTYsx3phIMb2qLLFwjWNYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793467502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iRVnnnyHbW8UjREddpx1dLBahcEzxRTPeyHPRYhA72s=; b=Ak+NW+x5MG4wSw45olRldPB/+JaJpXuFNvzGMWOjPXOhOvZ5BTdb4pQvbctXBj03HBkzDw kpY0WBQx0UeQOLIK9HE2Qd+ag84I+AB1UJ9CyuLJS99QZF/yjloq7HY2fyh7x0wZQu543F 4k4l7PSD6tG4Frx31TEvheHscvX7AWmq+N0/cRmmaCNRXtEHL/tzENMutt0EZj+4fHcLWT iudMOZlOnaCvdDK+LqSRTgBukBCccWQMmKk7JhdABOXbCi/3i5KudCijVmqgRos24SFEgh Cqfnx/RZDgxzy6kf5kRBdsm+/JiS1Wr8IUoEmq9nnr+GKiKdUcTopvRFJfa5NA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jH4bf0JnnzLlS for ; Sat, 31 Oct 2026 17:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19b88 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 31 Oct 2026 17:24:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Gallatin From: Kevin Bowling Subject: git: 96a1a3355e2d - stable/15 - lagg: re-check port caps after bringing up a port List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 96a1a3355e2d5359c30981d67342d2948431302b Auto-Submitted: auto-generated Date: Sat, 31 Oct 2026 17:24:57 +0000 Message-Id: <6ae62469.19b88.5c28411@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=96a1a3355e2d5359c30981d67342d2948431302b commit 96a1a3355e2d5359c30981d67342d2948431302b Author: Andrew Gallatin AuthorDate: 2026-07-08 12:24:35 +0000 Commit: Kevin Bowling CommitDate: 2026-10-31 17:24:10 +0000 lagg: re-check port caps after bringing up a port Some nic drivers (including iflib) do not initialize if_hwassist until after the interface is brought up. If a lagg member is included in a lagg when its not yet been brought up, that will cause lagg to see if_hwassist=0 and will disable all checksum offload, etc, on the interface. This is almost impossible to debug without kgdb or dtrace, as ifconfig does not surface if_hwassist. Fix this by re-calculating lagg caps (including if_hwassist) after adding a port. I encountered this problem when I had a commented-out if_foo1=up entry in my rc.conf that i neglected to uncomment when I was re-configuring a lagg. Sponsored by: Netflix Reviewed by: markj, zlei Differential Revision: https://reviews.freebsd.org/D58062 (cherry picked from commit 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae) --- sys/net/if_lagg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index 5a2ec97e4aa4..b2d7ab50012f 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -1312,6 +1312,8 @@ lagg_init_locked(struct lagg_softc *sc) lagg_if_updown(sc, true); + /* Recheck port caps; bringing them up may have changed if_hwassist. */ + lagg_capabilities(sc); lagg_proto_init(sc); if (ifp->if_type == IFT_INFINIBAND) {