Re: git: 1cce5ef05d7b - main - lagg: re-check port caps after bringing up a port
- In reply to: Andrew Gallatin : "git: 1cce5ef05d7b - main - lagg: re-check port caps after bringing up a port"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 31 Oct 2026 17:13:20 UTC
On 2026-07-08 14:28, Andrew Gallatin wrote: > The branch main has been updated by gallatin: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae > > commit 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae > Author: Andrew Gallatin <gallatin@FreeBSD.org> > AuthorDate: 2026-07-08 12:24:35 +0000 > Commit: Andrew Gallatin <gallatin@FreeBSD.org> > CommitDate: 2026-07-08 12:27:58 +0000 > > lagg: re-check port caps after bringing up a port > > Some nic drivers (including iflib) do not initialize if_hwassist > until after the interface is brought up. If a lagg member is included > in a lagg when its not yet been brought up, that will cause lagg to see > if_hwassist=0 and will disable all checksum offload, etc, on the interface. > This is almost impossible to debug without kgdb or dtrace, as ifconfig does > not surface if_hwassist. > > Fix this by re-calculating lagg caps (including if_hwassist) after adding a port. > > I encountered this problem when I had a commented-out if_foo1=up entry in > my rc.conf that i neglected to uncomment when I was re-configuring a lagg. > > Sponsored by: Netflix > Reviewed by: markj, zlei > Differential Revision: https://reviews.freebsd.org/D58062 Hello, is guess this is still a desirable MFC candidate for 15.2, is it? Maybe kbowling@ knows - after the huge iflib/nic merges recently... THANKS a lot for that updates! -harry