Re: git: 575529a92d7b - main - bhyve: unsigned <= 0

In reply to: Toomas Soome : "git: 575529a92d7b - main - bhyve: unsigned <= 0"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Harry Schmalzbauer <freebsd_at_omnilan.de>
Date: Sat, 31 Oct 2026 16:25:47 UTC

On 2026-07-13 21:17, Toomas Soome wrote:
> The branch main has been updated by tsoome:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=575529a92d7b35628daace82c2965984c6376e2e
>
> commit 575529a92d7b35628daace82c2965984c6376e2e
> Author:     Toomas Soome <tsoome@FreeBSD.org>
> AuthorDate: 2026-07-13 19:15:40 +0000
> Commit:     Toomas Soome <tsoome@FreeBSD.org>
> CommitDate: 2026-07-13 19:15:40 +0000
>
>      bhyve: unsigned <= 0
>      
>      illumos smatch build is complaining:
>          pci_nvme_parse_config() warn: 'sc->max_qentries' unsigned <= 0
>          pci_nvme_parse_config() warn: 'sc->ioslots' unsigned <= 0
>      
>      Because we are using atoi() to translate string to int, we need
>      to use int type variable for translation.
>      
>      Reviewed by:    bnovkov
>      Differential Revision:  https://reviews.freebsd.org/D58213


Hello,

is guess this is a desirable MFC candidate for 15.2, is it?

Thanks,

-harry