From nobody Fri Oct 30 20:54:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGYJ25N4jz6xY0G for ; Fri, 30 Oct 2026 20:54:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGYJ15s6yz4LFg for ; Fri, 30 Oct 2026 20:54:41 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=r8E9nr3c; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::102a as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-3ae702d28c4so579073a91.3 for ; Fri, 30 Oct 2026 13:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793393676; x=1793998476; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3MyjUI8XzPykEk/NXZx/YO/ZBZ1iayk3KDhKtRTpNi4=; b=r8E9nr3cANc7BH2kLNVQhEs9oUA3aXCdvlr9YdH3DHij1pZ3PtorKCVJWXc5jEVV3c vqx3GBdCy4o/peQHTTR/oWMOR4l+z+YJmn/awD6qcwEudh4j2phwuQlHYsiL/DWHSoH1 OOlJTnRU1dUn5j7U/D9IzFESflHwDvAPMZYho6p04fTn/GIWRSZTFuU/Bu59Nr7aCnRc 9slZXHsUNMFucisJtnUnbOMwxGUgYhxk98o/gv98QECd5zpEMxGNxL291lwabzixvLOa YLF1cppGT2NUeK1U8DKZ8mCfFJwQGBlIR45Aol+Njs/WiPF6noV0M0pGh7BSIPM5Nr/g zHfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793393676; x=1793998476; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3MyjUI8XzPykEk/NXZx/YO/ZBZ1iayk3KDhKtRTpNi4=; b=0z4afGGQviS6+VlwF89tTx11+eZAF2leG7jPs+1K/hpHieOGoyllKkQddvcadf/r/z 4myk1Xb/JwOHHrpA2dGlvqRm70f9Z8WqLzajlhdRjesfg622oQATLXYN9RrmDEx9C01A KBfh4m3eXhMNjzbPh83CufhAMTEeuA8CFjUe5Q6xmsJniKrHVe/VZilBhoIbpHiyCno3 hbiZ1FaEoB1xysJg7O6GEm/yG18CWS8DIR8D0+okl2QG865kJvtcRCaz9Gv+mdDb9ZHy rEIfPyMOjsbNNkBRPtJ8L/AobD2TVV+PtgA3iqEpZtmM/ru9yF6RbML7xmcHe+/4CKih PevA== X-Forwarded-Encrypted: i=1; AKwUvBz0bseHCoxHnPGDdQudz6h3nYYY6NEj3e3W5wFzA4meFeDlgSTExhVlSKfmOxxKLcy6bdzF4nvJOr0JPeakqXTsOtzZ@freebsd.org X-Gm-Message-State: AFq9FYLQ+TuFItfqTZ8P5pi8cVPlT50oUngtCoRWAJDYdv+h06bM2cdC F9j0LLnTQzsGvPCEet+kXb4VyFGCHpV1fddDbeSCTi9xXpoe6yKf6ITO X-Gm-Gg: AYBFou0KFIQS6NiNXzNPjGKoiYMm4JcF9AQstRIAYiakNDIwch3E7lG3qeKtVuxlDwv jBmrL+IfRJvSx0t4jmxmqWtDOsKCDFqO9PJ/o2Jv3JbPECCZ/vUCFRfu5dVOmRK8mFrdSxMHCoW yhHriUDZdklYMfnt8TBjSlaSOyTHdJkDzte159D4lA7BcbsfizFknaENug6rAWbImEZo+6yS/Bx 4Uv1cMHuc3pJEwMstZepNon7Qk9YSMUjp5F4fItHUVApfH/J3HQu8apxJlrxZgD0BEAZmt1JRtN 0hnDrFPeIoONWhTPed1zJKNSt17SVfoq3fhqywSugKw9RIZqiG8iip5DEzuyq+0WxHPCP9XCSIC 8efd+XNEvaj8heaL1l9uk6gMecM+CTCoLaQ3LGG2nYRMU3JMH5pz2YVYSUGMzV1tB427w3eBeZl 8AxCwGBIdS+tTqXep5LBE/XaJMwSwqBSJUXw9i96z9OF6yWEP4npQQrZHz17aD6X6PxlCbN0WFV 7mjw7WKCXTU771d2ExHnilifN5Ek40+sACp6+ENgzZyLREoe0d4ahtZ94AL2VJY6XiZmYTtMSnm 41JoePOLVnyPzxeJgMY2ARMsc4QHvQo8wqQiptm2MWDttz+9PQjU X-Received: by 2002:a17:90b:4f84:b0:3ab:e588:c275 with SMTP id 98e67ed59e1d1-3ae897ccd23mr2573175a91.20.1793393675433; Fri, 30 Oct 2026 13:54:35 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.221]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae84596e3bsm5484869a91.9.2026.10.30.13.54.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2026 13:54:34 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_B46AE9B3-3483-4666-A07F-1226EA684732"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: 3fb03fb35b20 - main - [tests] switch GoogleTest tests to `googletest` interface From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Fri, 30 Oct 2026 13:54:22 -0700 Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: <15E8ABE9-8E0C-4950-983A-FC429826890A@gmail.com> References: <6ae3d7a5.39b6a.63003bda@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Rspamd-Queue-Id: 4jGYJ15s6yz4LFg X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20260707]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102a:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] --Apple-Mail=_B46AE9B3-3483-4666-A07F-1226EA684732 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 29, 2026, at 7:20=E2=80=AFPM, Mark Johnston = wrote: >=20 > On Thu, Oct 29, 2026 at 11:32:53PM +0000, Enji Cooper wrote: >> The branch main has been updated by ngie: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3fb03fb35b20d259e0a3a07fc48f2ecc= 3c5da6e8 >>=20 >> commit 3fb03fb35b20d259e0a3a07fc48f2ecc3c5da6e8 >> Author: Enji Cooper >> AuthorDate: 2026-10-07 18:53:15 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-10-29 23:32:11 +0000 >>=20 >> [tests] switch GoogleTest tests to `googletest` interface >=20 > Please follow the guidelines for commit log messages: > = https://docs.freebsd.org/en/articles/committers-guide/#_prefix_the_subject= _line_with_a_component_if_applicable >=20 >> The new `googletest` kyua test interface--added in 0.15.0 and = fixed in >> 0.15.1--allows tests to be executed and handled in a more = fine-grained >> manner than the way it was prior to this commit. >>=20 >> This change deletes the `capsicum-test` ATF wrapper script, >> `functional.sh`, and all supporting logic in `googletest.test.mk` = as >> well as this change makes that logic unnecessary. >>=20 >> MFC after: 1 month >> MFC with: b68969979d6b ("contrib/kyua: update to 0.15.1") >> --- >> share/mk/googletest.test.mk | 11 +------- >> tests/sys/capsicum/Makefile | 1 - >> tests/sys/capsicum/functional.sh | 60 = ---------------------------------------- >> 3 files changed, 1 insertion(+), 71 deletions(-) >>=20 >> diff --git a/share/mk/googletest.test.mk = b/share/mk/googletest.test.mk >> index 026f6dcacce3..b21576112a78 100644 >> --- a/share/mk/googletest.test.mk >> +++ b/share/mk/googletest.test.mk >> @@ -6,10 +6,6 @@ >> # GoogleTest is a C++ test framework, thus, it does not = describe/articulate how >> # to write tests in other languages, e.g., C or shell, unlike the = ATF, plain, >> # and TAP raw test interfaces. >> -# >> -# For now this is a thin wrapper around the `plain` test interface, = but in the >> -# future this will rely on a newer version of kyua which will = integrate in >> -# GoogleTest support. >>=20 >> .if !target(____) >> .error googletest.test.mk cannot be included directly. >> @@ -34,13 +30,8 @@ BINDIR.${_T}=3D ${TESTSDIR} >> CXXFLAGS.${_T}+=3D ${GTESTS_CXXFLAGS} >> MAN.${_T}?=3D # empty >> SRCS.${_T}?=3D ${_T}.cc >> -.if !empty(GTESTS_WRAPPER_SH.${_T}) >> -# A stopgap/workaround to let kyua execute test case one by one >> -ATF_TESTS_SH+=3D ${GTESTS_WRAPPER_SH.${_T}} >> -.else >> _TESTS+=3D ${_T} >> -TEST_INTERFACE.${_T}=3D plain >> -.endif >> +TEST_INTERFACE.${_T}=3D googletest >>=20 >> .endfor >> .endif >> diff --git a/tests/sys/capsicum/Makefile = b/tests/sys/capsicum/Makefile >> index a8f72d399af9..788fa9f9394c 100644 >> --- a/tests/sys/capsicum/Makefile >> +++ b/tests/sys/capsicum/Makefile >> @@ -10,7 +10,6 @@ CFLAGS+=3D -I${SRCTOP}/tests >> .if ${MK_GOOGLETEST} !=3D no >>=20 >> GTESTS+=3D capsicum-test >> -GTESTS_WRAPPER_SH.capsicum-test=3D functional >> # This test script runs the same test suite twice, once as root and = once as an >> # unprivileged user. Serialize them since some tests access global = namespaces, >> # e.g., mqueuefs, and can trample on each other. >=20 > Below this there are some TEST_METADATA.functional configuration > variables still set. I=E2=80=99ll take a look at this. > After this commit I see a whole bunch of newly skipped tests, it looks > like a regression: =E2=80=A6 It=E2=80=99s not. The problem is that prerequisites aren=E2=80=99t being = met or the test cases were skipped previously, but not counted as = skipped. Prior to this change all GoogleTest tests were run as =E2=80=9Cplain=E2=80= =9D interface test programs, which had a binary notion of pass/fail: did = the program exit with 0? If so the test passed, else it failed. Using ` = lib/googletest/gtest_main/googletest-printers-test:PrintStlContainerTest.S= tdSpan` as an example. Before (from = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29832/testReport/lib.go= ogletest.gtest_main/googletest-printers-test/ ): ``` [ SKIPPED ] 1 test, listed below: [ SKIPPED ] PrintStlContainerTest.StdSpan ``` The testcase was being skipped - the suite as a whole exited as 0, so = the suite =E2=80=9Cpassed=E2=80=9D instead of "failed=E2=80=9D. sys.capsicum.capsicum-test: some of the tests were skipped because they = weren=E2=80=99t run as root. For example: = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29845/testReport/sys.ca= psicum/capsicum-test/ . Prior to this change the tests were run both as = root and as an unprivileged user - this is =E2=80=9Ceasy to fix=E2=80=9D = by linking the test and adding the appropriate TEST_METADATA to it = (it=E2=80=99s a minor regression). sys/fs/fusefs/default_permissions:Access.eacces passed in CI... = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29845/testReport/junit/= sys.fs.fusefs/default_permissions/Access_eacces/ =E2=80=A6 along most of = the other fusefs tests: a few are skipped, but are explicitly marked = =E2=80=9CDISABLED=E2=80=9D, so their prereqs haven=E2=80=99t been met = yet per the test: = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29845/testReport/sys.fs= .fusefs/write/AioWrite_DISABLED_aio_write/ (some of the tests skipped in = CI are lacking =E2=80=9Creasons=E2=80=9D for why the tests are = disabled). Are you running the test locally? If so, please check the =E2=80=9Cskip=E2= =80=9D message (there are a few prereqs that need to be fulfilled in = order to run the tests). Thanks! -Enji= --Apple-Mail=_B46AE9B3-3483-4666-A07F-1226EA684732 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrlA/4ACgkQGpE5DjPs NJh02hAAlDfTxHgsylPET9BNXOEhJGy7Q5qo+itgBZfkFIQiJXFoIFME99k3YUNT Urwz8XdfFeFeSjhUZn8wy+gNMAjgv9BtbomMpPAO1ppS/kIHExK66PZa0xchkyP+ TugEjtKxJkhax7i6jUNHXzI0KX+mLbcC7LD2nzOwES0uzcOxqra9ltXeghujDeib bDff9O1cCpfzXW95E5Yzi1jQslWkun1DGrYwnSyrnTf763+JgkxDxDCJG+N4MO3R jUYYVv1oYVvAYBPyvy+MnP0kp2Ktl2jYMLXVvwtbH8DlWydUrltO+/I0KqMdISwp qSOFK2IKR7XamPOvZJf//TjFbK+8XYOxuQl5vfN0bImFucC5oYwn/Ure9YcgSdep qVY52bda4qhFRlFEg96TV8j/isaFZFipvfSG9+gzf3y9C1QmNSWqlrL+/I489AI0 LpndzAcavpkySO6c/F/CDbXoG840bE0W5alzEFFm7ATe2T9WBjDcULMzgfmbgGdw RCsIe8tyn8vnYhLrBM6/C4F6s0ArF481nPPa0HNesKmyzUopMUzgtHETulHksSyN J2oLx/vmEwuzfcCDG7Jr1OEwtTWf3vudJUtnXrLmn2plsm7Za9yQHm4EweiVIoBP vOWFNNIeBlk7nFKQGt6GowrDVEgwYBNERQBbe4fGU//QIPMc+C0= =PaEw -----END PGP SIGNATURE----- --Apple-Mail=_B46AE9B3-3483-4666-A07F-1226EA684732--