From nobody Fri Oct 30 17:51:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGTF41tMcz6xHYN for ; Fri, 30 Oct 2026 17:51:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGTF36xbRz4lgq for ; Fri, 30 Oct 2026 17:51:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793382712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHeEGjgYLooaUf2BXOCiEzZSuPJfGLm0kG+hiUBlUJk=; b=qKl/Inqsf3gqFnp3XiVSSdZIFt4B4i3ZgK9oIwEvzLTYbKIkCZdHQ/46ocAfu7h3OaX2lr bFvgApttl3ff1KhMMTSfqQUhcO7xBujbBn5D/gmF+A9H4Ii/N9sZj9hwfN8o7niwgGQNLu trCK0R3FTfxSmZFmy0nZVMLvjwWUi85XR6Xwe9OLlamU7dNg6B4tDiRD/L0OQuhqJiEceB 4ACT+FB3Q80ZlmEbjTW4clTlEV4fDecmtzLV8PRt+FDrXqyhGedb2U/4MPduAABQcoXQQ5 xjxsgLSx2KugRV5hgXlWgFmyOS9TmET+HHSuO/OyBq2uExWP5IXpxnTe8UGhYw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793382712; b=G3cNeQNfJadOlGc3VEECNkWA0UYWROoeGSDYhWo1wj1rGIij1aeBnhEwpg1R23SBzAToHO B+0JFjHLvlPlcC4/NMaeODD7257AiA3osgn/kG+10QvEJIrHZi07U/wJRogayojTTVfrHm xXFMxk3HtJYYhjQaHph6SBkJymeqmIL2UQ6dEuGm8P/5QcWtCh5R4QA76B0Fh8SYggZzCF v3HivS9gG/quvaicBaT735xRhwbAOi/2wvtuqunwNTVLdW6dR8MZ+0nC9x/L8ZDeD38BT4 vXd77d3cAHn5srvg2/lZ/CMgkyfpnMDr84Aol77AGEBZpiVTwO3b1BdM1i3oGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793382712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHeEGjgYLooaUf2BXOCiEzZSuPJfGLm0kG+hiUBlUJk=; b=XEPTzQ7gnsUIz5W0VUiDK/8AlMON+Bl5QG+lo0jf24P37cM7/OI1IZivdG0IXbAV+nF+1S yTL2RA5g78MX/AIyzan8zt0I+AjYw3Zd4oDTF3es5iNEXL63jZRMR0Adpn2zHw/+NG0kG8 shDceh44H+W4RLePsC+spU0mHFAP1y5BUpkRbW/fggANOZRPyiwhPLPEZQzgW1Ts6YauXy k/tssv1b6wbZa9kdpODrOaP+hicM4x9hVi7Nr1BFh2NSPoQUyrQaT1XcbBd006KmyXF5Ot NjG+q/THdxe/e1AjA0iqOO1IHfWdqCyXwd6DL7DyR4cgyq0KlseVvjKsE7zYIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGTF36bkZzfF0 for ; Fri, 30 Oct 2026 17:51:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43066 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:51:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gleb Smirnoff From: Kevin Bowling Subject: git: d26372fee6fb - stable/15 - ng_socket: plug node reference leak List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d26372fee6fb6bc79ea34c788566d10812708305 Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:51:51 +0000 Message-Id: <6ae4d937.43066.688793f5@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d26372fee6fb6bc79ea34c788566d10812708305 commit d26372fee6fb6bc79ea34c788566d10812708305 Author: Gleb Smirnoff AuthorDate: 2026-06-26 23:03:14 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:51:43 +0000 ng_socket: plug node reference leak There is no need to reference node in its constructor, the framework already granted us a reference. This extraneous reference was later given back on socket detach. However, if node is destroyed before the socket, the node was leaked. This leak was harmless until VIMAGE, where vnet_netgraph_uninit() would cycle through all nodes and shut them down expecting them to not exist after the shutdown. Fixes: 19284374970533e1aa04020d4f840e8877ed6266 (cherry picked from commit 4d3cbeb7b407e127a5364f86039745068fbfc61f) --- sys/netgraph/ng_socket.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/netgraph/ng_socket.c b/sys/netgraph/ng_socket.c index c570584d4b44..17ab041da558 100644 --- a/sys/netgraph/ng_socket.c +++ b/sys/netgraph/ng_socket.c @@ -584,7 +584,6 @@ ng_attach_cntl(struct socket *so) /* Link the node and the private data. */ NG_NODE_SET_PRIVATE(priv->node, priv); - NG_NODE_REF(priv->node); priv->refs++; return (0); @@ -685,7 +684,6 @@ ng_socket_free_priv(struct ngsock *priv) priv->node = NULL; mtx_unlock(&priv->mtx); - NG_NODE_UNREF(node); ng_rmnode_self(node); } else mtx_unlock(&priv->mtx);