From nobody Fri Oct 30 17:47:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGT8G5Y0kz6xGfN for ; Fri, 30 Oct 2026 17:47:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGT8G3884z4j9M for ; Fri, 30 Oct 2026 17:47:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793382462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TgPOelZGkL4JjEfVzgCHll3f2e6OA77OKCKUXO+sPms=; b=cV+hg/7VLJJP/PSjDIzkHd1mQ1PheATq9tkLEvj/T/MpBDXCG53tqQbF5sw7QnL5NprY0v 5nr9VguOtuEYGNTeLZ0aQo1hkvV8d0QCuSt7lARZ8ci3Fp9WpskzGVgYYfKUcp/tnFQwFe B8rL1Uq3kbZFFKtkQkqyyVIKHTqIi+vv/pERJjbVr7ca3Tw0E+IxX/fX0Prr/UmF+BATd7 HQdL0cudcBDW3055o1Dd79KZ6a8FtsvvWIRfiIpKnmbAduVu2tMfRmGshTKxPPadjCZGT3 VoALIUOvgURfQ1dicherSgtzXmuBhwSTobHyMIVKDLSQSv4FmbnxJfSwmybgKA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793382462; b=XU4xMYr0vAN2T/6OpacF2rrMSVH7EObSDAlinRNgHs5bCMdJb/dp7OzaBx+ptkAp+kTpaZ uMgFWaYNS60eWeyydVLslNDKCdiV+Tvm8h2UUv3LRysDF3Kb+e51LV/fB0tb2Ll95iWXUB kTCwcHo/ZWiX0rgHhQT5T9QTGRJu/WLhBqoGc80MQAs+M9BnA4aEAuXWow3lpt3Z7JcVxC jUImMpCltuHjHIuYecsUXxmSE3YSEZqq13qNQJYSwgnTgf4bmGtNSS2KBxE9K2h/M5KlQI z8LbACscDiSL++3RhhxknTpJ6v/LyUbvto1LeVbzE2WmGwrstlKy1rYMHJREOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793382462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TgPOelZGkL4JjEfVzgCHll3f2e6OA77OKCKUXO+sPms=; b=b/7zaamYRWUptV1nj7g9meL2pNcusqiIe1iACBHoPeW+qDkEFTuntIGGrbw0vz89gv+pK4 BgM39FOxU6RVFcgZtcnSkNRDqS9bn9l2bos9sMXK2AXFGvf3i7K/RCb/AdUnGKjeUV6BTR cYWToxmL75JQYurt4AQdQaqSnXdKlbONkOL6Towyjy29kDCJ5GB9fsdjOpdd58FpFr6Rzw NgioplrjzMcMTc6oTLpuyVEq08Xv+Dzuy15kq8g+A/yymq2ovD35XmhWkiQvuT0xN59Hm3 GhS3OxdfIyXUMpRnj9XO+xTuQOQ68/3bvjadxWvxObcF7fltJhNqz5pZOMMpkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGT8G23YbzfB4 for ; Fri, 30 Oct 2026 17:47:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 408e3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:47:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Gallatin From: Kevin Bowling Subject: git: 401be0a0cdda - stable/15 - pfil: Avoid potential mbuf tag leak List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 401be0a0cdda89ac815600ffe210be08bdc86c8e Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:47:42 +0000 Message-Id: <6ae4d83e.408e3.418c115e@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=401be0a0cdda89ac815600ffe210be08bdc86c8e commit 401be0a0cdda89ac815600ffe210be08bdc86c8e Author: Andrew Gallatin AuthorDate: 2026-10-13 13:01:26 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:47:23 +0000 pfil: Avoid potential mbuf tag leak In '398254f9999e mbuf: simplify m_free' we removed tag processing on m_free() of M_NOFREE mbufs. It is possible that a packet filter could attach a tag to this stack mbuf and call m_free() on it, meaning that 398254f9999e may have introduced a tag leak. However,if a tag is attached without anyone calling m_free(), then this leak was pre-existing. Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D60686 Fixes: 398254f9999e Sponsored by: Netflix (cherry picked from commit f4ff995e361fa72cea240c4dbac2d0931965c80f) --- sys/net/pfil.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/pfil.c b/sys/net/pfil.c index fae150839eb3..400ea4d97fb4 100644 --- a/sys/net/pfil.c +++ b/sys/net/pfil.c @@ -139,6 +139,8 @@ pfil_fake_mbuf(pfil_mbuf_chk_t func, void *mem, u_int len, struct ifnet *ifp, */ rv = PFIL_REALLOCED; } + if (!SLIST_EMPTY(&m.m_pkthdr.tags)) + m_tag_delete_chain(&m, NULL); return (rv); }