From nobody Fri Oct 30 17:37:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGSwD0wfZz6xG00 for ; Fri, 30 Oct 2026 17:37:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGSwD05XNz4dDp for ; Fri, 30 Oct 2026 17:37:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WKlkgo/QgnZBRmbd5/CWJEkQ5FPGXUcyC6bcGh/2Dp8=; b=R5K63Fv6hcET/r96kr/V/K61OZkchbKXyyffw0Y3/MwatObYgDR+WqLZ8L8bR9GIjcWdIU HNdzLXdclvaP4+9oKTCBpU9jtvFslGG0kEIBaVHfvtIEr08iW1OyySWWmNOhwahI0ymkje n6irfp9Yz5zcxEac2LrnWjm69I07OjM8dDrs7B5SAP7zeQqYffGXD+axdbLMsPqoKQsnEg iB6F6IV6Kpeu8S3JU3oZXGoU5tDURMj2L3XcdxmSubbwHER3LnUEkmENsxJHKoGNAXkvtt ckaI7EC8Tym773+h+ER8gq2+4FcFO1hMozHy5WWmBPTSieKB988Re/5F2+9G/w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793381836; b=LXz3a+5POsa8b4HY3myuV7xP7DrvqT3ICQWzLr5g1k4HDYmEL8sgjipaEgK/UIgWdwOUq4 v7PpPPR1irXG8tKyKS+3vg+3SKCosNlOPJVqzgYKXR7lVmhMucceQScDUTyHkUK+ru9qIg X85O4uyVU6gay1oBYEmYlGPaX/eNn2ns4b51ufgz7sB+3S1z3FHXh+9kF3isaBmT+2szg+ 5lLc8mVQm9tbDhHtTkQa6kNHbiyqMwD9bH3BLBM7K5r4nel0e1eM3pAaYDyraDNXDUMk0k TDacouh6RoiWBWd8H4Du0wEQfl3MDvC3ZRvX2GH5y/D02GwzNwcuqvFUTeGUAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WKlkgo/QgnZBRmbd5/CWJEkQ5FPGXUcyC6bcGh/2Dp8=; b=rjY7mR+udVefxlr6DIwXPzKny9ydLK5subPbfFUXQNXTVHx3l23swlpdg9eDCrZykBw9JJ MQWd06w3D1Lwgiyrx603W/FvxSL/iNBLAFUocBP238ROdjRnsxXB9dd1kVZZXIpuVG1uQP Xxb6TThSBLlJeJrdlXgHgdEJfTnA9OJTHDcvFXH5vVNU5ecH+JAfnXP6TCXrkK+EU/eucW T5s1rCuHyUpCARaUFUmhovuX6S1KOvJfR/NLmp5bN8h9D/7gzC4lrEEZCl+rDmbg/TSR6a eK7rwBvsRblXwQnrTOsjV6jUJevb50hNpNoPTbf3KOstWWwxGForx2Sg7/AHQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGSwC6ZKlzdWx for ; Fri, 30 Oct 2026 17:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4106a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:37:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Navdeep Parhar From: Kevin Bowling Subject: git: 86bb4e34d45f - stable/15 - cxgbe(4): Avoid racy access to requested_fec in sysctl_requested_fec List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 86bb4e34d45faf42699de2534b8d4709820fa194 Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:37:15 +0000 Message-Id: <6ae4d5cb.4106a.318e03a8@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=86bb4e34d45faf42699de2534b8d4709820fa194 commit 86bb4e34d45faf42699de2534b8d4709820fa194 Author: Navdeep Parhar AuthorDate: 2025-11-14 07:45:59 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:36:16 +0000 cxgbe(4): Avoid racy access to requested_fec in sysctl_requested_fec PR: 289121 Reported by: Qiu-ji Chen Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D52199 (cherry picked from commit b0cfa27c91c400dcf3e8441cc04f9e5300c7c3af) --- sys/dev/cxgbe/t4_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index e4029ef13160..138a930f9023 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -8973,7 +8973,7 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) struct adapter *sc = pi->adapter; struct link_config *lc = &pi->link_cfg; int rc; - int8_t old; + int8_t old = lc->requested_fec; if (req->newptr == NULL) { struct sbuf *sb; @@ -8982,16 +8982,15 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) if (sb == NULL) return (ENOMEM); - sbuf_printf(sb, "%b", lc->requested_fec, t4_fec_bits); + sbuf_printf(sb, "%b", old, t4_fec_bits); rc = sbuf_finish(sb); sbuf_delete(sb); } else { char s[8]; int n; - snprintf(s, sizeof(s), "%d", - lc->requested_fec == FEC_AUTO ? -1 : - lc->requested_fec & (M_FW_PORT_CAP32_FEC | FEC_MODULE)); + snprintf(s, sizeof(s), "%d", old == FEC_AUTO ? -1 : + old & (M_FW_PORT_CAP32_FEC | FEC_MODULE)); rc = sysctl_handle_string(oidp, s, sizeof(s), req); if (rc != 0) @@ -9008,7 +9007,10 @@ sysctl_requested_fec(SYSCTL_HANDLER_ARGS) if (rc) return (rc); PORT_LOCK(pi); - old = lc->requested_fec; + if (lc->requested_fec != old) { + rc = EBUSY; + goto done; + } if (n == FEC_AUTO) lc->requested_fec = FEC_AUTO; else if (n == 0 || n == FEC_NONE)