From nobody Fri Oct 30 17:35:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGSsv3jKyz6xG8B for ; Fri, 30 Oct 2026 17:35:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGSsv22Byz4bVg for ; Fri, 30 Oct 2026 17:35:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/wZGeSFnYoJM3e5OyoBeu8fDSZAwIfcQWpp8FzfCQ9s=; b=FI7JtQkEbHyLeNnIG2Sh9TI78zGmONdrV/qx2GxIsp13vxKet29/TFKIYw+PYc3kgMJxB3 zekEPqwjs2QLQxJP/a0GrXZCXrNzObivn6VUmCM0bqqOD3mihP8GI70thRB8ljRnQan0aw pSgnFwsdF+g6vJdK2N+Ue+lV2XA2UnO44ui326sNZtdEgC3Fkvmjg70zw4NKElTDlYfamL JcBx8A4gvb7lwYze2Nwz7MRNeQ7KvwBUFPZw3e5K2JN4pMK3/hgMJVoAzuLWWeXtPE05yZ DV/50IRX6l9Ycor0SZIrWn87pL6C5giCcvmzQOIVqOVQGyqEJ/4xt9e+4NlGZw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793381715; b=RWgNzVyhFS4LX25ReFrrYcmqdOz4ermz+H9BDpDKCdxj0/V4+ZWUMEaSgwkC0H1I59BuOm 8Dgksv1opeMbUQFOkjg7Yj9nhfpYJV0J7rKG8dvuGWI6MiYV3xQNSqhce1eXwBcuUGD5mc lSBoLjieKwPgnFtRLo9+MIb/P/QSnITFMe9hz+rYigq6MxoC2tquhscLLcQZaraZaGFlMH 4WSvOvsu7vGPl7IyasNp8/8CqjvQwxel/5b71Xqp1WrHusWkA7exxW/DgyV8fAfJr+oboo YX26jRm2up7IbUYlqxWQrt948q2vTtTEr60cOVfd1QCYuhkcj/aEJIIT4BDp2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/wZGeSFnYoJM3e5OyoBeu8fDSZAwIfcQWpp8FzfCQ9s=; b=d8SNkuKDknqsBnqdYEYceNwBE9S/zU7wGFokEMl/Allp0hL+M4nuIjHETcowGbgXpk4Yr/ dtYZ7BHsBDRAeEPU2GkNv60PDthTREl5b+6HNbe4iMe+oh9s16Jo8bmskyx4kA+bFJW7Nj CvgwvZvJjSTOtunEpARuxEcGvXWqRJnn0b4tKfRiOxkYdlIqbnlZvV4sfS6nSsjSGUDzMi kXZBmsmO8sBWk7PhqRMHBn8/lNF0O3clW4YJVyhV1SuOepWsR4EP5aI0BeHrr8jsgfso/x YPY5ZrT+icTldyPA0/XgZiZIL0gaAU3JciC1WoBc9fUKFyYYmca5Pf1kYa/ePg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGSsv1jRTzdWv for ; Fri, 30 Oct 2026 17:35:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41065 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:35:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Ryan Libby From: Kevin Bowling Subject: git: fee767cd85bb - stable/15 - mv88e151x: fix potential attach and autonegotiation issues List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: fee767cd85bba58a2fa389670e5afbe0e022c26a Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:35:15 +0000 Message-Id: <6ae4d553.41065.4014dd92@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=fee767cd85bba58a2fa389670e5afbe0e022c26a commit fee767cd85bba58a2fa389670e5afbe0e022c26a Author: Ryan Libby AuthorDate: 2025-10-15 04:01:48 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:35:03 +0000 mv88e151x: fix potential attach and autonegotiation issues Reported by: GCC -Wmaybe-uninitialized, -Wtautological-compare Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D45919 (cherry picked from commit 68501a93076ac095be7a96ecd55d15287c497c9d) --- sys/dev/mii/mv88e151x.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/dev/mii/mv88e151x.c b/sys/dev/mii/mv88e151x.c index 618ad81471c9..fb03b2a7a917 100644 --- a/sys/dev/mii/mv88e151x.c +++ b/sys/dev/mii/mv88e151x.c @@ -97,7 +97,7 @@ mv88e151x_attach(device_t dev) { const struct mii_attach_args *ma; struct mii_softc *sc; - uint32_t cop_cap, cop_extcap; + uint32_t cop_cap = 0, cop_extcap = 0; sc = device_get_softc(dev); ma = device_get_ivars(dev); @@ -224,10 +224,12 @@ mv88e151x_fiber_status(struct mii_softc *phy) else if (reg & MV88E151X_STATUS_LINK && reg & MV88E151X_STATUS_SYNC && (reg & MV88E151X_STATUS_ENERGY) == 0) { - if ((reg & MV88E151X_STATUS_SPEED_MASK) == + if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_1000) mii->mii_media_active |= IFM_1000_SX; - else if ((reg & MV88E151X_STATUS_SPEED_MASK) == + else if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_100) mii->mii_media_active |= IFM_100_FX; else