From nobody Fri Oct 30 17:33:03 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGSqN21v9z6xFtr for ; Fri, 30 Oct 2026 17:33:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGSqM62LYz4W2M for ; Fri, 30 Oct 2026 17:33:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FhkmWIOjzAuMqU61yxH90VeNUWrZio8RZv3fxxoNLK0=; b=JJDR8tsq6chN+A3hbYIhcWO9r+MQDtKk45CAlfaXpfydW4Kra+ASCMNL+g4fzxkbJyjfRi 8NN8r7M6bFk817GICWTNJ3kSoYDraA1fZ2vzdz/tT2W0pxoBN4hLI8cqGnVpClTO//l9+J 5qTk3pmA6IsBrDfnaKRl3hMLUX1fwv8JX0sgvuMoN4N8wvelOXdpsJduSoxRtcv/38Lt2W C6mXheGdx8yXLvQAHp6dOTilW2mxUmdoETc53L77aiW/ooYxzqgoyH+crfn4yW4aXwltj+ 84Vm6N9xt3QusXUk0eLTAQz5IdbXrL9EKQKr8bukRt11O1X1aN6axMZOuEyNIA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793381583; b=mEjdybzDkHIW0pALv3lrkN2VpeVmvqP9sy//YnQBPOGO26uAUQgtTjxIoqGviQoGviCYnh dP8We9iM00oKKJO/sf1xGzf3d2JhHrZ85jtiRXbxbzkJZkzKyNb8MSKSieFSGv6ofzEsqx +QgZ5QlLorQ2YNAEUFLPEG7SD5dUEt+Lxv3/rVh3EiSec2IJ3XX3s7TcK52zMeMq8XgEdc be+vEFqysL3e7j498MjnGRzozeaexyWQl2HijtiS5MN7Qclad8RpB9UhrSQT6m6ierekcE CaHtcvUseIuVybvicXBkRRf8o65Lh7tRFGo829/fIaJXkVqgzcgoA7TbShy2tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FhkmWIOjzAuMqU61yxH90VeNUWrZio8RZv3fxxoNLK0=; b=x1Bb6L7xUyjfPfUZf6pNmDT+G96qWshZcdz6NI2LwJ0O+WnqSKiH6XVAm54JE0131C3FvI S3lQAf3UcMs6JM7Ls5zDx5iL0eCCLsGV9MfgJafsrX3/VHCOYUUvj5PhtKtSWM4fGaRrSp TjX95DHl4mY0ncB6nmzqg9nguWPtfkT8y3I/ny3a/X3L7LbpmHnkJYh33/9Pxas8r+wClM RhL5gXcHhXyV2nD271XdaspGhBiIdPbCkWYaevvIY7PEKHBiYziFbqL7VntCjLWZs7sBeI 9YiMCtcNxVjyh0dRlynaoVSXPUtY+1+QWP7n0VYVntGKGjPR1C0T9QS9H4i2EA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGSqM5hdrzdZd for ; Fri, 30 Oct 2026 17:33:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40227 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:33:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: =?utf-8?Q?J=C3=A9r=C3=A9mie?= Jourdin From: Kevin Bowling Subject: git: 15a93289f114 - stable/15 - re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 15a93289f114871817bbd0ef0420fd9e234eef6c Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:33:03 +0000 Message-Id: <6ae4d4cf.40227.668c3bac@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=15a93289f114871817bbd0ef0420fd9e234eef6c commit 15a93289f114871817bbd0ef0420fd9e234eef6c Author: Jérémie Jourdin AuthorDate: 2026-07-19 18:42:22 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:32:22 +0000 re(4): re-arm the Tx doorbell when re_txeof() leaves a non-empty ring On PCIe parts a TxPoll request can be lost when packets are queued in quick succession, leaving owned descriptors with no transfer in progress until the watchdog fires. re_txeof() runs from the interrupt handlers, re_tick() and re_watchdog(), so re-writing TXSTART whenever the ring is still non-empty turns a potential 5-second stall into at most one tick. One register write on a path that already took an interrupt; fast path untouched. * Sustained bidirectional load on RTL8168H; no Tx stalls, no throughput regression at 941 Mbps line rate. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58277 PR: kern/166724 (cherry picked from commit 4bff6b9f5cef13df8540fa6869bd6707f8e7575d) --- sys/dev/re/if_re.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sys/dev/re/if_re.c b/sys/dev/re/if_re.c index eaa9d0ca934b..6bce5432a1bc 100644 --- a/sys/dev/re/if_re.c +++ b/sys/dev/re/if_re.c @@ -2464,6 +2464,17 @@ re_txeof(struct rl_softc *sc) /* No changes made to the TX ring, so no flush needed */ if (sc->rl_ldata.rl_tx_free != sc->rl_ldata.rl_tx_desc_cnt) { + /* + * Some descriptors are still owned by the controller. On PCIe + * parts a TxPoll request can be lost when Tx packets are queued + * too close together, leaving a non-empty ring with no transfer + * in progress. Re-arm the transmitter here -- this routine is + * reached from the interrupt handlers, re_tick() and + * re_watchdog() -- so a lost poll cannot stall the ring until + * the watchdog fires. + */ + if ((sc->rl_flags & RL_FLAG_PCIE) != 0) + CSR_WRITE_1(sc, sc->rl_txstart, RL_TXSTART_START); #ifdef RE_TX_MODERATION /* * If not all descriptors have been reaped yet, reload