From nobody Fri Oct 30 17:28:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGSjz02XPz6xFBV for ; Fri, 30 Oct 2026 17:28:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGSjy2Kxdz4VN1 for ; Fri, 30 Oct 2026 17:28:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4+GQXV2rZFNAIpjwzvfM5rqBwPrzKVOJh7Vix7ahFU=; b=cRe1Ge6KqfGFV08/ikFdlCi6HtoDFN8Lgbp0tt4a6Z6A5dPsVZNGnhmhEz2UDFKw16Agkh p1fKscOTZ6PQ5Ar9A6Iep/SW2I3d+3GJoRytG/Mtnb3AIyJwxFwEL8tzOneTQ77fyWwdLH QG83lpno4G9boHV5ZOAbeaumglZFu6AlfSbE3cXRkGgxw1MeQPJtpJS15WiUHdMk/ThP3t lCW3sxo32JeaKn2pwqhuddml5oTeELEL59uDyBo5RHDl4ugOy7xcXsvhL/DK+uR0ocfiwY LP9+ePCnIxmd8wiloaX7IiaRvPzIvYnkwaiRJL8qRjzbVv4N8/DEPKlqHkQNTA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793381302; b=vwWH/iqNx1F7Wca4mlWb1mSYF4owPed6vNS5Lu6VZCtrrJ7sLQxtzQ9TLbTqdmqrNW2AF8 Sgs3f4GK/yqRnrgg2vrVp+adBvkIqVAvhRKps72xUENUOElnRHmtG+S0Bg9utrmOLkAzgb 7qPkTEYMyrOz8Nl+Oul2Fmds5W6JtNdNWIOFEKWyorH3uD1l6GjbZ7Z4E6WFr7t49PAF2O uzUTlmTBxSgx4eFbLRz7psuv+7zlWV5Bna1FFdKdsopzsdw4fZ0B4GGVRWerjV14zXioRp z8hX3146bAnK+jVXYdT/aern5VSklDjFgdGke589lbjaf/gDgrJnpOlKAg6w9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793381302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p4+GQXV2rZFNAIpjwzvfM5rqBwPrzKVOJh7Vix7ahFU=; b=qvtBb1H8QCmxk96oO+add7cDFjvYtfJ6cbc4OGHak7foe3CvyDIUgeQjK13kULhFiFGawK 8fi0LFDrnSKicmYHMX/BXsnHBit7/Wb6mc583hP6fCoiZpENmIIg7VJt6YeJD0UhP7CT1Y Nywd76COhv0Cd+aFpm1Run4UNISDiZOh+3gb7WmBAOH5l3eNUJn7+dvOsw6P2bwZG2ryCG AC1MXoonqlmCnMWFHJUcXfuWO7b58IlDQqDE81JcjuEqPX6jmUu+fx5hC+1gMgizgpaBGW dRfCuVXJjyQxYWEp/b1SFSXLwZke/bwj9V/r/3nDSKgbE3LoLIUuphDmKcR2JQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jGSjy2040zd9Y for ; Fri, 30 Oct 2026 17:28:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f198 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Oct 2026 17:28:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Weixie Cui From: Kevin Bowling Subject: git: f0287c1a51a5 - stable/15 - bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f0287c1a51a56a870aef78079933a19cee2889a9 Auto-Submitted: auto-generated Date: Fri, 30 Oct 2026 17:28:22 +0000 Message-Id: <6ae4d3b6.3f198.4015379a@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f0287c1a51a56a870aef78079933a19cee2889a9 commit f0287c1a51a56a870aef78079933a19cee2889a9 Author: Weixie Cui AuthorDate: 2026-03-31 13:51:46 +0000 Commit: Kevin Bowling CommitDate: 2026-10-30 17:28:13 +0000 bce: Fix SYSCTL_IN error check in bce_sysctl_nvram_write() The condition after SYSCTL_IN was inverted: success (error == 0) returned immediately and skipped the NVRAM write path, while failure fell through. Return only when SYSCTL_IN fails. Signed-off-by: Weixie Cui Reviewed-by: ngie Pull-Request: https://github.com/freebsd/freebsd-src/pull/2113 (cherry picked from commit f3b59bf28504f901f4fcb568004a92c02fa371ed) --- sys/dev/bce/if_bce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/bce/if_bce.c b/sys/dev/bce/if_bce.c index 6cf39e035ea6..84992af0c6b8 100644 --- a/sys/dev/bce/if_bce.c +++ b/sys/dev/bce/if_bce.c @@ -8861,7 +8861,7 @@ bce_sysctl_nvram_write(SYSCTL_HANDLER_ARGS) bzero(sc->nvram_buf, sc->bce_flash_size); error = SYSCTL_IN(req, sc->nvram_buf, sc->bce_flash_size); - if (error == 0) + if (error != 0) return (error); if (req->newlen == sc->bce_flash_size)