From nobody Thu Oct 29 23:37:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jG0yR3MJkz6xr7k for ; Thu, 29 Oct 2026 23:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jG0yR0btQz4tDB for ; Thu, 29 Oct 2026 23:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K0TkbIsqra4MiI//tpKNZpNi1g7xULD0y45/OBnNnIo=; b=ZphQ/Xz8MqOea7HvUhI4jwZFPZ5eLWxYk0BFdPdRYNKOavduiWABCmlbt7n/VEKLa9AFTd g3n2NyYFCBafkNMp5dgG3By1ySS9pZOD0sr9EPn/k36Ci7PyusLLVqrfUETyIwGcelxTyq pCiTUr7cTmp8q0lgffavP2Ii605bEk37a0eJBqwzuazjjEFToBvEiAnUb7yki0TIZ5gFRO xvBy+TN4fgcZ7UhUim+ACZ4E7gpFdkGicpyl6xK7ugefbI9ScyvFqifY1rMf6Si2Skirvu zLx/uWYJ9XtPpcR1ob+c/OBQCQ7VbYv2sFK33dYBcPzpIzoohK4qWySSM+mfVw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793317055; b=ul5Mie48jQdqgwWpRQCOQNHPTa/hATRNAz2ZhLly6b1lrz0ynmyZOIW1q2yOZoy3phzbVQ a7inBLFwBi3Cq7qPwc6kwRZCh7hwFuRyw+gHMfAJK5kV15lKaaIdEUc8aJ5P2lz3fHcI9g 2EvI7nkMkDl7TLUWmUXJ5Jt5n1lUTXBASV6gNUn70S04BsdZ/t09IZrggHXmizQ4A+84mY N7t19JA3WI/QwD+x0rEv8YYvSya9lnP7SlELAi9/Y7smsQ+YAA4lwjaFgGgUvdQ1XNffxh NRzijl5XFmZuF7n6Mk6yC4REVL14+tHMP7tZJx1VrV8g1y1pX334v1QVOCUjKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793317055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K0TkbIsqra4MiI//tpKNZpNi1g7xULD0y45/OBnNnIo=; b=JUGMmMB3oDVPVUsCLj0BTurL3PzfhzTx7MEIB4I31dZgHBRVBWHonkld199HFqg4iNekry w+3o6fH2IniCzjaoSSknjHi1i3+0QcMUU2K6GNxo2uP0sJMeIqJAHXdkMw3c7xpjnV8vTx +uqf7kW7pJ/ZIkeEbwi5pvQX9q7tNlK0DFTVfvfLEeHkadS9gl2Sb0Pa0Cmy6WOFiREuhV bZoO4llFdGNpcL6bmvaIZf9rGRkyFj4bSgUwD+S1OEpJy/6tfDV6XxUVr5My58qf9vFs8s hXAKOrWTqUWshlS+CsVv+/M4sKuLNh4SSvJNefUBhHLKrrPmZHSiW+mlll348g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jG0yQ6zV5z11kS for ; Thu, 29 Oct 2026 23:37:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39e5a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 23:37:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Sumit Saxena From: Kevin Bowling Subject: git: 84234f3dd179 - stable/15 - if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 84234f3dd17949bf4010fb0be102c8c75795f8de Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 23:37:34 +0000 Message-Id: <6ae3d8be.39e5a.4fb9533d@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=84234f3dd17949bf4010fb0be102c8c75795f8de commit 84234f3dd17949bf4010fb0be102c8c75795f8de Author: Sumit Saxena AuthorDate: 2026-08-01 09:07:47 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 23:25:51 +0000 if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close() bnxt_fw_reset_close() unconditionally called pci_disable_device() after freeing the Rx IRQs, on every firmware reset, not just the BNXT_STATE_FW_FATAL_COND path which already disables the device via bnxt_fw_fatal_close(). BNXT_FW_RESET_STATE_ENABLE_DEV in bnxt_fw_reset_task() already re-enables the device unconditionally, so this wasn't leaving the device disabled, just adding an unnecessary PCI disable/re-enable cycle around every non-fatal reset. Reviewed by: gallatin Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58619 (cherry picked from commit 4fbb63f289ed6a06e715c6882e8fff3201381743) --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index 1aae1271c24f..b1e90ae06a86 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -1993,8 +1993,6 @@ static void bnxt_fw_reset_close(struct bnxt_softc *bp) iflib_irq_free(bp->ctx, &bp->rx_cp_rings[i].irq); } - if (pci_is_enabled(bp->pdev)) - pci_disable_device(bp->pdev); bnxt_ktls_del_all(bp); pci_disable_busmaster(bp->dev); bnxt_clear_ktls(bp);