git: 7b23b63edfe0 - main - Revert "bind_all_fibs: Disable bind_all_fibs by default"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 29 Oct 2026 16:22:21 UTC
The branch main has been updated by pouria:
URL: https://cgit.FreeBSD.org/src/commit/?id=7b23b63edfe09d6509174ecd3aa2f32f143b7a8c
commit 7b23b63edfe09d6509174ecd3aa2f32f143b7a8c
Author: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
AuthorDate: 2026-10-29 16:19:54 +0000
Commit: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
CommitDate: 2026-10-29 16:19:54 +0000
Revert "bind_all_fibs: Disable bind_all_fibs by default"
This reverts commit 714433a6772b346723341735ef9547f672d9d2a3.
There were issues reported by markj
I will hold this commit until those are fixed.
---
UPDATING | 10 ----------
sys/netinet/raw_ip.c | 2 +-
sys/netinet/tcp_input.c | 2 +-
sys/netinet/udp_usrreq.c | 2 +-
4 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/UPDATING b/UPDATING
index abcbbfbf5ee5..44b77a813e48 100644
--- a/UPDATING
+++ b/UPDATING
@@ -27,16 +27,6 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 16.x IS SLOW:
world, or to merely disable the most expensive debugging functionality
at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".)
-20261029:
- The net.inet.{tcp,udp,raw}.bind_all_fibs sysctls now default to 0.
- This allows applications to bind to the same port in different
- FIBs. As a result, a socket bound to a specific address only
- receives traffic from the FIB it was created in (see setfib(1)).
- Sockets bound to the wildcard address are not affected. If you
- use multiple FIBs and rely on such a service accepting traffic
- from all of them, set these sysctls to 1 to restore the previous
- behavior.
-
20260919:
less(1) has been updated to version 710, which removes the obsolete
lesskey(1) utility. It is no longer built or installed, and the
diff --git a/sys/netinet/raw_ip.c b/sys/netinet/raw_ip.c
index e2fea834ee79..1360dedbb2ef 100644
--- a/sys/netinet/raw_ip.c
+++ b/sys/netinet/raw_ip.c
@@ -128,7 +128,7 @@ void (*ip_rsvp_force_done)(struct socket *);
#endif /* INET */
#define V_rip_bind_all_fibs VNET(rip_bind_all_fibs)
-VNET_DEFINE(int, rip_bind_all_fibs) = 0;
+VNET_DEFINE(int, rip_bind_all_fibs) = 1;
SYSCTL_INT(_net_inet_raw, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN,
&VNET_NAME(rip_bind_all_fibs), 0,
"Bound sockets receive traffic from all FIBs");
diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index e7554b6c6e07..5ebcad5eae43 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -131,7 +131,7 @@ SYSCTL_INT(_net_inet_tcp, OID_AUTO, log_in_vain, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(tcp_log_in_vain), 0,
"Log all incoming TCP segments to closed ports");
-VNET_DEFINE(int, tcp_bind_all_fibs) = 0;
+VNET_DEFINE(int, tcp_bind_all_fibs) = 1;
SYSCTL_INT(_net_inet_tcp, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN,
&VNET_NAME(tcp_bind_all_fibs), 0,
"Bound sockets receive traffic from all FIBs");
diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c
index 2eac13d167d8..79d292983c24 100644
--- a/sys/netinet/udp_usrreq.c
+++ b/sys/netinet/udp_usrreq.c
@@ -103,7 +103,7 @@
* Per RFC 3828, July, 2004.
*/
-VNET_DEFINE(int, udp_bind_all_fibs) = 0;
+VNET_DEFINE(int, udp_bind_all_fibs) = 1;
SYSCTL_INT(_net_inet_udp, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN,
&VNET_NAME(udp_bind_all_fibs), 0,
"Bound sockets receive traffic from all FIBs");