From nobody Thu Oct 29 15:56:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFpk837Qgz6xDwr for ; Thu, 29 Oct 2026 15:56:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFpk80p79z4h0t for ; Thu, 29 Oct 2026 15:56:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793289376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3IYulkVARfhrN2qvjFUPzciKGLvBj9KWwSr2SQil5dE=; b=HuJDWjRe8dMPfL7O46hObuX/IMRF1Oj+cic2l6i1zyWQhvPap52ygpxN/DQ94vcpILraoG OuMFi9QRikhL+nedABwVmWkmrr2bLhMUotfc/iQy0hOidXddJ2NHf3Fq0mACF/LFlzenBO OgGRPtDpt0VLExE2BR3kQN9XKLYR4F0Qf4ikXNDQIbyMxJ9VNiz1oPxo4xEL/ngap8Rypq h357MFDvTrNVgLgmuP8BnHIklZhVUJlZ/qh++6MW5IS7sXXk6GC2xorama9HrLQDEOiyDi 1O+oZnJZzc/NxpF2Xt5NMeeMSjc7srJvzBfZ4zqdnXJqGVHFvi9lGUfziQhcrA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793289376; b=KmySQe3S5r7cnWlaW49msWtdJQZsmctPt75x1yqkU0W/lB9K9mnhhymjswcqaGAPgnQXU9 yqiUoOSUbhIFqiH0znjxeQb2/6cXmhTfmFgk4gUb9znbSeGWt8Wbs9bKkHPnvmGn/Qs2ZO 4qKmnVFAN3JKZFfCGBL+X+QEGVM0Hh14c8X3Y6g1KQ20J4bh8+NiT9zy4vBs8R4wmbYoL9 hkfBeYiHS/Od0EbJo/GI1qij4ijtxICyIX55AGVonvq0asxdHRcCFsguS5zy9+BtDAnk0o x4G5CxgsFYtF7NKNWkKfriABSRLBSA9bWHd2sSOZz39Xnb7nso1J4uwNZh7HTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793289376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3IYulkVARfhrN2qvjFUPzciKGLvBj9KWwSr2SQil5dE=; b=vFCexJwqpbN65hBzZsbTNOCjLdqEymyuBOmcHsG+OMrqp5LjWcLDjt7H2K6wBBoKl+OxI+ OAAt41PPMqHjgdeYZiPZLvyNV6QzdPqr09p3Wy+TpTERstQXbbzNsMjIgw67/9/ZYSJhMm oS0Tp95+WOzLh4jSvnKJRKcekcpJwTc7Xx8ArNbwFscDcviydb80REx5DTvmiBjTQFZjgf JHpuRegRkMNmz1y2tZZOedBYvvceToIstaOo0ayhMlX+NKWcAJ3S99ri5nkR6GfO2rBkUt jweOU7yU4yNrGd1SpMw27Aon1x6YR3LM9qWKe4rw43AoOyu7SfC7L2VrT4SR/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFpk773zvzmtD for ; Thu, 29 Oct 2026 15:56:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30056 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 15:56:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 53cbd14ea7ca - main - rtld: extract donelist heap allocation into donelist_alloc() List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 53cbd14ea7ca78c140ee90c1e459589bb574d938 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 15:56:15 +0000 Message-Id: <6ae36c9f.30056.3c3f43d0@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=53cbd14ea7ca78c140ee90c1e459589bb574d938 commit 53cbd14ea7ca78c140ee90c1e459589bb574d938 Author: Konstantin Belousov AuthorDate: 2026-10-25 17:57:39 +0000 Commit: Konstantin Belousov CommitDate: 2026-10-29 15:55:37 +0000 rtld: extract donelist heap allocation into donelist_alloc() Sponsored by: The FreeBSD Foundation MFC after: 1 week --- libexec/rtld-elf/rtld.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c index 7ca5f9ada09f..0ec2b8d17189 100644 --- a/libexec/rtld-elf/rtld.c +++ b/libexec/rtld-elf/rtld.c @@ -1040,21 +1040,26 @@ _rtld(Elf_Addr *sp, func_ptr_type *exit_proc, Obj_Entry **objp) #define DLP_ALLOCA_LIMIT 100 /* 800 bytes on LP64 */ #define donelist_init(_DLP, _REQ) do { \ DoneList *_dlp = _DLP; \ - SymLook *_r = _REQ; \ _dlp->num_alloc = obj_count; \ _dlp->req = NULL; \ if (_dlp->num_alloc > DLP_ALLOCA_LIMIT) { \ - _dlp->objs = xcalloc(_dlp->num_alloc, sizeof(_dlp->objs[0])); \ - if (_r != NULL && _r->donelist_mem == NULL) { \ - _r->donelist_mem = _dlp->objs; \ - _dlp->req = _r; \ - } \ + donelist_alloc(_dlp, _REQ); \ } else { \ _dlp->objs = alloca(_dlp->num_alloc * sizeof(_dlp->objs[0])); \ } \ _dlp->num_used = 0; \ } while (0) +static void +donelist_alloc(DoneList *dlp, SymLook *req) +{ + dlp->objs = xcalloc(dlp->num_alloc, sizeof(dlp->objs[0])); + if (req != NULL && req->donelist_mem == NULL) { + req->donelist_mem = dlp->objs; + dlp->req = req; + } +} + static void donelist_free(DoneList *dlp) {