From nobody Thu Oct 29 14:07:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFmKF22Ptz6x4J8 for ; Thu, 29 Oct 2026 14:08:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFmKF0nsLz4VLc for ; Thu, 29 Oct 2026 14:08:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793282881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cayAcPOflrm2oXKJ5US2WiT1JoqT3FAuWLaIn1azsPY=; b=MPT7bTim+68ztjUlvaxKmpT1A4p//wt1ALLEv3NuI1AsLzM4XS3h5iKj46ZcNdwFVPXWY2 DIxZglfyofK2n7IRwTDBIV6YBDB4rtfVWktYNb7G1disp/3Gewmk9WlXw5cOXJWmPNEHdd iK9YuQjkABI7X9lkbmFebH+Rss1bmcWGHKOY2PFnYGlYQJtF2w4mOdLODk3eUHOTUbNtE+ 0oXi+4aMMEUIZf8C1c5c9MfZ/kg2jypNYknjuYK/z5bEc3q/b1cwa2y9CDyYCNGbhIb3U/ ReMZlf1FALoWBi71B+dpOPD7oAc4W1joPibxOl1oItsG2hRnc8J23JlRZsD0wg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793282881; b=idIX7qXFsfBiSmhWkU8YFq6qId7xKMy13Oa/EfqA/Ttfj3tpjFVyNXdA5PAM0X9Ena6rjL WeaRCi2xOR9H83rQ5mhDRngpDSQhrhIKc0ixD8HSVuhJg/RpbGqBNzznoOt0za4mlacbqy lYID7L0et7mKdaEkKergmVI/+jCZTPsMHguAtZX4csqJPSS1s1z/4mYt5VQVVA4PqRihj/ 6yeWvlkDyqh5pS8D25XrLWnyhZm4GyDQE6xTIwDZW9QheXbM2qNI+g22RxocgsIJKzFvgK BMLaY6lxvSOHJ9DMknAoJQuxoo+OS3tsu/+HFdfvdAgJaH+n4f2Z9O9Wj4Kn0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793282881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cayAcPOflrm2oXKJ5US2WiT1JoqT3FAuWLaIn1azsPY=; b=JEfyPGcdjkHZFZLA8F9/CeXN2990rx89rJOlCVJOnu7p3d7Vl6OlSCI5A49dYkutJogYOK klQAvZ+Tfbqy4Gohug12fEdIJWHcQqOhPVEXzHIDjjPG1EUafBiHZjYMl9WvZZZ9jVTJPG VBEBCLQPU5/et5jmNfxLpAxCZ5I0p+S+7FrSs/en9qVkFYLKz/E3pMD/s2PptWRjznzDbF zBMSHsUI9D+/8gmQp0XmR1HNMKpg8jgQCPHkgjdj8gf4dEEhiZqrJgWD0C9mH9qkULu9jd qJrL4sRqbmXmcfIMW5UQNtdaAKJakgFmv1I0LWJi4B1dkZlviKLiRE4s3rm/zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFmKD6wqkzk5P for ; Thu, 29 Oct 2026 14:08:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f18c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 14:07:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 714433a6772b - main - bind_all_fibs: Disable bind_all_fibs by default List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 714433a6772b346723341735ef9547f672d9d2a3 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 14:07:55 +0000 Message-Id: <6ae3533b.1f18c.633be3af@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=714433a6772b346723341735ef9547f672d9d2a3 commit 714433a6772b346723341735ef9547f672d9d2a3 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-10-24 18:01:06 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-10-29 14:07:17 +0000 bind_all_fibs: Disable bind_all_fibs by default net.inet.{tcp,udp,raw}.bind_all_fibs was set to 1 for backward compatibility. Set to 0 by default to drop them all unless an inpcb bound to the same FIB exists. While here, Add an UPDATING entry for behaviour change. Relnotes: yes Reviewed by: markj Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/73 --- UPDATING | 10 ++++++++++ sys/netinet/raw_ip.c | 2 +- sys/netinet/tcp_input.c | 2 +- sys/netinet/udp_usrreq.c | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/UPDATING b/UPDATING index 44b77a813e48..abcbbfbf5ee5 100644 --- a/UPDATING +++ b/UPDATING @@ -27,6 +27,16 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 16.x IS SLOW: world, or to merely disable the most expensive debugging functionality at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20261029: + The net.inet.{tcp,udp,raw}.bind_all_fibs sysctls now default to 0. + This allows applications to bind to the same port in different + FIBs. As a result, a socket bound to a specific address only + receives traffic from the FIB it was created in (see setfib(1)). + Sockets bound to the wildcard address are not affected. If you + use multiple FIBs and rely on such a service accepting traffic + from all of them, set these sysctls to 1 to restore the previous + behavior. + 20260919: less(1) has been updated to version 710, which removes the obsolete lesskey(1) utility. It is no longer built or installed, and the diff --git a/sys/netinet/raw_ip.c b/sys/netinet/raw_ip.c index 1360dedbb2ef..e2fea834ee79 100644 --- a/sys/netinet/raw_ip.c +++ b/sys/netinet/raw_ip.c @@ -128,7 +128,7 @@ void (*ip_rsvp_force_done)(struct socket *); #endif /* INET */ #define V_rip_bind_all_fibs VNET(rip_bind_all_fibs) -VNET_DEFINE(int, rip_bind_all_fibs) = 1; +VNET_DEFINE(int, rip_bind_all_fibs) = 0; SYSCTL_INT(_net_inet_raw, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN, &VNET_NAME(rip_bind_all_fibs), 0, "Bound sockets receive traffic from all FIBs"); diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 5ebcad5eae43..e7554b6c6e07 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -131,7 +131,7 @@ SYSCTL_INT(_net_inet_tcp, OID_AUTO, log_in_vain, CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(tcp_log_in_vain), 0, "Log all incoming TCP segments to closed ports"); -VNET_DEFINE(int, tcp_bind_all_fibs) = 1; +VNET_DEFINE(int, tcp_bind_all_fibs) = 0; SYSCTL_INT(_net_inet_tcp, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN, &VNET_NAME(tcp_bind_all_fibs), 0, "Bound sockets receive traffic from all FIBs"); diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c index 79d292983c24..2eac13d167d8 100644 --- a/sys/netinet/udp_usrreq.c +++ b/sys/netinet/udp_usrreq.c @@ -103,7 +103,7 @@ * Per RFC 3828, July, 2004. */ -VNET_DEFINE(int, udp_bind_all_fibs) = 1; +VNET_DEFINE(int, udp_bind_all_fibs) = 0; SYSCTL_INT(_net_inet_udp, OID_AUTO, bind_all_fibs, CTLFLAG_VNET | CTLFLAG_RDTUN, &VNET_NAME(udp_bind_all_fibs), 0, "Bound sockets receive traffic from all FIBs");