From nobody Thu Oct 29 06:49:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZZt57clz6xvZr for ; Thu, 29 Oct 2026 06:49:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZZs6hZHz4BGy for ; Thu, 29 Oct 2026 06:49:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vGdUF2VEBRLzqSNaZKOBmunxWzDs7C9jJB5KQVY3/bE=; b=IEa5yQ06hWASDjS4JPg95TtqK1BYwy59Cypaa58fpJdpVJi0UY+vIoOGPpm/hD4PY7VsSw G84dq3cjyf4GE9rtCv7fORQvjWhTU1B/1YkfKOIzptFRoLKUH+U4nzvrCkZbN+PYscScCf cXwMOvXVJjoDJeP0kyfGWQhqDU2RWYtp8dVC+qNcslAPA4jvmo7RzLlgMwEt0cOzxEahVJ F9vBYm6a4HBlma92llR2iWstP8IZUAdsiSD//UiqOAli1aWkWiwSHWKobZSV/5iEbMUMCq ZwfeV248nenV/opxC1znvOU3X91CFNuxDEmGXfnujJUvm1F3I5ZnjtKLHtWp/Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793256550; b=QlE1/M2ySXgN0Gj5R+A76wWPJSW5u6KCBnVMxKGujmP6xRv3h6vh2TJ4avFr4kgDwKcn2B y3biKNl7xvRgjXNmUoOrJduay3CGuDrdhVd4EP5aU12LpfJtkS7fhPlGRvT+6335iewGwQ /5cNnx6czUP9ad2sxLn3es0MecOKjzjImTzCrC9lFr532p8YczHLM950oxMpEOxKU8iong M10c7Yduw3X9ZuwG8C8rBz7+Ie3wHdZfcIiPOsiLP9RXqxtqskP5jrGm/gk2lvDAeh93gL +5ncShJfvsaT41G15O6TE7q6IsZsY7SgwkXzGb5xx7KRAZYPuhyruIYHHPTDSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vGdUF2VEBRLzqSNaZKOBmunxWzDs7C9jJB5KQVY3/bE=; b=Q9rB3IsT/vZl73Eb0TpB2KrLCzYyEm2BZXO3z5xPUxVEzbKZvZNdzokQPAz3p/WJFtc6YS ddEKw8a5xaUmMZ6ziejoN8KZPbSHJGk/We8nbgQJNwP3ZhJ4Bz4O+7257ikVljyiUnutSD xqgW6+E0/PWU3R97dKdsWXzcKsU7EdH9L+IVgRxXLlCiiOX2iWj1JCuY/DNBRs0mUFoYfl 014NHKMsWx5yXEfOKn7Mut4F7oTsd4eaRNpJhdO9UREXEbDS59Vx0NT8lEzmRPjLsnT4Q+ AOXIh7Z7UMq6wj9JlsSX9SDbD8tukW/Ch+y4Gw9djXDdjklLNlsRN5UhlN9dmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZZs62ZfzSFp for ; Thu, 29 Oct 2026 06:49:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e37b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:49:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: e2ecf41b4a61 - stable/15 - vnic nicvf: Program the common RSS key in network word order List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e2ecf41b4a6182176c53097aa3e6bcceb8e82578 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:49:09 +0000 Message-Id: <6ae2ec65.3e37b.3e1f0d6b@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=e2ecf41b4a6182176c53097aa3e6bcceb8e82578 commit e2ecf41b4a6182176c53097aa3e6bcceb8e82578 Author: Kevin Bowling AuthorDate: 2026-09-18 08:56:00 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:48:15 +0000 vnic nicvf: Program the common RSS key in network word order Replace the repeated hardware-reset key with rss_getkey(). Decode each eight-byte chunk with be64dec() into the register-word array before programming the five key registers. This matches the key serialization in DPDK's nicvf_rss_set_key(), added by commit 7694fab264ac666d62a4cae04f2979991ce64259 ("net/thunderx/base: add RSS and RETA configuration"). A raw copy into the word array on little-endian hosts would reverse bytes within each register relative to that convention. Preserve the CPI-algorithm gate, enabled hash fields, and round-robin indirection table. Reviewed by: gallatin Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59806 (cherry picked from commit 8c25b70120e8838135cb356c94d350105f45ff7c) --- sys/dev/vnic/nicvf_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/vnic/nicvf_main.c b/sys/dev/vnic/nicvf_main.c index 59f7abeacdd5..b6858a73b978 100644 --- a/sys/dev/vnic/nicvf_main.c +++ b/sys/dev/vnic/nicvf_main.c @@ -60,6 +60,7 @@ #include #include #include +#include #include #include @@ -1055,6 +1056,7 @@ static int nicvf_rss_init(struct nicvf *nic) { struct nicvf_rss_info *rss; + uint8_t rss_key[RSS_KEYSIZE]; int idx; nicvf_get_rss_size(nic); @@ -1068,12 +1070,12 @@ nicvf_rss_init(struct nicvf *nic) rss->enable = TRUE; - /* Using the HW reset value for now */ - rss->key[0] = 0xFEED0BADFEED0BADUL; - rss->key[1] = 0xFEED0BADFEED0BADUL; - rss->key[2] = 0xFEED0BADFEED0BADUL; - rss->key[3] = 0xFEED0BADFEED0BADUL; - rss->key[4] = 0xFEED0BADFEED0BADUL; + _Static_assert(sizeof(rss->key) == RSS_KEYSIZE, + "RSS key size mismatch"); + rss_getkey(rss_key); + /* Each key register holds eight bytes in network order. */ + for (idx = 0; idx < RSS_HASH_KEY_SIZE; idx++) + rss->key[idx] = be64dec(rss_key + idx * sizeof(uint64_t)); nicvf_set_rss_key(nic);