From nobody Thu Oct 29 06:49:03 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZZl4y4tz6xvZM for ; Thu, 29 Oct 2026 06:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZZl2Smmz3R8X for ; Thu, 29 Oct 2026 06:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J49CyFA+/fMcsHhrIjMVV2Dp5i4MFo+feLb4FuDvu+M=; b=wP8zz5jBgzcdgYL8V16AgFyLhbwkkMpL8CrZiE0tvlGll8SvdEw8vAaEGBrjucyFnGJ8IR cM6PHYORX6c0AYpBZ3KhvNM8X6bQ9xmb5doD72e/vR5rylaBacH26mQLpoJmUX3AULrbHs 8DmhjqStLpJpMYfIluNX/XhDfwl/y2ROSqTFhVYT5BkbVD/iiv8u7cKwTOXFvsxNV0xXD0 GjdwAWxxitsn0LLAnPq+gt7EKsNisiLx9EVsmY2GCPc5PSiSt0Ly6BXHmQR1Z4cA+2EWUx LTIHKitbHumt3lOUA5HbxkqAEA2PqNfnUT3GHc6EcaahlG5C81hgIaX460h90A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793256543; b=LhRjKmLnAxEQQrSIL9Z1GmNvaP7x4OxIJXfHfX8XQJxO8ozJjrfq+4UwoMOoBy9odH5wwC IdYU7qTK0APhGPs0RUW0VJGPnij1PmMholw1YoYQuWOvS89SHjc2asvlD1CReAfk6P/Tqt 1R9itcdtUentUgrnwVkOtOXGhesXK/eFCBTLKyjLKbSRHVlw727CwWOcRalri1WeVkBxhR am+tqQkj5Dd/VlrzlYwKYuxigPDdoca6OTuAPJ3V97dyTnfwJ1MIod3dCtBPnffbdWFT1T 1OIfAIYfLpl8z3LCuadkdFNqLzJTaVLCMfZt+JsmEnXiz5HyJc+wQi3RNMYSJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J49CyFA+/fMcsHhrIjMVV2Dp5i4MFo+feLb4FuDvu+M=; b=KVrPzOLEWBuQCbTTBHoqYqGMvwRTR/MvTW3jtJSSIwC//LeGhRecobu2wzMY5dttnRfhmE zTMHM4bdYSvJgB+1qt5kVp0QdrI6i5kAI5pyPa0nVt7JdlCcYfEfsTu3KpC9qWdxLkYVmy 80nOd69PHeVoVWihxcs6thA6Tf3+7nH11Wa194O/JwSf8eV7oDGZ5jY8y79U3eE8GQS83C LI6N3AbwvI7eYa3/w2DKx8/BvC47sxLNDjjzdOB55dUIFDowk4TY4cdGRXujQ9UyRBZ0mC WWgVodAJV32hyKYogIijy7z3PgTekcq8ar9tNGA77RQw/E7STCEKMl0fO87UkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZZl26hGzSFm for ; Thu, 29 Oct 2026 06:49:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d8ca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:49:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 60ec0fa0db4d - stable/15 - qlnx: Derive the hardware RSS key from the common key List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 60ec0fa0db4d3e009a0992b916acda504a5eef04 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:49:03 +0000 Message-Id: <6ae2ec5f.3d8ca.7d6db0c1@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=60ec0fa0db4d3e009a0992b916acda504a5eef04 commit 60ec0fa0db4d3e009a0992b916acda504a5eef04 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:20 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:47:18 +0000 qlnx: Derive the hardware RSS key from the common key Replace the embedded default key with rss_getkey(). Decode each group of four key bytes as a big-endian word; the shared code then serializes those host-order words as little-endian firmware fields. This preserves the existing hardware representation for the common default and allows a configured common key to take effect. Keep the existing multi-queue gate, RSS hash selections, and indirection policy unchanged. Reviewed by: gallatin Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59800 (cherry picked from commit ce68b58217ed8a9bf45b1622d3d32ec26e9025d0) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 215837968505..853bd4cb7108 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -32,6 +32,7 @@ #include #include "qlnx_os.h" +#include #include "bcm_osal.h" #include "reg_addr.h" #include "ecore_gtt_reg_addr.h" @@ -6481,21 +6482,10 @@ qlnx_update_rx_prod(struct ecore_hwfn *p_hwfn, struct qlnx_rx_queue *rxq) return; } -static uint32_t qlnx_hash_key[] = { - ((0x6d << 24)|(0x5a << 16)|(0x56 << 8)|0xda), - ((0x25 << 24)|(0x5b << 16)|(0x0e << 8)|0xc2), - ((0x41 << 24)|(0x67 << 16)|(0x25 << 8)|0x3d), - ((0x43 << 24)|(0xa3 << 16)|(0x8f << 8)|0xb0), - ((0xd0 << 24)|(0xca << 16)|(0x2b << 8)|0xcb), - ((0xae << 24)|(0x7b << 16)|(0x30 << 8)|0xb4), - ((0x77 << 24)|(0xcb << 16)|(0x2d << 8)|0xa3), - ((0x80 << 24)|(0x30 << 16)|(0xf2 << 8)|0x0c), - ((0x6a << 24)|(0x42 << 16)|(0xb7 << 8)|0x3b), - ((0xbe << 24)|(0xac << 16)|(0x01 << 8)|0xfa)}; - static int qlnx_start_queues(qlnx_host_t *ha) { + uint8_t rss_key[RSS_KEYSIZE]; int rc, tc, i, vport_id = 0, drop_ttl0_flg = 1, vlan_removal_en = 1, tx_switching = 0, hw_lro_enable = 0; @@ -6637,8 +6627,13 @@ qlnx_start_queues(qlnx_host_t *ha) rss_params->rss_ind_table[i] = fp->rxq->handle; } + _Static_assert(sizeof(rss_params->rss_key) == RSS_KEYSIZE, + "RSS key size mismatch"); + rss_getkey(rss_key); + /* The shared code converts these host-order words to LE. */ for (i = 0; i < ECORE_RSS_KEY_SIZE; i++) - rss_params->rss_key[i] = (__le32)qlnx_hash_key[i]; + rss_params->rss_key[i] = + be32dec(rss_key + i * sizeof(uint32_t)); } else { memset(rss_params, 0, sizeof(*rss_params));