From nobody Thu Oct 29 06:43:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZSB5bn4z6xv3G for ; Thu, 29 Oct 2026 06:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZSB2tVlz3P21 for ; Thu, 29 Oct 2026 06:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZeMnINZ57tuZA2tnbQwF76Jk+nd2YnydHO8oEhX+x8Y=; b=cOjmOew5B6RKiyhOy9AhYPlY3BmP8UZAPoEB6/aPXkETEUCAbNkV4zE2DdRWKMr+nGDPmi lkRAYz4JL1dfJoqyscNMvnUUw+n3A/VgQJX+tMmvA2/D6u8hbxud0UMVelpGHnoZkVqn39 JJOhFXPKE3uH3oszgHwhgokEvJIffMc+BQbu9Leq0eYZD7BazGtlh9xTx90hg2SD4LbPT8 EWEVEzEid5MqATALEAK/KOkSo9WGs+BVA21BomKn5ldAw4+uKBIpgBpLNj7J94TFL1ho7h 6y08HAeWX620pkklxrJJyr4sHmzDo6UoyvKZ4hFlvmmSQl5VXUX7nyy3LjEw5Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793256202; b=bvfXACMWgisGZykcQqj+7kX/RH7fJWoxzKhb5qq1vbytKAQ6aT+t10NmCSO1Ht/QH5TL8B HFmQ3BT9UQLu1Xu7OoG2WvrTWYSrvI06Ip1zKvzn0y/Y9vy3k76+P0BLtYpjTAV2DjP8PD anZiB3tzQ37hSWQl6NrlWmfA602SROINCGJJimRbcMdRKyB2yTm+uj146/tASC0FsQ/riM L/G1urznKscomPwCdmYSVX7Zx8aMcpqZnllR+GuZt/obEaTYvZruW/QhUcQh3tRxOHxFpx FlZJ4BHqK3ZuJivN6tUmiPY4yxt1GNBRQtYSA/UxqztxY808MwX5Ta7DQC3tUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793256202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZeMnINZ57tuZA2tnbQwF76Jk+nd2YnydHO8oEhX+x8Y=; b=xU3ivvfL9iQoODdp1qVCuZBcnWlj/gp1IEuHvFA0KW4pEWp2QxlC7XX4CPL/uNm/KV8/1U LIvwBtyRp04TUGaDwwYgZrPvpJjsXJzaMD7cJRLRIngpjCZJYbUvotDy0BnKrRzKJ00cZ4 yLBBWSvjJ7tq9zWuU0D03NwfxwmAMln2FH2M9Y3KpeOYkrUQjsQfd9KKNeLMHeKNPhIjW6 eYJgXNz0wUh4oDt9ROPUw+r4/RTiHwAHpKPxT1oYpWpRet3FpqUyWCV7+vJqpBC/oYwCXC 6CIGn7paNaXEnBV95EdXXj4re/yXoTlkSpF26WRz6Ss5mESWF7S4zVkFHzCn0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZSB2GQXzS7Y for ; Thu, 29 Oct 2026 06:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f45d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:43:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: de1efca8fca4 - stable/15 - ixgbe: Use the common RSS key without options RSS List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: de1efca8fca4a4a6c526ae734bf8faf6f3578e5c Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:43:22 +0000 Message-Id: <6ae2eb0a.3f45d.69f545eb@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=de1efca8fca4a4a6c526ae734bf8faf6f3578e5c commit de1efca8fca4a4a6c526ae734bf8faf6f3578e5c Author: Kevin Bowling AuthorDate: 2026-09-18 07:43:37 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:42:35 +0000 ixgbe: Use the common RSS key without options RSS Use rss_getkey() for PF and VF RSS programming even when options RSS is not configured. The common key is available independently of RSS queue placement and is also used by software hashing. Generating a private key on each initialization defeats that agreement and changes receive hashes across resets. Leave hash-field selection and indirection-table placement unchanged. 82599 and X540 VFs retain their PF-owned RSS configuration. Reviewed by: gallatin Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59789 (cherry picked from commit 709d7cf3039f648e23260a35c1094b15b4d4593b) --- sys/dev/ixgbe/if_ix.c | 8 +------- sys/dev/ixgbe/if_ixv.c | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 984248ee4241..518d4da52cb9 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -676,13 +676,7 @@ ixgbe_initialize_rss_mapping(struct ixgbe_softc *sc) u32 pfmrqc; #endif - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Set multiplier for RETA setup and table size based on MAC */ index_mult = 0x1; diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index b2c192caaae1..378a0c18cbf6 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -1788,13 +1788,7 @@ ixv_initialize_rss_mapping(struct ixgbe_softc *sc) int i, j; u32 rss_hash_config; - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Now fill out hash function seeds */ for (i = 0; i < 10; i++)