From nobody Thu Oct 29 06:37:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFZKL4PPPz6xtms for ; Thu, 29 Oct 2026 06:37:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFZKL0p6qz3D7j for ; Thu, 29 Oct 2026 06:37:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0PkeRJYu+S1eqvN0HL4oEsJ94fTFQ0bWKBKkgt9fiMc=; b=s3ANli7LWea2+fzmuG8c80+1xJamlZJYMU1W91JJO7dHjBGKA/2ViY+U10/crfCvzW9TD8 1oauKGVpJ79lB0W0sXw8dRo/PoUmRsm/MJGqbVPdcUQ+DcjMl8qQFMibw041yblR32cvVQ GmADuyWkBpAfAAHWZF6cLv5AlDywQq5i4sns0AJR/BoUER5VTOQiGML0F/xSDEY9cYUwT8 y6pHkVn/XJemCE4nJUjzHqctYkmQaPaBKeTCuJxuh5AxZ+ubev0YU0YvpsJ25YIDCkEn/u cH+lbi94+RvnBUHkuWquDeU9+GkaccwB0u+tu+xwOFc+Hx4SorufLbM+J0ITAw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793255846; b=S7ijU7PlfQs6FCmDWF+nP3D+kjsXTOHxaZt9rPCvwsMhMMTHiZslrn35wn2bMJrc5YZRxV yUrpqHjJewt/OA2/8OK0W3MtMKBoL6l8UdstSdmSIsHlrCYCOZ+x1uZsa56CMSRzJgrtkc YSsiYQNGcjvv78Xl7XW29kPhyu8GupKs75gIB1SXGRBzu84xt4bOw8onfC2VyyZyh48932 7q6scxvDbMtmZfJdvUcVxlJW9l4Rt55y4fyBT5MWncdMcQoSb8z8TeyG8BivwJH+TNiGsk m+zsveQ/1HCJtbfHHU/8trZPkzq5RlYcEnPp/TZcFGUkC2b6e6I8PP5g6atI1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793255846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0PkeRJYu+S1eqvN0HL4oEsJ94fTFQ0bWKBKkgt9fiMc=; b=eHF22B1HRcZ/Q6nj7EcDs7+qE3Nb5W/lRTIN94YbQwglSboWu52ZckqONc3qWWH/lYQJHA /XILUeGIPz6GJcQZipUfZWdtr7e0TQR8Ozloe9Lhjd1TkTtBnVbEx4SWPuJFf7lrbA7fMg RKRZ5gf7DYwwGd12ElUCZnGyd6xtqZ/jEAV5AgOU7tjYUsy6XF77Yuc2YadjdJQsJFFEwc wbTdOgxZEZ0U6v5IOMMlNtrvdkIhZaBBx2tJ9sNFZpxrDrgmkjRp30LOWsCZQU8E8O+jvq LvMWPNXouLjkKTTvFeSk7aJ3xIFslS6jO3XxVxyMSc3al0NH5sej1lupVflkSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFZKL0M61zRkn for ; Thu, 29 Oct 2026 06:37:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b5ee by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 06:37:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 12b44201e47f - stable/15 - ixgbe: Defer flow control programming while admission is closed List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 12b44201e47f1f5d02840d07ada3eec5d631612b Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 06:37:20 +0000 Message-Id: <6ae2e9a0.3b5ee.349aa3a@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=12b44201e47f1f5d02840d07ada3eec5d631612b commit 12b44201e47f1f5d02840d07ada3eec5d631612b Author: Kevin Bowling AuthorDate: 2026-09-11 21:42:24 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 06:37:12 +0000 ixgbe: Defer flow control programming while admission is closed Cache a validated flow control setting without touching hardware when iflib has closed admission. The queues may still be live pending a watchdog stop, or the device may already be stopped or suspended. RX initialization and link setup replay the cached flow control policy. For live updates, decide once under the context lock whether to touch hardware, then mask MDD around SRRCTL writes regardless of a concurrent watchdog closing admission. The context lock excludes actual stop and reinitialization while these writes are in progress. Sponsored by: BBOX.io (cherry picked from commit 5abfd8fe4d1adb74863231f27a9958cf176e3ded) --- sys/dev/ixgbe/if_ix.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 1b1c719a30e5..57c9a3e35300 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -5665,10 +5665,16 @@ ixgbe_set_flowcntl(struct ixgbe_softc *sc, int fc) return (EINVAL); } + sc->hw.fc.requested_mode = fc; + /* Don't autoneg if forcing a value. */ + sc->hw.fc.disable_fc_autoneg = true; + /* Init replays the policy; closed admission does not prove DMA stopped. */ + if (!iflib_is_running(sc->ctx)) + return (0); + /* Updating SRRCTL on a live queue is itself an MDD violation. */ mdd_active = sc->num_rx_queues > 1 && - (sc->feat_en & IXGBE_FEATURE_SRIOV) != 0 && - iflib_is_running(sc->ctx); + (sc->feat_en & IXGBE_FEATURE_SRIOV) != 0; if (mdd_active) ixgbe_disable_mdd(&sc->hw); if (sc->num_rx_queues > 1) { @@ -5687,10 +5693,6 @@ ixgbe_set_flowcntl(struct ixgbe_softc *sc, int fc) } } - sc->hw.fc.requested_mode = fc; - - /* Don't autoneg if forcing a value */ - sc->hw.fc.disable_fc_autoneg = true; ixgbe_fc_enable(&sc->hw); return (0);