From nobody Thu Oct 29 05:00:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFX9h4kZZz6xmR9 for ; Thu, 29 Oct 2026 05:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFX9h3j9mz4dvv for ; Thu, 29 Oct 2026 05:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793250040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YTFUuVAEw7t57af70BsaMvJr9OV6crSWq4nt6YBkw/Q=; b=E3W0mbGFV55bGPkJBRRbH1MK88Atom1VGtD3J9lxKclEVZmP/RWtvj2upec/qRc5nncUQ3 tct+Z4qpcT9NvRKxaPNDui+CYeRn43oWd2kzBnsn61SeCKjwRnKInVPpjSCiaWXGHB1eJ4 oY45aCKKwNFhy+XKeyvnO/uMyNUKR4d52pGvjvFb7GiumehsERkEtDHFrRg0r3TntiNCYp T8kc/kAV8hGXi888KOTX1KPDGEmLUOOpqEj3JctSLFRdMu3yZu97kubdmomWotptNe+VlV hX8NGZZCbESFvgLIYpfZDy9ZOmPflizOPLKFS6t7NzIofsKIAAmw0HgMBzq8PA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793250040; b=LDJCAuW2kWf+72LxA+iKRZSaN0pBC81NDFvH2VeIdb3HBK1dFplfUpL8GNw59Zck4I+a+S HC/uRu3OAJ3rVhfiv3bdD+BVFL7wjP8rYexdFiGp9c1+TuVFcI30XnM+MtF46g/2EwbXLE 7ds6mUQR2dsRYyO5il7ohgIrLoKdXMTYYjBLRq1EEN8kCK2KOUYzLTe4XzsBC3IMT666Y9 vKg6rw3dK8btjhcGGlHT4DaCzL2wfTjRK92dqpN+Yrx1dc5Dxrg9Eg/rQq5ZlZQZBDdV2I nwGvEeKv7dueqSsTwwARuDf+lKBrg7TMYWopBGMUwel4gJWCj7mNYKG2mxDeXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793250040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YTFUuVAEw7t57af70BsaMvJr9OV6crSWq4nt6YBkw/Q=; b=EiVTzxMsW8DSw8kGf6V61Sj9scKBT7e2ejOjpHCDbSQrD/H2zKYc1nuAQ7y8X75oJSIOuz LGYOBE+Rdt4+6x7XKEuSGaq+lnzlJYwTdNH/cYCv0kNf7qQCXCqQLgsD/5RXWlsMRA3qdg 1Dvn+laehwWbqOOF5ecwS5XVpTV1gStGU1qceYfyyaw00Ay/fOeIO9dO9khQ0IYY1+dMVj 7OP67xICn8rvBLvad5FHkCYojYE823rNLs5PeQKMp1e2LDzNSG7BGaaM/tSz+X3ZOk45sX S+rzvAMTpZ9TI86Om/1KK1E67tMFsnztLpgElPcjQ+BEZx5Nx1C84DjDXYZcVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFX9h3MnLzPSr for ; Thu, 29 Oct 2026 05:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33b8f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 05:00:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: b399c6271059 - stable/15 - ixgbe: Leave run-state publication to iflib during FDIR recovery List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b399c62710594db42aaaa21a814d695283b82766 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 05:00:40 +0000 Message-Id: <6ae2d2f8.33b8f.3c68a3b2@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=b399c62710594db42aaaa21a814d695283b82766 commit b399c62710594db42aaaa21a814d695283b82766 Author: Kevin Bowling AuthorDate: 2026-09-11 18:56:17 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 05:00:32 +0000 ixgbe: Leave run-state publication to iflib during FDIR recovery Rebuilding the Flow Director tables does not initialize the interface or restore its queues. Do not set IFF_DRV_RUNNING from that operation: iflib owns the flag, and may have cleared it while a watchdog reset is pending. Restoring it here could admit traffic before the deferred stop and initialization have run. Keep the table rebuild and Flow Director interrupt re-enable unchanged. This path is conditional on IXGBE_FDIR. Sponsored by: BBOX.io (cherry picked from commit 3a4e037989f91672974eeedf1fa81ce0b684beb7) --- sys/dev/ixgbe/if_fdir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/ixgbe/if_fdir.c b/sys/dev/ixgbe/if_fdir.c index 37f45cb3808f..dcd930518d01 100644 --- a/sys/dev/ixgbe/if_fdir.c +++ b/sys/dev/ixgbe/if_fdir.c @@ -53,7 +53,6 @@ ixgbe_reinit_fdir(void *context) { if_ctx_t ctx = context; struct ixgbe_softc *sc = iflib_get_softc(ctx); - if_t ifp = iflib_get_ifp(ctx); if (!(sc->feat_en & IXGBE_FEATURE_FDIR)) return; @@ -63,8 +62,6 @@ ixgbe_reinit_fdir(void *context) sc->fdir_reinit = 0; /* re-enable flow director interrupts */ IXGBE_WRITE_REG(&sc->hw, IXGBE_EIMS, IXGBE_EIMS_FLOW_DIR); - /* Restart the interface */ - if_setdrvflagbits(ifp, IFF_DRV_RUNNING, 0); } /* ixgbe_reinit_fdir */ /************************************************************************