From nobody Thu Oct 29 04:59:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFX8q1lbYz6xmPJ for ; Thu, 29 Oct 2026 04:59:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFX8q11FMz4dC0 for ; Thu, 29 Oct 2026 04:59:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793249995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d2bjrFmYQPEwzA7EID4ZPD+xZX/QcpSBsck2s4u/10A=; b=QYbdR1MJNkfMnAPiHcWMuck5XAwDVDfE+17mGgNvIiANuG2SMLdNjAH+pIoUv8L4bwBidc B2tFvpFKD9d1suhhLFNZZT2RGHfKFlPUCt4fOIJGrU8tjJ/R9w5EJxMEzOeOwmuqNUHTww zhqNVeGibZlkCB/BtK2VVmSn85eGe1SZhFiPeFXASJLqHGjncHZzdPZAiBorGCkQ2xofvk kZSOPYb7KjZhlMlS3g7rBFbiJRiO/QqaJm5bKagRna+dS2gK2sO9/keQ92ZxD4NCs80p+4 3657myzdpzE6dYrxZk7veWDLDrr8orNhD0s3rK/fkGZVXEfaP8QLrIXQWRbZzA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793249995; b=v1IEmeLRVmIJh8stkgOJYXsAK3rZChhWH9RmmcxmXipLIz7lrM/itpYz2Zj8cuedhiW+pI RXzSBLBVcZSmnqtCU9T9DQWGl8g41df+hk3Xdh+n024CCj5CF1heYOz98l0N5jx+YjR5Ob ei/5dj7frM4Tljo5xnW0Me4GZ471iCwt78hUdezgNDhXn/W9Q5OT7NynhVT2laezrDfX1V 8Ty1e28yJPJy9TQ++2aqSu/8AnShtbcRpyAkluBUg+f4xTvpfp8xAW9pKf2D9addJKMr2j ZA5ryG+PP67JVoX1MHBhEs/Pac2VB/VzOib25p3WA+EmBRdIoP2N1JeqoNjUvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793249995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d2bjrFmYQPEwzA7EID4ZPD+xZX/QcpSBsck2s4u/10A=; b=oIf6UISzMcttW1Ofi4X6PS3g7NBS13aA+waV4BrxSd+bZ5Uoh0Cpe4mL+mf+uTHTvXqiFh OugGMwg/13L+kfJsMof2myHkV8Apozz9ARKuQ5qBEMLzKdF2OKyNMzJQggCP0ECPEHIfl1 g2yawHagluZcI209/Tdn97iGb3HSKoOxJ9J0TTj3IIxoMdSGR+mGUxhZZEoJRqNwgQr1bF mht2W7fVPKxaQefpftjbwtdEPLejJiGd+22Syd/Jhv2fRepYhaCcNGfmdGcPENOAivmilV s0k+7oRi9da6smLiDD0igaFkt7UpEf/xrYLZboQTfJ5wqZLGNthn8ZEirAxi+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFX8q0gyPzP9L for ; Thu, 29 Oct 2026 04:59:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32a8b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 04:59:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 107f080085ab - stable/15 - ixl: Set critical-error state bits independently List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 107f080085ab51af6873585b65ce2b058593af33 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 04:59:55 +0000 Message-Id: <6ae2d2cb.32a8b.68d55665@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=107f080085ab51af6873585b65ce2b058593af33 commit 107f080085ab51af6873585b65ce2b058593af33 Author: Kevin Bowling AuthorDate: 2026-09-07 13:36:06 +0000 Commit: Kevin Bowling CommitDate: 2026-10-29 04:59:45 +0000 ixl: Set critical-error state bits independently ixl_set_state() takes a bit index, not a bit mask. ORing the reset request and critical error indices produced the global reset index, so a critical interrupt could mask its cause without scheduling the intended PF reset. Set both state bits explicitly. Sponsored by: BBOX.io (cherry picked from commit 372803d65d242b308abd6b312a40ff6987fc3452) --- sys/dev/ixl/ixl_pf_iflib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iflib.c b/sys/dev/ixl/ixl_pf_iflib.c index 5660cadf22ab..2791ad769f67 100644 --- a/sys/dev/ixl/ixl_pf_iflib.c +++ b/sys/dev/ixl/ixl_pf_iflib.c @@ -201,8 +201,8 @@ ixl_msix_adminq(void *arg) /* Checks against the conditions above */ if (reg & IXL_ICR0_CRIT_ERR_MASK) { mask &= ~IXL_ICR0_CRIT_ERR_MASK; - ixl_set_state(&pf->state, - IXL_STATE_PF_RESET_REQ | IXL_STATE_PF_CRIT_ERR); + ixl_set_state(&pf->state, IXL_STATE_PF_RESET_REQ); + ixl_set_state(&pf->state, IXL_STATE_PF_CRIT_ERR); do_task = TRUE; }