From nobody Thu Oct 29 03:29:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8h5vGXz6xfpG for ; Thu, 29 Oct 2026 03:29:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFV8h0LSZz4Rn9 for ; Thu, 29 Oct 2026 03:29:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=piTr7YnJjQ1rdEjxXUYAq2AO+sO2U7xtbdwGecAngYQ=; b=tKSTQeu/Fvn0ZAJqUFszHivO3ZHn1j16GWhs6SQlKOV0IwWaHVbx6QvcrBqaTXGHvZ984U gMYg4FSfXBeYrgEEIU5GWaPYf4j0qDE+Kbg0giKutGS8mddLhTjrP2fZppFQ0PoWqCI3Fb MJ1JK4uj1NlUSiLNaJBWe1gH9NnnatNLl2hTLyK8VMpBFUzFLBP1QTkHhMWH00Wchlx5dv 0syQqHoRJkzoEiNndUY2RefWRpQ/Kmj3s6S4EcLMZCPQzrmdOKAXnXFoMDvCDF6rbpkdEo jZho2xTmeS/bLStocgdkHtBW+jMUuqluakosItWvxexgj+V+U08WkQCFwlcaKQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793244580; b=MpW20rpTezLJxeN+iDqbkRV4qfz1u6z+mo9xd1gffj1Qy1zFvVObvB6kVB1j4Cyj6hOisz kSH5J2s+NCt7faVXSCVEs4qlrukey9dbskys5866AsDt1/pHOJcZZpxphrmLnxSBPIAxnV 8xP6oX5ExQJxyiAffREQ/MARX0LMNEYuW3MS4hu+6MNe8zwfHK8Jyq9MtfNl04qkYxcHCa PNrT1Jpgzz8J7o2CuhJZLkrCWGc0Dr3yMPuhZH3yabRknsBCG6MXkP6ENcm1TezC0A+Q/n YCfxoaiI1yPsSVn2CnULRiEdt+YK8LBPT0Jcf7qkd1JqU7YKYinOc1htx4ZISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=piTr7YnJjQ1rdEjxXUYAq2AO+sO2U7xtbdwGecAngYQ=; b=n4Xl+0yPucHkx6JfKErWXom53gkioZjzev5SAHYvJs78/8zI/VeR0qOUXUPWq8C0MnsqIO yV1tvcFIUpMlVc5MUWXsGMvQfRQpT+Edvcs2O0B9YfhOfWT774EP1Lk6sWdYBFMUIMxTAD i5pz0R6VpyxVkXfSyLoVyUCi5kuaLMba3qFIMZKDti9JMQzynZuz6Lcx9s36EyydSbmMS3 dbzpAq+Z4yDAT2YjJxyAVF2P0y83i44d7qVnTCQjQdtRdgMVADho8bdlB0dKKdf+1Z1vWm AIn5a/RP95Pt82kmrZfLbZNu2lx4vvR/AWfYF906iumM33xUhJACa85KBq6mTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8g73kbzLKD for ; Thu, 29 Oct 2026 03:29:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e979 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 03:29:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Gilad Ben Yakov From: Arthur Kiyanovski Subject: git: 32c301922dc1 - main - ena: Limit IO IRQ setup loop to active queues only List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 32c301922dc1e6f52bdd043046661ac1e2b462d8 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 03:29:34 +0000 Message-Id: <6ae2bd9e.1e979.452749fa@gitrepo.freebsd.org> The branch main has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=32c301922dc1e6f52bdd043046661ac1e2b462d8 commit 32c301922dc1e6f52bdd043046661ac1e2b462d8 Author: Gilad Ben Yakov AuthorDate: 2026-04-29 12:10:38 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-10-29 03:25:50 +0000 ena: Limit IO IRQ setup loop to active queues only The loop in ena_request_io_irq() iterated over adapter->msix_vecs, which reflects the maximum number of MSI-X vectors allocated at init time. When the number of IO queues is reduced at runtime via the io_queues_nb sysctl, msix_vecs is not updated, causing the driver to bind interrupts and log CPU affinity for queues that no longer exist. Replace the loop bound with ENA_IO_IRQ_IDX(adapter->num_io_queues) to iterate only over the currently active IO queues. Also replace the loop in ena_free_io_irq() the same. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc. --- sys/dev/ena/ena.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 060d9e26c1cf..b489c58e81e5 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1939,7 +1939,7 @@ ena_request_io_irq(struct ena_adapter *adapter) flags = RF_ACTIVE | RF_SHAREABLE; } - for (i = ENA_IO_IRQ_FIRST_IDX; i < adapter->msix_vecs; i++) { + for (i = ENA_IO_IRQ_FIRST_IDX; i < ENA_IO_IRQ_IDX(adapter->num_io_queues); i++) { irq = &adapter->irq_tbl[i]; if (unlikely(irq->requested)) @@ -2053,7 +2053,7 @@ ena_free_io_irq(struct ena_adapter *adapter) struct ena_irq *irq; int rc; - for (int i = ENA_IO_IRQ_FIRST_IDX; i < adapter->msix_vecs; i++) { + for (int i = ENA_IO_IRQ_FIRST_IDX; i < ENA_IO_IRQ_IDX(adapter->num_io_queues); i++) { irq = &adapter->irq_tbl[i]; if (irq->requested) { ena_log(pdev, DBG, "tear down irq: %d\n", irq->vector);