From nobody Thu Oct 29 03:29:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8j4JL6z6xfr1 for ; Thu, 29 Oct 2026 03:29:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFV8h2cw1z4RTk for ; Thu, 29 Oct 2026 03:29:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3FukAgCI0Pr6DIrC+M5A3RhB8Gdu+H80TU6ddjHrn+M=; b=OtEzxPiuG6UZJ6GU6uPWW3nyAUSl9S2vU1+Hra0HHcQ4l7AmKiZgIHYEfOKia8M2Pde7YW E3cRSw8o5XKU3wuLuR1gRNpqg41Ze/4oAV9cYVfm8Rg1uSykT5EVD1Eo72hUkyep27jIzl Xo2lGNKU73tS28nnvHBKrvxA5X9vX4wgfMip0yrgSIvsu7Bq8E0HsDJFpiHkYFHslVhXa/ f0qn57pFVJdntxic4UDme0TA64KCFmLLIoCRkeXoI6lcoF+EWMNhVZ7TQv3FzRwEJN0WK0 S1urGiPuJ5FnUBhCk5O0k0h/3H3sfJW8J6elG9S1hn8nL0N7Kxy52Z5xb8qGcA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793244580; b=Ig8mwzqjwmEdxI64yPr0mDX3Lgc4qYE1Yr1AfSBGmNcRCfk1+rLd7SN+xpUhlYsosO9diP XxijCs5SFPBIMtiYvVqvM6tFe7+RW2zxxibAmNQEjojRUpEVUZbdDcSThOWcnuEAWBGNZF Cb22MPpeJCnLtXp6zaW0rJ5WIaSKqJoA3nH/sz/3BDokhxZjFLOb04E/hQfE8vF3BFHvRQ snv2BKUQhgSmZBgJ75svl66ufRooeXFn8D3W1ZZutcgkzmnkELHxhd82KDutI2QE/TSb0C /L62/ZXkY2WPCDP7cKW6a0JlYmm2iUIx0hyLQkE5BRyHSSEp1A5Gl4MA2PTfXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3FukAgCI0Pr6DIrC+M5A3RhB8Gdu+H80TU6ddjHrn+M=; b=Wxbg5Ywh5+DnustMZvu5e7apP6I8Jqrckxo81BgNmnZOb5xZ7tLnG/pWj1ijlxepH/GiTw 78HOfrX7dmzHfMNT5lFSHmVv2j4cssVAdSJuu1s9pkqTBjw7XvHGPKx5KO0dHa79egEMLH zO6NcFQ/Nz6tEz40QFpxELb6kdqAEdosf1jPOyHbN/GcIxgjRc8L8b3VK18YEmB7Nl7OWD GlwXe2VZs19ZlTmDU3r+5JOhV7du72QXZHZJVY5+sM/6a0Uri10YQoaanEbYGt9/HnzizS 0v8HGMpSuylPOp4wlGxYwKOl/ao5p5eeuvK/utE/TyhyHzyO+BTLM+gE58SLpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8h1kF7zKvk for ; Thu, 29 Oct 2026 03:29:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1fbfc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 03:29:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Gilad Ben Yakov From: Arthur Kiyanovski Subject: git: 2a27dd0076c5 - main - ena: Reinit RSS components during queue count change flow List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2a27dd0076c55789a43415559906f795fd10c2da Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 03:29:40 +0000 Message-Id: <6ae2bda4.1fbfc.46dd468d@gitrepo.freebsd.org> The branch main has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=2a27dd0076c55789a43415559906f795fd10c2da commit 2a27dd0076c55789a43415559906f795fd10c2da Author: Gilad Ben Yakov AuthorDate: 2026-05-31 08:28:48 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-10-29 03:25:51 +0000 ena: Reinit RSS components during queue count change flow The io_queues_nb sysctl is writable while the interface is down, and setting it destroys the RSS components. When the interface is not UP nothing reinitialises them, so the indirection table is left referencing queues that no longer exist until the next ifconfig up. Call ena_rss_configure() after the queue count changes when the interface is down. When it is up, this happens through ena_up(). This can configure RSS twice if the interface is brought up afterwards, costing three redundant admin commands. That is preferred over changing ena_up(), which the reset path also uses. Reviewed by: cperciva Fixes: 56d41ad5fe9c ("Add sysctl node for ENA IO queues number adjustment") MFC after: 3 days Sponsored by: Amazon, Inc. --- sys/dev/ena/ena.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index 74594fdb1496..63743cbc9db2 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -1437,6 +1437,11 @@ ena_update_io_queue_nb(struct ena_adapter *adapter, uint32_t new_num) ENA_REGS_RESET_OS_TRIGGER); } } + } else { + /* Reconfigure RSS to reflect the new queue count. + * When dev_was_up, this happens through ena_up(). + */ + rc = ena_rss_configure(adapter); } return (rc);