From nobody Thu Oct 29 03:29:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8g6661z6xfhL for ; Thu, 29 Oct 2026 03:29:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFV8g3D9Tz4RLG for ; Thu, 29 Oct 2026 03:29:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nWdneUcCX4fAdmFpNu0unpDFcliZJ+Lhc/Wsggh9C98=; b=wgkNfwGozGaH9Gr8f+Xo0Adc8pF0ucFqL8ZJxhEIpSGIW8xNuRRhz0NOprA0N8Ertz+6n3 AnMit60QwOZsGM4URPxMb8Mfj5BjoFKg7Ja6SlQmQ7jcOP8DANKGe1mtdia/zmi7CNL1c0 cnqEKnp5/Sk9KkSNIgvMG6V9iydI+NTQTYzqTFmqQer+qtQbqVynmAplG0JiaR7KXqLnq8 8zw7vI3HKnNuUO2FcKA4TRpKlIxDsCKJNyFqWqb9kKcXN+gINAeHF9pzJrcbA2iyI/bJWJ ahCWvNwUoiwrTdxGrVtmfLjFERuQ3+nIo1XRCN84bwhF9cYVlq1gaEJQMiATow== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793244579; b=W66AhVfscz+4ldnyZtxZ5G47LwrnK/K1hUGzhJrEDOZRpwiW8h13pTo4Oebrbnbwu01d01 kICL4nOoYpPKI0r0J1SiVu/CxxD/QgNkxezcwbbqe8yw3aZ9c7FYmqcTUJjUFa+npMicT5 cWMX6wmk7O2dU0zLDZUMZXteVPoWQ3DMHo28/Cr3bzFlzv0VWtQ63DiXt4BLq2doNze36g IugeR7kpT/uMfDvmuxLQ1UE4Q3JrBb7WlNMTfqkZ/7zuzkh2txza90x3U0UKf3pCXTcbrN 9lQB28iiohL9I3GE0q918+RJq5ZFkrVI6I0CofkjBP1Kv2Gt9SZQajnUSzwAAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793244579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nWdneUcCX4fAdmFpNu0unpDFcliZJ+Lhc/Wsggh9C98=; b=lYs4D4IQ/FbNLYDxJUtFBAqfBlQA2V7MeiVm2hvdQ93F+LRa2xwgm5GQEojQ0qRnAKWCHJ owJZDUv6Yskh7c5D2BLFK6cOd1h0IJJpDBEb0cyuYYGPjYJFcp8EMCw5PaU59CNIkOJohg 2ufk3n1KSKGfdsp/Kn4/qSAXLwYGsQzFuj7xZW/T49YMDTtX7eDVHnSioBPycHujji/6Un uumlBKZrinlJlYOIOe8W1NifFznFkrIBrKAI00KmW9I2M3MLTl3B2xWTBudjCUNYcJWS8U Y/vjJk9i84lsfkU5TeL6zp6nCuoc0W9q7npA8OHf36BeoX9pwXPpv4dBR41OWA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFV8g17JFzL25 for ; Thu, 29 Oct 2026 03:29:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1fcbb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 03:29:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Evgeny Ostrovsky From: Arthur Kiyanovski Subject: git: 462b6c50c708 - main - ena: Fix NULL deref before NULL check in RSS sysctl List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: akiyano X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 462b6c50c7089e96c54cbd34378467f32fc709d4 Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 03:29:39 +0000 Message-Id: <6ae2bda3.1fcbb.4ec91777@gitrepo.freebsd.org> The branch main has been updated by akiyano: URL: https://cgit.FreeBSD.org/src/commit/?id=462b6c50c7089e96c54cbd34378467f32fc709d4 commit 462b6c50c7089e96c54cbd34378467f32fc709d4 Author: Evgeny Ostrovsky AuthorDate: 2026-05-26 07:01:39 +0000 Commit: Arthur Kiyanovski CommitDate: 2026-10-29 03:25:50 +0000 ena: Fix NULL deref before NULL check in RSS sysctl In ena_sysctl_rss_indir_table(), the code dereferenced indir->sysctl_buf before checking whether indir itself is NULL. Move the NULL check above the dereference so the early-return path fires before any access through indir. Reviewed by: cperciva Fixes: 6d1ef2abd330 ("ena: Implement full RSS reconfiguration") MFC after: 3 days Sponsored by: Amazon, Inc. --- sys/dev/ena/ena_sysctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ena/ena_sysctl.c b/sys/dev/ena/ena_sysctl.c index 62fded932025..74ab16d1b977 100644 --- a/sys/dev/ena/ena_sysctl.c +++ b/sys/dev/ena/ena_sysctl.c @@ -1160,12 +1160,11 @@ ena_sysctl_rss_indir_table(SYSCTL_HANDLER_ARGS) } indir = adapter->rss_indir; - msg = indir->sysctl_buf; - if (unlikely(indir == NULL)) { error = ENOTSUP; goto unlock; } + msg = indir->sysctl_buf; error = sysctl_handle_string(oidp, msg, indir->record_size * indir->table_size, req);