From nobody Thu Oct 29 01:35:01 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jFRcQ3lKNz6xX28 for ; Thu, 29 Oct 2026 01:35:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jFRcP5p2Zz4DXd for ; Thu, 29 Oct 2026 01:35:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793237701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DEQ8dT1MB1l4sRVK8i6RJsJqKzxWPnsuokxXexZ/ykM=; b=KX7s5+qXvqv3ybLLwkYr2qPxpiaK+SP5wyz8qxMaCBVPJJtnUk1iIbc4G6xe/je3gYDwMj GBenZVW7AHjjiKKNkSOlv8UOulq1qeGrsaoVgFvOohlgrweSzwh9kMRyVZJJR42fu/Q2Vo JZhorFWfpHdRVVYGVNU2xzozZzTc9FzMf/eCMYZm5iJhc1dSPXGM4jr6+5HklPyrbMEvFe UlwinG5oEevkyYh7ZNX6j04rLVErTTKhMuYNHRxhxBNwqM6tUaPRxgqGSDGmj3PtfRfORl OHrta5H3uNCOnvW7u+JXidNvZRhWpv0nkSn5ytJAzdCpTOFvwV+GMawEBnZpNg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793237701; b=IohKUpRtr+I6RhOKXXsVNutuLUXmfgFo54k8JDPnWCSxnx3F1Vva/231qJyQzEAkkNvGHi U2dgFzlkrdp9L/yqeVVWXDww8gH6UWqS5kveTWVddFldly9gLOIPVS2CDB16YbLJH5ubC2 peS/K3wIeD2YhllD2VGBAU2qk5DMeH64zVGCEBxcJuuZLznk36tboCNVn6JuftyOsEEqdn HMRLgNjKYOhyp0uIHSCysU7qK5ZHxZZruKkE8pShje58npvOnX2ofLZmJcxPxL70XzNoon CQlUyQBLTViQA0w/iYGqDaZTiBrfLYdrd17Juno8t7R328XBydhWjvSNFRasGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793237701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DEQ8dT1MB1l4sRVK8i6RJsJqKzxWPnsuokxXexZ/ykM=; b=s88wAwgFeYVCP78JFghiFFsQdfFTfLwi1P+J+frbhP5vxstEXCn33l1bj0/uwUUQqZBq33 9OkZPmNOgrnT73oMpy7DfAkW3zAo+nyuG5w3ODMwe1g00u/muB3wgLDKculyth9FXMwVfy 80tmIvSk0UyU38D3nTTGeUxSFVDt6svSrPd30qW00LYxzuIJ0ssvakZZ62XVucCOz+FKcK LQGYZCVIGGCmR7z4etxZA/vpwCtl4h3EYzSFWGHgcjf0q+y2Cs8vwbhAcGhHTr01PT+XbE F8uCMDygkGt0HwUQnd95KqzPeba2aZgTRAeE4NsLjslRIq9KTemS//ZvOEM0tw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jFRcP5RhTzHQB for ; Thu, 29 Oct 2026 01:35:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4382d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 29 Oct 2026 01:35:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 6ca697360b53 - main - amd64 FRED: no need to store fs/gsbase on user_fred_not_syscall path List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6ca697360b53ce4f952d2b178c5d34f75f8c50ec Auto-Submitted: auto-generated Date: Thu, 29 Oct 2026 01:35:01 +0000 Message-Id: <6ae2a2c5.4382d.4659e428@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=6ca697360b53ce4f952d2b178c5d34f75f8c50ec commit 6ca697360b53ce4f952d2b178c5d34f75f8c50ec Author: Konstantin Belousov AuthorDate: 2026-10-29 01:01:05 +0000 Commit: Konstantin Belousov CommitDate: 2026-10-29 01:33:47 +0000 amd64 FRED: no need to store fs/gsbase on user_fred_not_syscall path The stores are only relevant for PCB_FULL_IRET return to userspace, and setting the flag stores the bases into the pcb anyway. Also, the hidden issue is that FRED already did implicit SWAPGS on entry, so stored gsbase was wrong anyway. Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/amd64/amd64/exception.S | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/amd64/amd64/exception.S b/sys/amd64/amd64/exception.S index 1fa797cf5d9e..6ec37032bc05 100644 --- a/sys/amd64/amd64/exception.S +++ b/sys/amd64/amd64/exception.S @@ -1488,12 +1488,6 @@ user_fred_non_syscall: movq %r14,TF_R14(%rsp) movq %r15,TF_R15(%rsp) SAVE_SEGS - movq PCPU(CURTHREAD),%r9 - movq TD_PCB(%r9),%r8 - rdfsbase %rax - movq %rax,PCB_FSBASE(%r8) - rdgsbase %rax - movq %rax,PCB_GSBASE(%r8) movl $TF_HASSEGS,TF_FLAGS(%rsp) KMSAN_ENTER movq %rsp, %rdi