From nobody Wed Oct 28 13:19:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jF7JG44B1z6xSqb for ; Wed, 28 Oct 2026 13:19:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jF7JG1jDNz4LZV for ; Wed, 28 Oct 2026 13:19:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793193598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k0PC+90ykmeFxoMNlKf1uOEnFT46OoKe7GUhOMsK9zI=; b=tgpKLTM81Rfm7pudhgmmAaE+in295xkrFhXcp2bNfc2OPcZvRkDtFA564rbTR+C+Hj3RQY PXM0UHz85s7K24ICxoDCuYXi57IhR+fkWoKDnQIVWVlhmawp/mO5fUrw0dCNhuycWLn3bE UA3+sOfDnnFlSA1IlVxboSWPWVBoIqfKXKL55/AO/KRPjXmic8wPENkLX/kPMYLY00gWRl M4+zoWqUnruSlr5R/uyLjti3TTD1NMjepJwCeHewKKtwE7Wl0rEveJi6DNO7N5fibiciGx Y9TMzQlSAe/ICB8UcClZRO19PpFTxLXUee9mDQfw/rGSVL1GenlJ43ZaW2IWPQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793193598; b=eCCfT6CeQcocnpshm7cJLdibaIE0IIgr7IKGSKEQ4qcB1PJNhIzfsKk9ZCt9L9WrQ9VzPm vD+ONFZYV8jEa/cNBQnvlDJadtOiDtAK9BHWBJzyxA1WIRA6+H7DW9yB3jKLlNEdvvQyWt etsN9I/208O+CiItXcwUOvwQDtiYb9cdRT8hxO+e32tVCb52Q1+1q2kzNi+W/7rFZGIoUl pThCz8Wsa/p5QCEBay4apL9OHDeiOjojh6NfZHKue/ZWZuFOWGv2ctCJ82qMWpQgsPrwLs Jhmcw1JCEeXwJ0X7RpkC0MY9QGOE6BzelrQXAe8kNQnTaYMSUSCY0UvfBsd3pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793193598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k0PC+90ykmeFxoMNlKf1uOEnFT46OoKe7GUhOMsK9zI=; b=mFSWofmd+jwpH1xmmHzIsj535hMf6SSX+DahcZ7Y2lRRiemhjoxd2GyelbemEPjldAchGj SYAHFHULIUmaSd4IY6PRNT4fDZ14xkr+8ECVeq672EBdymQ6I6RrkEO9N9WOhX/qrw2Pku 8GFvbe19dHzvc9zSJ+RUvjyH3XXxnWjWncxwZ6ah5roUM1kzqgkJmmbJIkA7ho9caItVGq Oc530iECxMl8uAMr6ncZ2WnGHfEqfDc/cbwDOoXhd2J/w9o9Sk430v4hQL5tIsBnxLOxPW +G572Ex1CRdYK6Zcb2o5kivk9qTSXjuJmHbm3qPBfSZctps/jrRH882xH2uL7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jF7JG1Mv7z18Ww for ; Wed, 28 Oct 2026 13:19:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c44e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 28 Oct 2026 13:19:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: 25024d96492e - main - sbin/nvmecontrol: fix signedness comparison warning List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 25024d96492e51c250789d16de5064d4c00c7a86 Auto-Submitted: auto-generated Date: Wed, 28 Oct 2026 13:19:53 +0000 Message-Id: <6ae1f679.3c44e.510aae6a@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=25024d96492e51c250789d16de5064d4c00c7a86 commit 25024d96492e51c250789d16de5064d4c00c7a86 Author: Siva Mahadevan AuthorDate: 2026-10-27 20:51:39 +0000 Commit: Siva Mahadevan CommitDate: 2026-10-28 13:18:47 +0000 sbin/nvmecontrol: fix signedness comparison warning sector_size is guaranteed to be non-zero here, so cast to uint32_t to match the comparison. This fixes the [gcc14 build in CI][0]: /workspace/src/sbin/nvmecontrol/format.c: In function 'find_lbaf': /workspace/src/sbin/nvmecontrol/format.c:132:60: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int' [-Werror=sign-compare] 132 | if (NVMEV(NVME_NS_DATA_LBAF_LBADS, format) != lbads || | ^~ [0] https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/5051/ Reviewed by: imp Fixes: b991e2dd824c ("nvmecontrol: support controller-wide sector sizes") MFC after: 3 days Sponsored by: The FreeBSD Foundation --- sbin/nvmecontrol/format.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbin/nvmecontrol/format.c b/sbin/nvmecontrol/format.c index 71e557910654..2efc0144c232 100644 --- a/sbin/nvmecontrol/format.c +++ b/sbin/nvmecontrol/format.c @@ -120,10 +120,10 @@ static int find_lbaf(const struct nvme_namespace_data *nsd, uint32_t sector_size, bool require_unique) { - uint32_t format; - int best, best_rp, i, lbads, matches, rp; + uint32_t format, lbads; + int best, best_rp, i, matches, rp; - lbads = fls(sector_size) - 1; + lbads = (uint32_t)fls(sector_size) - 1; best = -1; best_rp = 4; matches = 0;