Re: git: 4c72b1c36dda - main - ng_pppoe: fix m_pullup() logic
- In reply to: Gleb Smirnoff : "git: 4c72b1c36dda - main - ng_pppoe: fix m_pullup() logic"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 28 Oct 2026 12:08:13 UTC
On 2026-10-19 19:32, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c72b1c36dda72b9ba8de593cac2c94e15f42bcf > > commit 4c72b1c36dda72b9ba8de593cac2c94e15f42bcf > Author: Gleb Smirnoff <glebius@FreeBSD.org> > AuthorDate: 2026-10-19 17:30:43 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2026-10-19 17:30:43 +0000 > > ng_pppoe: fix m_pullup() logic > > The clear intent here is to do m_pullup() if we _don't_ have two bytes. > Before the fix: a) m_pullup() was always called and did nothing; b) if a > node was ever supplied with a fragmented but otherwise correct mbuf, then > it would not handle PROT_LCP as intended. > > Noticed by: zlei > Reviewed by: zlei, eugen_grosbein.net > Differential Revision: https://reviews.freebsd.org/D60788 > Fixes: 28903f396af4b151e16ea606cda66a9244fb179f Hello, this looks like a MFC candidate to me. Do you intend to merge? Thanks, -harry