From nobody Tue Oct 27 16:55:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jDc7T618pz6wx99 for ; Tue, 27 Oct 2026 16:55:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jDc7T5CDbz4gyg for ; Tue, 27 Oct 2026 16:55:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793120133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFUJppZHNzkahAgHLeByuyhqjYyNHdpPpZ5aEXEfVZU=; b=AQVE5frrgYWGDuoLy3SaXTZMR2F+4a8rQRE+PztxWYbqEIxD7ZYSd3YiXSvEWjG5wsaYw4 EjjUYGhAaJgdwXl5IxOMGYKnGxdrYPuJZH2SOL5WIkr9sPgHCrT65u/N8/CBOr9E8CNS1X ucNKI7lB+24OHn/7e04k5k5VCV9fkWm7PnmF6i3Vcs8yug+B5juVITNcklMkVdKmebKanK f93YnRlfFKUuCu65Fkq+vWp6WM1ZlZkGcGgTmYhtMvkieAIjiuy7QXhYd4JjdYk/E5FYeR ACwD57+mgMKKbhr+qPdjItZdSqrqZVWUCnWWszlX8pY7bHI1GMk5uVWFL5nNDA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793120133; b=KB4hUeA+NLYiV5H+0Co9ZrVxcyhf/2tTj5xmgfXdNjhBD2oHD3JlgSp2QLRoImC0mtabxb HbLy5fuYsbDMoDmkqPwmkbv9VyFLX2AuSqLO20jEB6yPp2y1nHiYKqwuqXKAxrpGN0MV8W RzUDr60lTSeMqZUv2R7t+FlaBuFS00XLBscXp0b+Tat2hFqgOHQ04/dlzU14PpNwXEeQlZ MNejkoiP7ewt+TpQ2Rdz0bSYNIFF6pDYFL82mcOKcRoivgC7+sJny7rnKZbEN2iYdFaBGe Cx1drpNk4rjESb+spaaVWJW91WPAaeZURm78fGZz3orJl+j/CfcpmR6GFqX/UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793120133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFUJppZHNzkahAgHLeByuyhqjYyNHdpPpZ5aEXEfVZU=; b=iCz1cPBBRVYwRvK6fN1bxc/jsguhHK/FWjftEWIEio0qLBzbicCuu5sKzwNY47i5BPP3Ge s5sC8tzsqwHJ7a/lg3Dp4eXytNvpOT7KrRad3qEjubs5rUhWNNTI+uR+i5XWmBsUuw8XKN twP/z8S5YFTPDG3cBeO3BliJTQGoAU/944luqIMyrPaxv2OYm3AnJxYeA1XaWb6ws0v7kb 4JB9xZl7DvFisZzN7+BxLyziaZRzYaECRzrZBH/Tb/deTldLyLF1WchfL1HG0dCEFTGQHy BYh+XwQpeYSBZteTgkN72T+GYcTRj4r0PdSLrz8BszLtLTpvke1R44t+s+elYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jDc7T4ssMzSL4 for ; Tue, 27 Oct 2026 16:55:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2269d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Oct 2026 16:55:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: d9d6e77965b3 - main - tests/pf/igmp: fix attribute error with newer versions of scapy List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d9d6e77965b32a8d2f9eeffd34e519a087e603e2 Auto-Submitted: auto-generated Date: Tue, 27 Oct 2026 16:55:33 +0000 Message-Id: <6ae0d785.2269d.3ca3218a@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=d9d6e77965b32a8d2f9eeffd34e519a087e603e2 commit d9d6e77965b32a8d2f9eeffd34e519a087e603e2 Author: Siva Mahadevan AuthorDate: 2026-10-27 14:23:11 +0000 Commit: Siva Mahadevan CommitDate: 2026-10-27 16:54:20 +0000 tests/pf/igmp: fix attribute error with newer versions of scapy This fixes the flaky testcase in CI[0]. While here: * fix a typo in a comment * remove an unnecessary import * fix this deprecation warning: /usr/local/lib/python3.12/site-packages/scapy/contrib/igmp.py:12: DeprecationWarning: scapy.contrib.igmp is deprecated. Please use scapy.layers.igmp instead ! [0] https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29813/testReport/junit/sys.netpfil.pf.igmp/py/TestIGMP__test_ip_opts/ Reviewed by: kp MFC after: 3 days Sponsored by: The FreeBSD Foundation --- tests/sys/netpfil/pf/igmp.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tests/sys/netpfil/pf/igmp.py b/tests/sys/netpfil/pf/igmp.py index 5d72a1c093a7..6f2a5066155d 100644 --- a/tests/sys/netpfil/pf/igmp.py +++ b/tests/sys/netpfil/pf/igmp.py @@ -54,11 +54,11 @@ class TestIGMP(VnetTestTemplate): packets = self.sp.sniff(iface=ifname, timeout=5) for r in packets: r.show() - igmp = r.getlayer(self.sc.igmp.IGMP) + igmp = r.getlayer(self.sl.igmp.IGMP) if not igmp: continue igmp.show() - if not igmp.gaddr == "230.0.0.1": + if getattr(igmp, 'gaddr', '0.0.0.0') != "230.0.0.1": continue found = True return found @@ -69,33 +69,32 @@ class TestIGMP(VnetTestTemplate): """Verify that we allow IGMP packets with IP options""" ifname = self.vnet.iface_alias_map["if1"].name - # Import in the correct vnet, so at to not confuse Scapy + # Import in the correct vnet, so as to not confuse Scapy import scapy.all as sp - import scapy.contrib as sc - import scapy.contrib.igmp + import scapy.layers as sl self.sp = sp - self.sc = sc + self.sl = sl # We allow IGMP packets with the router alert option pkt = sp.IP(dst="224.0.0.1%%%s" % ifname, ttl=1, options=[sp.IPOption_Router_Alert()]) \ - / sc.igmp.IGMP(type=0x11, mrcode=1) + / sl.igmp.IGMP(type=0x11, mrcode=1) assert self.find_igmp_reply(pkt, ifname) # But not with other options pkt = sp.IP(dst="224.0.0.1%%%s" % ifname, ttl=1, options=[sp.IPOption_NOP()]) \ - / sc.igmp.IGMP(type=0x11, mrcode=1) + / sl.igmp.IGMP(type=0x11, mrcode=1) assert not self.find_igmp_reply(pkt, ifname) # Or with the wrong TTL pkt = sp.IP(dst="224.0.0.1%%%s" % ifname, ttl=2, options=[sp.IPOption_Router_Alert()]) \ - / sc.igmp.IGMP(type=0x11, mrcode=1) + / sl.igmp.IGMP(type=0x11, mrcode=1) assert not self.find_igmp_reply(pkt, ifname) # Or with the wrong destination address pkt = sp.IP(dst="224.0.0.2%%%s" % ifname, ttl=2, options=[sp.IPOption_Router_Alert()]) \ - / sc.igmp.IGMP(type=0x11, mrcode=1) + / sl.igmp.IGMP(type=0x11, mrcode=1) assert not self.find_igmp_reply(pkt, ifname)