From nobody Tue Oct 27 12:01:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jDTc104cvz6xTjT for ; Tue, 27 Oct 2026 12:01:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jDTc018Nmz3D1d for ; Tue, 27 Oct 2026 12:01:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793102480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hv4wxAV3PJM6SgpC2BoWLqlbBE9DYX9Y6CkpjBFcnGY=; b=HOG/LV1UV/WFRgPQ82m12xk+ILWW/VZQQUfqxxg+BdUlJh9DrVGxPU9BhI5eLgQyDuMSTU SeZYW6XBOSkIcQeXWr2TTl+AfwiHWqn5N2bjapPq42uNOpVFT4hUiTzJ12OBoFQL/vLwyc mtemW+pIkyLcZsunAD61wdDM+ITDiPMNyuE8fU/DyZyrqQ167VU7b4umUgizSEw+ndiObJ idy3eiwUMr/vQ00cRGZpvehtYwj/ETXwrsf239jUy1r0rLhKHyOneZ+v/ZHe/DMCUi0w4h ROlDZ4CeFEZs3LBmnltuI99HZHcRQF2gRxP/ho4lUe2pAVAaHyPEHY+d90rSbA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793102480; b=mi3n0jAjzehPIM5XJsxlt6YjNs5TD7WqAh4XHLNo94kd0ggdO+kg7pk/7NafZV+qRkVDJQ OpPaeUGUHkMXX25NogMAs03cSkKVd7+r64b7iLshopiAv03/dABh6J0YsgU7OoHDRNgiHY t/hBVsqzkMeE1UrDCjpEqbFMC/i9HamY0naTun5V/7gPIGpTkbXyLaqd54Pf8hd9gfYq0K 5AUWVQdBBuWz8o7o/8wbxF40VDCPQ5oO5t55McDfXxSQMGBA6/Af1I28p/IGbVEFMt+Xll xI+tUnpR8kntrVllyWJAt69YICGGga9z4DRl0YDizKO53e3wXz3vqQDp/ZGh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793102480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hv4wxAV3PJM6SgpC2BoWLqlbBE9DYX9Y6CkpjBFcnGY=; b=Snvb+rQyp9uxcup7szwlr6K8AB/9eQUVQ3HIyet9srB93LkJ8aHjZszVzwymZf1hg0clNG CohYSGX5yrRXA5TltjkXExJWi5ywjZjNuFv8J63HJVWVsH6T5IqNTc46Te3C3PJFuvSf8K SiYPfUkK4CDpoElf9ET9qPzkGsxDvgrjZPrFQs1pMoD8n307tX8lmMAjwoYSI/KMZN1kEx PjTFImn7C3WHrJDy9ES8VcuLTK7bHEsfQE6IyRuWyB6thXL0gxJHm5jIr8/fsSE7YazRsL GK13zVg0C8uakShNHoK47eO+EvE7oJ3JPl+AAJwxVM9kNzvbx5W8kDQFakRtow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jDTc00WD0zJnq for ; Tue, 27 Oct 2026 12:01:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32daf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Oct 2026 12:01:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 473cd1bba9b4 - main - amd64: fixes for register handling of syscall entry for FRED List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 473cd1bba9b4e80b741769ff6185ba3846b1f050 Auto-Submitted: auto-generated Date: Tue, 27 Oct 2026 12:01:20 +0000 Message-Id: <6ae09290.32daf.65231b73@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=473cd1bba9b4e80b741769ff6185ba3846b1f050 commit 473cd1bba9b4e80b741769ff6185ba3846b1f050 Author: Konstantin Belousov AuthorDate: 2026-10-27 09:21:55 +0000 Commit: Konstantin Belousov CommitDate: 2026-10-27 11:58:48 +0000 amd64: fixes for register handling of syscall entry for FRED - Save %r10 into tf_rcx. This is the location for the 4th arg. libsys stubs do 'movq %rcx, %r10' so the fast syscall path works as is. But Go binaries directly put arg 4 into %r10. Also save %r11 into tf_r11 for the duration of syscall handler. - Somewhat improve binary compatibility with IDT SYSCALL fast return, by copying userspace return %rip into %rcx, and %rflags into %r11, emulating SYSCALL IDT delivery. Fixes: 6e93f5e4d693 ("amd64: FRED support") Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/amd64/amd64/exception.S | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/amd64/amd64/exception.S b/sys/amd64/amd64/exception.S index 458a7c405793..206b56abc545 100644 --- a/sys/amd64/amd64/exception.S +++ b/sys/amd64/amd64/exception.S @@ -1428,7 +1428,7 @@ gsbase_load_fault: ALIGN_TEXT user_fred_syscall: movq %rdx,TF_RDX(%rsp) - movq %rcx,TF_RCX(%rsp) + movq %r11,TF_R11(%rsp) SAVE_SEGS movq PCPU(CURPCB),%r11 andl $~PCB_FULL_IRET,PCB_FLAGS(%r11) @@ -1439,6 +1439,7 @@ user_fred_syscall: movq %r9,TF_R9(%rsp) movq %rbx,TF_RBX(%rsp) movq %rbp,TF_RBP(%rsp) + movq %r10,TF_RCX(%rsp) movq %r12,TF_R12(%rsp) movq %r13,TF_R13(%rsp) movq %r14,TF_R14(%rsp) @@ -1462,10 +1463,11 @@ user_fred_syscall: movq TF_RSI(%rsp),%rsi movq TF_RDX(%rsp),%rdx movq TF_RAX(%rsp),%rax + movq TF_RIP(%rsp),%rcx + movq TF_RFLAGS(%rsp),%r11 xorl %r8d,%r8d xorl %r9d,%r9d xorl %r10d,%r10d - xorl %r11d,%r11d addq $TF_ERR,%rsp .globl fred_syscall_eretu fred_syscall_eretu: