From nobody Tue Oct 27 11:28:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jDSsl3W7zz6xR0J for ; Tue, 27 Oct 2026 11:28:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jDSsl14YDz56s0 for ; Tue, 27 Oct 2026 11:28:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793100491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nB38679wQJe/d4+ezTPghfTVAzWNqZ4+VW0TyYDd/no=; b=y3BVyINuURbv5fMfNy0xS95sh+ggNBiyUQMdYQQx8Ev7uW5P2PbakYnTfjQSmyk1kqVMCo Q0lnrLx7txNRVBpAdCBigxwqLZc7L6c2i6txSLzaWQUhoaoziMXH1SYxi0IHh/dl/sKLtJ dwz8Ms2Yawl4AivJpGpXu6YvTOgoSUiPDCPYpK1nheRIT0HPHBm4XOZKN2FqOh11ArRNxe CimR+FoGslQbsPauGGjN9rochn748GD4qnG30G3x5B3T1rZ7GN8gM8Iuyfg7Ux+pmC4Tfa JBp4nDbYSDPdu/+TFAHcjn8faAB/j2f/D7wDWFxNjawBdf2xjul91MjLPEtIYA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793100491; b=ZByFbI6FYTrCVn7AWT8WwQZ7KLwXMI9WeMyiKZ9qPP43XilwPPk8AK+kIYqwV9Cb91q6QO Zm8IJgJLrzbMOwF7rwmSo7oSDizskb+ACnYpSuI092/KQkugOIUEGKy1kZnzLbhknpyqyZ qRyaiqDroaIGmenBiIkhw8x0z2SyJb7BBTqUYjftSGgmidX8GFI1RZpgIgeajizjF0XEdV jHVe+edchpoXCaliMeFtOssB8PKPJxC3SFIu9fOImWwGSUCwFONfc8KVDPDbiIdyThk+im 8tvpuVyy21BuyC8aW66LB3nf5vxxbBAY+HMGVw9+hoN3X3cXShPOORVun+8dmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793100491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nB38679wQJe/d4+ezTPghfTVAzWNqZ4+VW0TyYDd/no=; b=mMBzw0D68Oinl/6ZQFiW2YtjU1S8R1HbuajiID4g0I3CgHuYQ40mO7bbhtSEuFf7cFQtfg WurUekhp1t8eRERtPqNewFtn3coVN03fHo9bhO5eh2gxGHOBcYIDGW5EOkjQNpe9odXxLy hfjPOfpjL2Nqvubjn5n2/Vw3O4vcDwndItn2UAbLYso1bWxg43Q3tjnmm7DPNojua2snl8 XaAaayX/22ckn0A6/s7qGfxJdT4PGV2uCDvGieie8TvLcGFh47U7Bu1mFRdEMKIaCeqCR5 mpxuDLktO4mVR+QvNLOLkIZ2tZ86RBE0pPy63YwQnF/2j/9Jr3rwN4I3Ld0tlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jDSsl0kP4zJT9 for ; Tue, 27 Oct 2026 11:28:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26a6d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Oct 2026 11:28:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: eb36c35ccf83 - main - sound tests: Check the return value of close(2) List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: eb36c35ccf83ea94d46a3bcb282c01ceeaeb3bab Auto-Submitted: auto-generated Date: Tue, 27 Oct 2026 11:28:11 +0000 Message-Id: <6ae08acb.26a6d.7a964a4f@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=eb36c35ccf83ea94d46a3bcb282c01ceeaeb3bab commit eb36c35ccf83ea94d46a3bcb282c01ceeaeb3bab Author: Christos Margiolis AuthorDate: 2026-10-27 11:27:32 +0000 Commit: Christos Margiolis CommitDate: 2026-10-27 11:27:32 +0000 sound tests: Check the return value of close(2) While here, remove two munmap(2) calls on mappings the tests require to have failed, since they are practically dead. MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60800 --- tests/sys/sound/mmap.c | 8 ++------ tests/sys/sound/polling.c | 10 +++++----- tests/sys/sound/sndstat.c | 4 ++-- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c index 95ed9a483274..e14405e1b4e5 100644 --- a/tests/sys/sound/mmap.c +++ b/tests/sys/sound/mmap.c @@ -40,9 +40,7 @@ ATF_TC_BODY(mmap_offset_overflow, tc) buf = mmap(NULL, len, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off); ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); - munmap(buf, len); - - close(fd); + ATF_REQUIRE(close(fd) == 0); } /* @@ -124,9 +122,7 @@ ATF_TC_BODY(mmap_reject_prot_exec, tc) fd, 0); ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); - munmap(buf, len); - - close(fd); + ATF_REQUIRE(close(fd) == 0); } /* diff --git a/tests/sys/sound/polling.c b/tests/sys/sound/polling.c index b7a328d13d4c..0f18c96e087c 100644 --- a/tests/sys/sound/polling.c +++ b/tests/sys/sound/polling.c @@ -98,7 +98,7 @@ ATF_TC_BODY(poll_kqueue, tc) ATF_REQUIRE_MSG(read(fd, buf, sizeof(buf)) > 0, FMT_ERR("read")); EV_SET(&ev, fd, EVFILT_READ, EV_DELETE, 0, 0, 0); - close(kq); + ATF_REQUIRE(close(kq) == 0); kq = kqueue(); ATF_REQUIRE_MSG(kq >= 0, FMT_ERR("kqueue")); @@ -113,9 +113,9 @@ ATF_TC_BODY(poll_kqueue, tc) ATF_REQUIRE_MSG(write(fd, buf, sizeof(buf)) > 0, FMT_ERR("write")); EV_SET(&ev, fd, EVFILT_WRITE, EV_DELETE, 0, 0, 0); - close(kq); + ATF_REQUIRE(close(kq) == 0); - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TC(poll_poll); @@ -154,7 +154,7 @@ ATF_TC_BODY(poll_poll, tc) wr = true; } } - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TC(poll_select); @@ -192,7 +192,7 @@ ATF_TC_BODY(poll_select, tc) wr = true; } } - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TP_ADD_TCS(tp) diff --git a/tests/sys/sound/sndstat.c b/tests/sys/sound/sndstat.c index bbf18aca2824..db8c9a9f5a0c 100644 --- a/tests/sys/sound/sndstat.c +++ b/tests/sys/sound/sndstat.c @@ -196,7 +196,7 @@ ATF_TC_BODY(sndstat_nv, tc) free(arg.buf); nvlist_destroy(nvl); - close(fd); + ATF_REQUIRE(close(fd) == 0); } #define UDEV_PROVIDER "sndstat_udev" @@ -374,7 +374,7 @@ ATF_TC_BODY(sndstat_udev, tc) free(arg.buf); nvlist_destroy(nvl); - close(fd); + ATF_REQUIRE(close(fd) == 0); } ATF_TP_ADD_TCS(tp)