From nobody Mon Oct 26 20:19:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jD4j21zczz6xYpq; Mon, 26 Oct 2026 20:19:18 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jD4j21Pmtz3JFy; Mon, 26 Oct 2026 20:19:18 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793045958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f+V84duSJryHnK4LfnV8A5RsnLEiTjF4mtDjMpT4q7Q=; b=IorrWlPLQCcXkIASyOhU9E89+BtrXqx/o4EyYmt8YHgF5S8IkNfkg9u6rgGzmQ9d+0h0yE IaA6xT9yoG0C/NHD7MEGgshfUBVI4lbP+3wVW2v6s9qKRlEJAKmZ0fw/khVCCXSKqmnC0J oy3ew5IfoTfDOI+9YjiYQCCyStBbqnwgwbpEJp0tAxs4bt0vm81BkGVfSnG+c+PnZAsv4J uQbkZ7oZbWTfQpTOpCBhpIMr3q7K5VXQRIqEM1dNvENC+r+Uof0OeOXhO/U9VQyxILpLro O9Loi+wGCeNWvkIKWpFAYc9Fm+q15yV+DK15V0U9WdSIwNaaUxf1Qo46utOQkQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793045958; b=j1SpWyZskrLZ/wS2MFM3g+giuRMZa1cO3IImN78t8v6oN/9sGqV03cHwNX0g0Gzo2PMXCY /Gx8MKdtoqSIXbbaupRnK4fvty08YquVYxjbUjX3gXlq1o/RbMCMk5sZN2oJ5msy/eNpXv xYrtW7EA1vS+qhJRbiz1tMikOaNiH9sxsLZ3CxODNRLC4ENr0o0KsaHVRcadX53UbQE4zN XIHwBsL64VXgIlfCDmj8CpVnYqRb+FsbyGtVNbBrrKqNE6+Po6/lnTVVGt/F8A+mDi7ACj yq9QNAYz8YEE+UNFi9qW49RdXul9cxD2pDuXdKWHESWyLpbOTkU+FnKFb3vb4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793045958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f+V84duSJryHnK4LfnV8A5RsnLEiTjF4mtDjMpT4q7Q=; b=Ql+9qVHvudP+jfX4BxSpMPHqk7lLUGZM3AkWmeRDuPh7edI8JtuWSlWdvkuLaIy1wumN2A XAYiLGjpshkjW/qnx3fK2BvB3op0tCMVpQS2QGwIrLtxWTBxRWqOtLk83+SgEWQrSw9nOY Ycl/OQGcUz9s2xbWVivR/lKsuldQYHod4h9ZvEBIps5rYd33CPr/xV9FdGE3jPZ/6FFMAO BhCdijws7KoidgHl+XSwCjI1CXaL4fat5lu3BayhW75lHQ+K2nZEMxFpueUx3cZAXeR/v7 xkjHL80yCHZspaclEqiRCoB97G1rNx1uR1n1PJcBhJ+uOCwZCobFwqTTMjgq5Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (unknown [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4jD4j141h8ztBM; Mon, 26 Oct 2026 20:19:17 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 26 Oct 2026 13:19:10 -0700 From: Gleb Smirnoff To: Michael Tuexen Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Albin Hellqvist Subject: Re: git: 7b8151b0cd1b - main - sctp: improve handling of SO_SETFIB socket option Message-ID: References: <6adfa7a8.36388.737228bd@gitrepo.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6adfa7a8.36388.737228bd@gitrepo.freebsd.org> On Mon, Oct 26, 2026 at 07:19:04PM +0000, Michael Tuexen wrote: M> commit 7b8151b0cd1b4f077b382b6be2c02c936d1988fa M> Author: Albin Hellqvist M> AuthorDate: 2026-10-26 19:07:03 +0000 M> Commit: Michael Tuexen M> CommitDate: 2026-10-26 19:07:03 +0000 M> M> sctp: improve handling of SO_SETFIB socket option M> M> Since SCTP keeps fibnum in the SCTP protocol control block, M> the code can't just defer the processing to the IPv4 or IPv6 M> layer. Therefore it needs to be implemented in the the SCTP M> layer and it needs to call the socket layer function. M> M> PR: 300091 M> Reviewed by: tuexen M> Fixes: caccbaef8e26 ("socket: Move SO_SETFIB handling to protocol layers") M> MFC after: 3 days M> MFC to: stable/14 M> MFC to: stable/15 This change reminded me of the mess we have. The inpcb already stores the fib in inp_inc.inc_fibnum and some protocols (TCP and SCTP) copy it from so->so_fibnum. In general FIB number is definitely not a socket feature - a unix(4), netlink(4), netgraph(4), list to be continued can't have a notion of FIB number. This all needs to be cleaned up. -- Gleb Smirnoff