From nobody Sat Oct 24 00:01:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jBKmW1XPSz6wjYn for ; Sat, 24 Oct 2026 00:01:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jBKmW14BBz4Cmt for ; Sat, 24 Oct 2026 00:01:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792800075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o+qvnD1bvwoyptC72StHWv+xc9kIVKenvMb6X7KMU8A=; b=AxEy4eWcN1mqZu3EQ2R13Zto6NWr3dqOtqMI2o8WgXu27XwnDmwed9pugNZJFI4yp+P0KI uQKWMUmvrXy4pkzu1ocDydeUL8hlyJYa98PZWQ2xiKhBxSDLvD1D4BNLzhWYc6407URK/k CsZP9Z2g3eaV6TRnIR2VqxlvuwqBMENTvX5xfrxPiVplcjfurzS8t71J6qBSYR/xXGyPJr FkZ03VBYH18lpGWEiZMhpEmGBEhrpW1iKUIONxi0e2B4606CuYdCVInOCF8qp27ThXGdYk 98SU/Z+/Gbvgaee0N6s8c96lcZYj8FE9Q6A5FhUSBd4ooAFJivwY/FipFYvkkg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792800075; b=aWUFlJWzsTS6nD1Fd7YJ/6MfDl6ahTzzzLLcT/0FjJIhrO8yudLyU7tA+UBWlm0YfD/5ZD ShIEcmPaCxRrbczsRtME+AOIPQhfv1f7+ld/8VP6ssN2dXzWJXTIa/Z3UHdGu+8LzwlgS8 afKJupZWvtUtdOx14ierskZLl+ao/qvto2Hps5yvwZREXPcWL3krLfaD/DZvz7BctpRJ1M wwLs2sygzhRTZSq+ekGnZ4T3AaDAmvCSPTMhwm526VGp9/jRuj3vDWIt4Snv1bDYDREaPr cQtZNSlnBSPHLWypUbirSdJjlMvrzqL41S69DnQWsVKNdHD/A0KTX31XNnytrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792800075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o+qvnD1bvwoyptC72StHWv+xc9kIVKenvMb6X7KMU8A=; b=NnO7I1rPFs62eVysoE5YKoAXIYe2wsg9mxN7o5gCWreF0UsfG51jEfQylqq7jM540579b7 HSPbJlkwOE5assjBXkwGlKYpQEiEx4AFqkxXg4u4mYrvtIE8+U40hvAOYOkd+3+QixPlxq nugeKQsQWr0sl+zqLfFe4KT5mMqyKR5gwiQrBIg6FB12If/X3p/x8yZ+wkgPvdaBAOGJk2 ztpK6GuKhpSTuEN3xKht1PQFb+1SdGHPqveU1x4nTDiiiISf3+wBp18zBMZG8xTMcqxbbk 6dPZkDdILCaIovacZalaofPYCk3IKTC1qSXSiTPicG07PbdMXln09GveMUCdtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jBKmW0kVbzsjL for ; Sat, 24 Oct 2026 00:01:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c452 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 24 Oct 2026 00:01:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: cb77c4e846d4 - main - amdsmu: Don't rely on s0i3_last_entry_status metric List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cb77c4e846d420af4d7d43f6616da213689a734b Auto-Submitted: auto-generated Date: Sat, 24 Oct 2026 00:01:09 +0000 Message-Id: <6adbf545.1c452.7c6bbc04@gitrepo.freebsd.org> The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=cb77c4e846d420af4d7d43f6616da213689a734b commit cb77c4e846d420af4d7d43f6616da213689a734b Author: Aymeric Wibo AuthorDate: 2026-10-23 23:56:58 +0000 Commit: Aymeric Wibo CommitDate: 2026-10-24 00:00:42 +0000 amdsmu: Don't rely on s0i3_last_entry_status metric This metric seems unreliable and I have observed it occasionally report 1 (successful entry to S0i3) when the time_last_in_s0i3 metric was 0 on Phoenix, which does not make sense. So just rely on time_last_in_s0i3 instead. Sponsored by: The FreeBSD Foundation --- sys/dev/amdsmu/amdsmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/amdsmu/amdsmu.c b/sys/dev/amdsmu/amdsmu.c index 0e4f0bc17e22..555b263b5bc7 100644 --- a/sys/dev/amdsmu/amdsmu.c +++ b/sys/dev/amdsmu/amdsmu.c @@ -323,7 +323,11 @@ amdsmu_resume_check(device_t dev, enum power_stype stype) if (stype != POWER_STYPE_SUSPEND_TO_IDLE) return; - if (m->s0i3_last_entry_status != 0) { + /* + * XXX For some reason, s0i3_last_entry_status sometimes reports 1 when + * system didn't enter S0i3 during the last suspend. + */ + if (m->time_last_in_s0i3 != 0) { device_printf(dev, "spent %lu seconds in S0i3 during last suspend\n", m->time_last_in_s0i3 / 1000000);