From nobody Fri Oct 23 21:59:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jBH444VvCz6wWlN for ; Fri, 23 Oct 2026 21:59:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jBH442lGTz4vlg for ; Fri, 23 Oct 2026 21:59:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792792772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=acRvkq90fRqzl0Ge8KPbO/wyZl0zYwZuK0lxIadGwUs=; b=HUnCiojSk7ZYQtUn1RGKWWK4z9MDgEoLmRkGEjXGs3w6RS2A+p2Tz3sneijcPQqQe4zIIO An4jvIUfhaI8Pp7BLTOxXO9oPmHgO0T8W1BznYZX6kZSFlPVDIZhgwtNK9PBWTIXz34QGD PScvpvU5tMUIJm3WpqsNifZGTGSLVZ86+MURrwXzK3OaBEqqoC7ykjS/xnyIHoQbZuGyDC u2Vntugykzp+oljoZwCGZLzmcHm8T0cMT4aacQBy42HFuKCp3QzDgqGRJ7miZz7dZxNV2N gNxsi3Wx+TTh7TI1Iv3M0k9teHCftm+U9r8DJaXyuqi08CQpKRXJr0tQf/fWGg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792792772; b=HAR3pDv2NRMMTFvOV0cdo48HOoelGWhvqwLNYwYtf6qSbAuFdx5X7L0XH0J+1j9IxuaRCB rye9tOVCGJzZWIyU/MkPocyJ5YQDunqzTw2Jwh3RvD/7L9IaEmZ2XYrXUwlwavZSTMJzU4 N618bpygI4W4dNyzESfL2EiTkw/IDBHRmYdCZMhgt96a4zfz+juk9GzcxuS8uSEC2DgcKS 9v1KQY6aHLEkJpKBdSri8FiUYc+8BI3nJIBLMr122fNrLnmOt//Zb1KgViqFYIqZdT9UuR meAnKxeZBeng4HyQDIFFsIEIZk/Bk7KHuEFFzEwkYdEdbwlhIVlKI2qN2pxvLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792792772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=acRvkq90fRqzl0Ge8KPbO/wyZl0zYwZuK0lxIadGwUs=; b=pMS8LNlx1KFcBohZgKbvAULTKUvMJ8NiNsbBsYP6h9sV6y2ayZH4Vy29QbTiPHvjuJWh7c 39f1jY0NBQuldNjN6wconfQi3Vjdv8nTGRNj2bwHzzLzKA+2eZW9bC8ur5sebAVDFtpC18 VmnFWcsM4CXbQyYAwSRsEgUCW3xhcNhMfgl+uNCjmzd+BivL1vh96tYXImgxIyBOnzXP32 3+Ihw9dqPZFRK/qjwgXGFthlb1czTD6wIVdL7HQnqYQtDcN0klBrwYICFTfTR/85jrKy9u BLtTezR3dbVKaY4zl/Yx4onUYc3grYDCeahWCGfLw/NMP8kVR8HCGa0H+/hdGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jBH442Q6jzp5h for ; Fri, 23 Oct 2026 21:59:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bfc4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 23 Oct 2026 21:59:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 13011cbf7d80 - main - smsc: Remove phy address check in smsc_miibus_writereg List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13011cbf7d80cd1554d87296225ceccb3f7524b4 Auto-Submitted: auto-generated Date: Fri, 23 Oct 2026 21:59:27 +0000 Message-Id: <6adbd8bf.3bfc4.397fc400@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=13011cbf7d80cd1554d87296225ceccb3f7524b4 commit 13011cbf7d80cd1554d87296225ceccb3f7524b4 Author: Ed Maste AuthorDate: 2026-10-15 13:31:41 +0000 Commit: Ed Maste CommitDate: 2026-10-23 21:58:51 +0000 smsc: Remove phy address check in smsc_miibus_writereg The driver only allowed writes to the expected phy (i.e., sc->sc_phyno), and reads were never filtered. sc_phyno is already passed to mii_attach() as phyloc, so nothing tries to issue MDIO writes to other addresses and the check is not required. Remove the check in advance of supporting external PHYs at arbitrary addresses. Tested on Microchip's EVB-LAN9500A-LC LAN9500A evaluation board. Sponsored by: The FreeBSD Foundation Sponsored by: Microchip (Hardware) Differential Revision: https://reviews.freebsd.org/D60743 --- sys/dev/usb/net/if_smsc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c index c3c21fd22472..5803a5bd1bcf 100644 --- a/sys/dev/usb/net/if_smsc.c +++ b/sys/dev/usb/net/if_smsc.c @@ -494,9 +494,6 @@ smsc_miibus_writereg(device_t dev, int phy, int reg, int val) int locked; uint32_t addr; - if (sc->sc_phyno != phy) - return (0); - locked = mtx_owned(&sc->sc_mtx); if (!locked) SMSC_LOCK(sc);