From nobody Fri Oct 23 17:37:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jB9G25W0Hz6xM5W for ; Fri, 23 Oct 2026 17:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jB9G23n3wz561X for ; Fri, 23 Oct 2026 17:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wQXXK2eYAw14l3rPKuhN//m7Ymi7jioSmpK+QQndN3o=; b=LJYUkabM4qcuHIJAouYccCSjDhCbCWM375/TPsNmroz4FcYAT+DbLqzcw03UiTta6XEfi9 ceEip3ORsPmScgL24EYguQbMmHopisurB1sL6qkAu+qtQc9xHuKz6JsO61vsWGFi/a/RYn /evzM3odvcIRIOYS5AFDbcxHJ/D4mSSbREY3HlGuPgYykCjbYnHY1BAresoIXAe7iRoXXE AE51oCoyjyW1Uf+jXBnpduZZVwseQZjj5dKQkGgvNlZUq+zmI3W2yb5kBxpvNI4/rOssKM aLiNwAVRYh75kyu2DRrjqPsj5Syl6laiyOWf7sedmgeCOVrmFK1lFn5XY+z3bA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792777066; b=ENMeNEdcQNbnrVFxrZSik8n3Tg+FBSa8tMFGKKAeJGOxPthIXWI4Je2JYMimdfkNub6yEm 5GX4u3NXaHraU6OXwcVZaaC2dngMnfrunc7odxJSLt1307sD9rgnRFkEiosAsa9OKUPYCk KDoo2kenzG8B4nHu1TZo0rAqAFPYBme8NeNyZTRx4P0mnP83XXSLh53gTANamTvbRnAC6M 9V71qqajsE+L+S0/k0X+kZyRtqyrEGZp6Q5l+WiCxbEqEAZHY7WGS9z5ZvsADgz7nMbWNw GVVZB9vCujn7LlgOd0u7g3pPknExD+AlCyzDGbPcOAFDl1xzcewoGa7dDKLLfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792777066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wQXXK2eYAw14l3rPKuhN//m7Ymi7jioSmpK+QQndN3o=; b=hdlXROYFyu+xTvA/fOWRGByy/P63ZQ/LOSYT5DvEZ3VhVmIdAAqkP4RwuR96ZSLw7ckxfB gyW6RjGQXaM++P4CXxkXB5x4wUv1fMaklK68p0AuNiKWIpcXbm+Z+5kPlrqTc/NiuEL2AD +ZJA9PRAei2+9hlFpJ8vW1RJZO7VcstY19Yp+yMmjlI1496QcwCgbxTcngLGq1WMW/Gw5R +Wm/dkgbq09OzS4DbaJAW6VVR6XO3r989k7m04n1tkCyxm8uMGTesMLkfptVUmyK/+A4ux rJ5EReY4/LZfmmpuSYAeo7l38lwP/TiNKV7VSLdWICvIqRPaCL04DFBIMrxI8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jB9G22zMPzgcv for ; Fri, 23 Oct 2026 17:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 18b19 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 23 Oct 2026 17:37:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 6fa319d8c670 - stable/15 - tcp md5: fix accounting for SYN segments with unexpected signature List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6fa319d8c6702bb7dc01435e8ae8e90a6259b90e Auto-Submitted: auto-generated Date: Fri, 23 Oct 2026 17:37:46 +0000 Message-Id: <6adb9b6a.18b19.643aaef2@gitrepo.freebsd.org> The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=6fa319d8c6702bb7dc01435e8ae8e90a6259b90e commit 6fa319d8c6702bb7dc01435e8ae8e90a6259b90e Author: Michael Tuexen AuthorDate: 2026-09-04 07:18:10 +0000 Commit: Michael Tuexen CommitDate: 2026-10-23 17:36:36 +0000 tcp md5: fix accounting for SYN segments with unexpected signature When receiving a SYN segment with an MD5 option on a listening socket, which has not enabled TCP MD5 support, increment the counter for unexpected signatures (tcps_sig_err_sigopt). Reviewed by: rscheff Differential Revision: https://reviews.freebsd.org/D59303 (cherry picked from commit 5d3e31df7c4fc0e53168bac717bed5f94dab7068) --- sys/netinet/tcp_syncache.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index e655b7d9c9f9..7c1c1f95856a 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -1497,8 +1497,10 @@ syncache_add(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, TCPMD5_INPUT(m, NULL, NULL) != ENOENT) goto done; } - } else if (to->to_flags & TOF_SIGNATURE) + } else if (to->to_flags & TOF_SIGNATURE) { + TCPSTAT_INC(tcps_sig_err_sigopt); goto done; + } #endif /* TCP_SIGNATURE */ /* * See if we already have an entry for this connection.