From nobody Thu Oct 22 17:31:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j9Y9m099bz6xP2C for ; Thu, 22 Oct 2026 17:31:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j9Y9l3SrQz3GkS for ; Thu, 22 Oct 2026 17:31:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792690315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AwY5U7WPKx94eoH9+48uwft+3YnzBkE+OAWaYXNrykg=; b=EZYcTm6otNlWqOBgDbDwSKDCu0pzW4k7C8gXEVGCyjROjuZyoMlVFdpu/04Qa6MEijOJhb 1qnuS5ed6WZvtCAhfwZjHiKfthImxPCafQylc2Qor0mjMWRlwNt+suD3A0zemncwkYW6Zz frHn26PxmRrT3QSxs88EW367PX9rV3L7/Bn+F2+/WKrC4UihYd5L/CXfJ52bKqCVcE+K4t XCnlHY4YdOnKdcSt+sCMuLKBBjPfdZZ0BpT+5cOp6iFFhKdPFjaMMCH9iHceEKbPLdn9hL qE8D6EGHnxYgYjY/Owh9vQPu3Qn5fLgzKxr/Szov9NeDR5qJ+vTMexBOOF4ylw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792690315; b=f4nqVZ/TfgOREFrphE/r13eVCKdva1xs7esnjJho4yPAd8piWKI+V1KuQBWGesJNZnWfIh kN9IHgEiRrC5UeonP2ZTVJEINeM2atw+uTiK9vDAZFga49bGbU9MV63ovvbVB5E0zDNbAG aTMCfVc7JjiskuwAUgYBj4FAUBAo4FBj1SKN4Q7jlVsRHZd2whU9KI8M8Lac/8gssVVhK4 FGP2CDx6zBbs1GGKNLOBMxv6KfjLvTpsdUJTIp6zYp77MzENC2Hcu4ARogaQZdq83azDWE rsFxlcVZMXDuKiyIRnsocAxPscW9IgRGpKntAXLCwI/JG3HoUAry/v0msANr4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792690315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AwY5U7WPKx94eoH9+48uwft+3YnzBkE+OAWaYXNrykg=; b=DIuI65crdMUFJObZVwntyUTVDNewwvy5JadeiJp+7KzZYdSG+PbKnYJYdQwSuAoeq98U+Z zs7N3BTAim6RPppAIOlWAQVf8UxEkpt8GLFZ+Is+LcujgHFP0ApdPxpS2UbN2b5R64wK2j eSaRlApjd4JZW9lIm/Bj9kqhVdg9cVc26thXneCHsBosjYidtnrzdvEmH71r3GZqJQJtsa kEueSzyncxmODBdUNJGVFIB70MwhQJKNFj2nncNk81zXHiA58Zu80BNo1W/Fsf1Ckk9f1c tqH/WMnkCay5sIxAfIHuxG3DADxLbVQdPAY6h1rBrHOf4uSbxb5OAgOvsrqrQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j9Y9l35p4zrnS for ; Thu, 22 Oct 2026 17:31:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e508 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 22 Oct 2026 17:31:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Hayzam Sherif From: Mark Johnston Subject: git: c47d9aa11337 - stable/15 - vmm: Re-arm the PIT callout for square wave mode List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c47d9aa113375219284a480955deb221f39436f2 Auto-Submitted: auto-generated Date: Thu, 22 Oct 2026 17:31:55 +0000 Message-Id: <6ada488b.3e508.4de04ab4@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c47d9aa113375219284a480955deb221f39436f2 commit c47d9aa113375219284a480955deb221f39436f2 Author: Hayzam Sherif AuthorDate: 2026-09-21 16:34:37 +0000 Commit: Mark Johnston CommitDate: 2026-10-22 15:45:40 +0000 vmm: Re-arm the PIT callout for square wave mode The 8254's square wave mode (mode 3) is periodic, with the same interrupt rate as the rate generator mode (mode 2), but vatpit_callout_handler() only re-arms the channel 0 callout for TIMER_RATEGEN. A guest that programs mode 3 therefore receives a single IRQ0 and no further timer interrupts. Re-arm the callout for TIMER_SQWAVE as well, matching illumos change 13301. Reviewed by: markj Obtained from: illumos 93d78aba5b32996fc2ae893a6237a0d3972f86b2 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59816 (cherry picked from commit fc44154841fc2ebb1530a10cad719edb58559a88) --- sys/amd64/vmm/io/vatpit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/vmm/io/vatpit.c b/sys/amd64/vmm/io/vatpit.c index 595c2e070c7a..bdc93d2b8e27 100644 --- a/sys/amd64/vmm/io/vatpit.c +++ b/sys/amd64/vmm/io/vatpit.c @@ -165,7 +165,7 @@ vatpit_callout_handler(void *a) callout_deactivate(callout); - if (c->mode == TIMER_RATEGEN) { + if (c->mode == TIMER_RATEGEN || c->mode == TIMER_SQWAVE) { pit_timer_start_cntr0(vatpit); }